From 5d839f4811afda1865029ef1d1c93e6c26aa39b0 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Mon, 10 Aug 2026 15:36:07 +0200 Subject: [PATCH] fix: Silence -Wunused-variable on Vault clawback/withdraw asserts Mark `assetsAvailable`/`assetsTotal` in VaultClawback::doApply and `assetsTotalBefore` in VaultWithdraw::doApply as [[maybe_unused]]: each is only referenced from XRPL_ASSERT, which is compiled out in Release (NDEBUG) builds. Without the attribute clang -Werror,-Wunused-variable would break the release CI configurations, matching the pattern already addressed for VaultHelpers and LoanPay. Co-authored-by: Cursor --- src/libxrpl/tx/transactors/vault/VaultClawback.cpp | 4 ++-- src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libxrpl/tx/transactors/vault/VaultClawback.cpp b/src/libxrpl/tx/transactors/vault/VaultClawback.cpp index 9fa318ab6b..56c9793c96 100644 --- a/src/libxrpl/tx/transactors/vault/VaultClawback.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultClawback.cpp @@ -350,8 +350,8 @@ VaultClawback::doApply() Asset const vaultAsset = vault->at(sfAsset); STAmount const amount = clawbackAmount(vault, tx[~sfAmount], accountID_); - Number const assetsAvailable = vault->at(sfAssetsAvailable); - Number const assetsTotal = vault->at(sfAssetsTotal); + [[maybe_unused]] Number const assetsAvailable = vault->at(sfAssetsAvailable); + [[maybe_unused]] Number const assetsTotal = vault->at(sfAssetsTotal); [[maybe_unused]] auto const lossUnrealized = vault->at(sfLossUnrealized); XRPL_ASSERT( diff --git a/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp b/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp index f1bc9e0c68..1673acae0b 100644 --- a/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp @@ -289,7 +289,7 @@ VaultWithdraw::doApply() } Number const assetsAvailableBefore = vault->at(sfAssetsAvailable); - Number const assetsTotalBefore = vault->at(sfAssetsTotal); + [[maybe_unused]] Number const assetsTotalBefore = vault->at(sfAssetsTotal); auto const lossUnrealized = vault->at(sfLossUnrealized); XRPL_ASSERT( lossUnrealized <= (assetsTotalBefore - assetsAvailableBefore),