ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-29 10:00:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): remove duplicate add_module(xrpl tx) declaration

Browse Source 
The phase-2 merge re-added the pre-telemetry `add_module(xrpl tx)` block
without removing it, leaving the module declared twice. CMake's
add_library rejects a repeated target name, so configure failed before
any compilation:

  add_library cannot create target "xrpl.libxrpl.tx" because another
  target with the same name already exists.

Drop the stale pre-telemetry block and keep the one that follows
add_module(xrpl telemetry), which links both ledger and telemetry.
libxrpl/tx needs the telemetry link for the tx.transactor span, and
levelization already records `libxrpl.tx > xrpl.telemetry`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-07-27 18:32:13 +01:00
parent 23d5271eb6
commit 5a44eb7b1f
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmake/XrplCore.cmake
View File

@@ -204,9 +204,6 @@ target_link_libraries(
xrpl.libxrpl.conditions
)
add_module(xrpl tx)
target_link_libraries(xrpl.libxrpl.tx PUBLIC xrpl.libxrpl.ledger)
add_module(xrpl consensus)
target_link_libraries(
xrpl.libxrpl.consensus