From 5a44eb7b1f3a9a65b3d1dacdb8a092279810d5d4 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 27 Jul 2026 18:32:13 +0100 Subject: [PATCH] fix(build): remove duplicate add_module(xrpl tx) declaration The phase-2 merge re-added the pre-telemetry `add_module(xrpl tx)` block without removing it, leaving the module declared twice. CMake's add_library rejects a repeated target name, so configure failed before any compilation: add_library cannot create target "xrpl.libxrpl.tx" because another target with the same name already exists. Drop the stale pre-telemetry block and keep the one that follows add_module(xrpl telemetry), which links both ledger and telemetry. libxrpl/tx needs the telemetry link for the tx.transactor span, and levelization already records `libxrpl.tx > xrpl.telemetry`. Co-Authored-By: Claude Opus 5 --- cmake/XrplCore.cmake | 3 --- 1 file changed, 3 deletions(-) diff --git a/cmake/XrplCore.cmake b/cmake/XrplCore.cmake index 5ef153c3da..4761567232 100644 --- a/cmake/XrplCore.cmake +++ b/cmake/XrplCore.cmake @@ -204,9 +204,6 @@ target_link_libraries( xrpl.libxrpl.conditions ) -add_module(xrpl tx) -target_link_libraries(xrpl.libxrpl.tx PUBLIC xrpl.libxrpl.ledger) - add_module(xrpl consensus) target_link_libraries( xrpl.libxrpl.consensus