ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 09:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix straggling issues

Browse Source
This commit is contained in:
Mayukha Vadari
2026-05-06 11:38:50 -04:00
parent 7b9a98692d
commit 1e51b61747
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libxrpl/tx/invariants/InvariantCheck.cpp
View File

@@ -1004,7 +1004,7 @@ hasConstantFieldChanged(STObject const& before, STObject const& after, SOTemplat
constant != SoeImmutable, "xrpl::hasConstantFieldChanged : constant is invalid");
if (constant == SoeImmutable)
{
if (elem.style() == soeOPTIONAL)
if (elem.style() == SoeOptional)
{
// Optional constant fields may be added or removed,
// but their value must not change once present.
@@ -1020,7 +1020,7 @@ hasConstantFieldChanged(STObject const& before, STObject const& after, SOTemplat
return true;
}
}
// soeNOTCONSTANT fields may change freely — no recursion
// SoeMutable fields may change freely — no recursion
// into inner objects/arrays is needed because the parent
// field explicitly allows changes to its entire contents.
}

4
src/test/app/Invariants_test.cpp
View File

@@ -2138,7 +2138,7 @@ class Invariants_test : public beast::unit_test::Suite
}
}
// Template-based checks: soeNOTCONSTANT field
// Template-based checks: SoeMutable field
// (sfPreviousTxnID) on AccountRoot should NOT fail when
// modified — no invariant checks this field.
{
@@ -2181,7 +2181,7 @@ class Invariants_test : public beast::unit_test::Suite
}
}
// Without featureInvariantsV1_1, modifying a soeCONSTANT field
// Without featureInvariantsV1_1, modifying a SoeImmutable field
// that is NOT sfLedgerEntryType/sfLedgerIndex on a non-loan
// type should NOT fail (old code doesn't check it)
{