fix clang-tidy issues

This commit is contained in:
Mayukha Vadari
2026-05-06 11:36:45 -04:00
parent 98ed477ca7
commit 7b9a98692d
6 changed files with 7 additions and 7 deletions

View File

@@ -587,7 +587,7 @@ public:
/** Returns `true` if the field is set.
Fields with soeDEFAULT and set to the
Fields with SoeDefault and set to the
default value will return `true`
*/
explicit

View File

@@ -27,7 +27,7 @@ public:
SF_UINT32::type::value_type flags = 0)
{
// Don't call object_.set(soTemplate) - keep object_ as a free object.
// This avoids creating STBase placeholders for soeDEFAULT fields,
// This avoids creating STBase placeholders for SoeDefault fields,
// which would cause applyTemplate() to throw "may not be explicitly
// set to default" when building the SLE.
// The SLE constructor will call applyTemplate() which properly

View File

@@ -35,7 +35,7 @@ public:
std::optional<SF_AMOUNT::type::value_type> fee)
{
// Don't call object_.set(soTemplate) - keep object_ as a free object.
// This avoids creating STBase placeholders for soeDEFAULT fields,
// This avoids creating STBase placeholders for SoeDefault fields,
// which would cause applyTemplate() to throw "may not be explicitly
// set to default" when building the STTx.
// The STTx constructor will call applyTemplate() which properly

View File

@@ -39,7 +39,7 @@ associateAsset(SLE& sle, Asset const& asset)
// associateAsset in derived classes may change the underlying
// value, but it won't know anything about how the value relates to
// the SLE. If the template element is soeDEFAULT, and the value
// the SLE. If the template element is SoeDefault, and the value
// changed to the default value, remove the field.
if (style == SoeDefault && ta.isDefault())
sle.makeFieldAbsent(field);

View File

@@ -226,7 +226,7 @@ MPTokenIssuanceSet::preclaim(PreclaimContext const& ctx)
}
}
// sfMutableFlags is soeDEFAULT, defaulting to 0 if not specified on
// sfMutableFlags is SoeDefault, defaulting to 0 if not specified on
// the ledger.
auto const currentMutableFlags = sleMptIssuance->getFieldU32(sfMutableFlags);
@@ -329,7 +329,7 @@ MPTokenIssuanceSet::doApply()
if (auto const transferFee = ctx_.tx[~sfTransferFee])
{
// TransferFee uses soeDEFAULT style:
// TransferFee uses SoeDefault style:
// - If the field is absent, it is interpreted as 0.
// - If the field is present, it must be non-zero.
// Therefore, when TransferFee is 0, the field should be removed.

View File

@@ -3639,7 +3639,7 @@ protected:
auto const loan = objects[0u];
BEAST_EXPECT(loan[sfBorrower] == lender.human());
// soeDEFAULT fields are not returned if they're in the default
// SoeDefault fields are not returned if they're in the default
// state
BEAST_EXPECT(!loan.isMember(sfCloseInterestRate));
BEAST_EXPECT(!loan.isMember(sfClosePaymentFee));