Apply suggestions from code review

Incorporating suggestions from tequdev and akulkarni

Co-authored-by: tequ <git@tequ.dev>
This commit is contained in:
Amarantha Kulkarni
2024-12-20 13:38:02 -08:00
committed by GitHub
parent 65d5f2d308
commit 3c966592ce
4 changed files with 14 additions and 13 deletions

View File

@@ -15,7 +15,7 @@ This transaction enables an account to hold an amount of a particular MPT issuan
If the issuer has set `lsfMPTRequireAuth` (allow-listing) on the `MPTokenIssuance`, the issuer must submit an `MPTokenAuthorize` transaction as well in order to give permission to the holder. If `lsfMPTRequireAuth` is not set and the issuer attempts to submit this transaction, it will fail.
## MPTokenAuthorize Fields
<!-- ## MPTokenAuthorize Fields -->
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}

View File

@@ -11,7 +11,7 @@ labels:
_(Requires the [MPToken amendment][] {% not-enabled /%})_
The `MPTokenIssuanceCreate` transaction creates an MPTokenIssuance <!--[MPTokenIssuance](mptokenissuance.html)--> object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags).
The `MPTokenIssuanceCreate` transaction creates an [MPTokenIssuance](../../data-types/mptokenissuance.md) object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags).
If the transaction is successful, the newly created token is owned by the account (the creator account) that executed the transaction.
@@ -22,22 +22,21 @@ Whenever your query returns an `MPTokenIssuance` transaction response, there wil
This example assumes that the issuer of the token is the signer of the transaction.
```json
Example MPTokenIssuanceCreate transaction
{
"TransactionType": "MPTokenIssuanceCreate",
"Account": "rajgkBmMxmz161r8bWYH7CQAFZP5bA9oSG",
"AssetScale": "2",
"AssetScale": 2,
"TransferFee": 314,
"MaximumAmount": "50000000",
"Flags": 83659,
"MPTokenMetadata": "FOO",
"Fee": 10
"Fee": "10"
}
```
## MPTokenIssuanceCreate Fields
<!-- ## MPTokenIssuanceCreate Fields -->
<!-- {% include '_snippets/tx-fields-intro.md' %} -->
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
| Field | JSON Type | [Internal Type][] | Description |
|:----------------|:--------------------|:------------------|:-------------------|
@@ -50,7 +49,7 @@ Example MPTokenIssuanceCreate transaction
## MPTokenIssuanceCreate Flags
Transactions of the MPTokenIssuanceCreate type support additional values in the `Flags` field <!-- [`Flags` field](transaction-common-fields.html#flags-field)-->, as follows:
Transactions of the MPTokenIssuanceCreate type support additional values in the [`Flags` field](../common-fields.md#flags-field), as follows:
| Flag Name | Hex Value | Decimal Value | Description |
|:-------------------|:-------------|:--------------|:------------------------------|

View File

@@ -6,6 +6,7 @@ labels:
- Multi-purpose Tokens, MPTs
---
# MPTokenIssuanceDestroy
[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceDestroy.cpp "Source")
_(Requires the [MPToken amendment][] {% not-enabled /%})_
@@ -18,14 +19,14 @@ If this operation succeeds, the corresponding `MPTokenIssuance` is removed and t
```json
{
"TransactionType": "MPTokenIssuanceDestroy",
"Fee": 10,
"Fee": "10",
"MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000"
}
```
## MPTokenIssuanceDestroy Fields
<!-- ## MPTokenIssuanceDestroy Fields -->
<!-- {% include '_snippets/tx-fields-intro.md' %} -->
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
| Field | JSON Type | [Internal Type][] | Description |
|:--------------------|:--------------------|:------------------|:-------------------|

View File

@@ -6,6 +6,7 @@ labels:
- Multi-purpose Tokens, MPTs
---
# MPTokenIssuanceSet
[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceSet.cpp "Source")
_(Requires the [MPToken amendment][] {% not-enabled /%})_
@@ -16,13 +17,13 @@ Use this transaction to update a mutable property for a Multi-purpose Token.
```json
{
"TransactionType": "MPTokenIssuanceSet",
"Fee": 10,
"Fee": "10",
"MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000",
"Flags": 1
}
```
## MPTokenIssuanceSet Fields
<!-- ## MPTokenIssuanceSet Fields -->
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}