From 3c966592ce4bc77a274b376f50ceb714f8b87234 Mon Sep 17 00:00:00 2001 From: Amarantha Kulkarni Date: Fri, 20 Dec 2024 13:38:02 -0800 Subject: [PATCH] Apply suggestions from code review Incorporating suggestions from tequdev and akulkarni Co-authored-by: tequ --- .../protocol/transactions/types/mptokenauthorize.md | 2 +- .../transactions/types/mptokenissuancecreate.md | 13 ++++++------- .../transactions/types/mptokenissuancedestroy.md | 7 ++++--- .../transactions/types/mptokenissuanceset.md | 5 +++-- 4 files changed, 14 insertions(+), 13 deletions(-) diff --git a/docs/references/protocol/transactions/types/mptokenauthorize.md b/docs/references/protocol/transactions/types/mptokenauthorize.md index b190e7ab4f..142def04cf 100644 --- a/docs/references/protocol/transactions/types/mptokenauthorize.md +++ b/docs/references/protocol/transactions/types/mptokenauthorize.md @@ -15,7 +15,7 @@ This transaction enables an account to hold an amount of a particular MPT issuan If the issuer has set `lsfMPTRequireAuth` (allow-listing) on the `MPTokenIssuance`, the issuer must submit an `MPTokenAuthorize` transaction as well in order to give permission to the holder. If `lsfMPTRequireAuth` is not set and the issuer attempts to submit this transaction, it will fail. -## MPTokenAuthorize Fields + {% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%} diff --git a/docs/references/protocol/transactions/types/mptokenissuancecreate.md b/docs/references/protocol/transactions/types/mptokenissuancecreate.md index 2b53bafa02..3ea4835ada 100644 --- a/docs/references/protocol/transactions/types/mptokenissuancecreate.md +++ b/docs/references/protocol/transactions/types/mptokenissuancecreate.md @@ -11,7 +11,7 @@ labels: _(Requires the [MPToken amendment][] {% not-enabled /%})_ -The `MPTokenIssuanceCreate` transaction creates an MPTokenIssuance object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags). +The `MPTokenIssuanceCreate` transaction creates an [MPTokenIssuance](../../data-types/mptokenissuance.md) object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags). If the transaction is successful, the newly created token is owned by the account (the creator account) that executed the transaction. @@ -22,22 +22,21 @@ Whenever your query returns an `MPTokenIssuance` transaction response, there wil This example assumes that the issuer of the token is the signer of the transaction. ```json -Example MPTokenIssuanceCreate transaction { "TransactionType": "MPTokenIssuanceCreate", "Account": "rajgkBmMxmz161r8bWYH7CQAFZP5bA9oSG", - "AssetScale": "2", + "AssetScale": 2, "TransferFee": 314, "MaximumAmount": "50000000", "Flags": 83659, "MPTokenMetadata": "FOO", - "Fee": 10 + "Fee": "10" } ``` -## MPTokenIssuanceCreate Fields + - +{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%} | Field | JSON Type | [Internal Type][] | Description | |:----------------|:--------------------|:------------------|:-------------------| @@ -50,7 +49,7 @@ Example MPTokenIssuanceCreate transaction ## MPTokenIssuanceCreate Flags -Transactions of the MPTokenIssuanceCreate type support additional values in the `Flags` field , as follows: +Transactions of the MPTokenIssuanceCreate type support additional values in the [`Flags` field](../common-fields.md#flags-field), as follows: | Flag Name | Hex Value | Decimal Value | Description | |:-------------------|:-------------|:--------------|:------------------------------| diff --git a/docs/references/protocol/transactions/types/mptokenissuancedestroy.md b/docs/references/protocol/transactions/types/mptokenissuancedestroy.md index 27c623bba0..cb260f55c6 100644 --- a/docs/references/protocol/transactions/types/mptokenissuancedestroy.md +++ b/docs/references/protocol/transactions/types/mptokenissuancedestroy.md @@ -6,6 +6,7 @@ labels: - Multi-purpose Tokens, MPTs --- # MPTokenIssuanceDestroy +[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceDestroy.cpp "Source") _(Requires the [MPToken amendment][] {% not-enabled /%})_ @@ -18,14 +19,14 @@ If this operation succeeds, the corresponding `MPTokenIssuance` is removed and t ```json { "TransactionType": "MPTokenIssuanceDestroy", - "Fee": 10, + "Fee": "10", "MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000" } ``` -## MPTokenIssuanceDestroy Fields + - +{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%} | Field | JSON Type | [Internal Type][] | Description | |:--------------------|:--------------------|:------------------|:-------------------| diff --git a/docs/references/protocol/transactions/types/mptokenissuanceset.md b/docs/references/protocol/transactions/types/mptokenissuanceset.md index cfe95bfc66..44d3daf446 100644 --- a/docs/references/protocol/transactions/types/mptokenissuanceset.md +++ b/docs/references/protocol/transactions/types/mptokenissuanceset.md @@ -6,6 +6,7 @@ labels: - Multi-purpose Tokens, MPTs --- # MPTokenIssuanceSet +[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceSet.cpp "Source") _(Requires the [MPToken amendment][] {% not-enabled /%})_ @@ -16,13 +17,13 @@ Use this transaction to update a mutable property for a Multi-purpose Token. ```json { "TransactionType": "MPTokenIssuanceSet", - "Fee": 10, + "Fee": "10", "MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000", "Flags": 1 } ``` -## MPTokenIssuanceSet Fields + {% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}