mirror of
https://github.com/Xahau/xahaud.git
synced 2025-11-20 02:25:53 +00:00
This fixes a case where a peer can desync under a certain timing circumstance--if it reaches a certain point in consensus before it receives proposals. This was noticed under high transaction volumes. Namely, when we arrive at the point of deciding whether consensus is reached after minimum establish phase duration but before having received any proposals. This could be caused by finishing the previous round slightly faster and/or having some delay in receiving proposals. Existing behavior arrives at consensus immediately after the minimum establish duration with no proposals. This causes us to desync because we then close a non-validated ledger. The change in this PR causes us to wait for a configured threshold before making the decision to arrive at consensus with no proposals. This allows validators to catch up and for brief delays in receiving proposals to be absorbed. There should be no drawback since, with no proposals coming in, we needn't be in a huge rush to jump ahead.
190 lines
6.5 KiB
C++
190 lines
6.5 KiB
C++
//------------------------------------------------------------------------------
|
|
/*
|
|
This file is part of rippled: https://github.com/ripple/rippled
|
|
Copyright (c) 2012, 2013 Ripple Labs Inc.
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
//==============================================================================
|
|
|
|
#include <ripple/basics/Log.h>
|
|
#include <ripple/consensus/Consensus.h>
|
|
|
|
namespace ripple {
|
|
|
|
bool
|
|
shouldCloseLedger(
|
|
bool anyTransactions,
|
|
std::size_t prevProposers,
|
|
std::size_t proposersClosed,
|
|
std::size_t proposersValidated,
|
|
std::chrono::milliseconds prevRoundTime,
|
|
std::chrono::milliseconds
|
|
timeSincePrevClose, // Time since last ledger's close time
|
|
std::chrono::milliseconds openTime, // Time waiting to close this ledger
|
|
std::chrono::milliseconds idleInterval,
|
|
ConsensusParms const& parms,
|
|
beast::Journal j)
|
|
{
|
|
using namespace std::chrono_literals;
|
|
if ((prevRoundTime < -1s) || (prevRoundTime > 10min) ||
|
|
(timeSincePrevClose > 10min))
|
|
{
|
|
// These are unexpected cases, we just close the ledger
|
|
JLOG(j.warn()) << "shouldCloseLedger Trans="
|
|
<< (anyTransactions ? "yes" : "no")
|
|
<< " Prop: " << prevProposers << "/" << proposersClosed
|
|
<< " Secs: " << timeSincePrevClose.count()
|
|
<< " (last: " << prevRoundTime.count() << ")";
|
|
return true;
|
|
}
|
|
|
|
if ((proposersClosed + proposersValidated) > (prevProposers / 2))
|
|
{
|
|
// If more than half of the network has closed, we close
|
|
JLOG(j.trace()) << "Others have closed";
|
|
return true;
|
|
}
|
|
|
|
if (!anyTransactions)
|
|
{
|
|
// Only close at the end of the idle interval
|
|
return timeSincePrevClose >= idleInterval; // normal idle
|
|
}
|
|
|
|
// Preserve minimum ledger open time
|
|
if (openTime < parms.ledgerMIN_CLOSE)
|
|
{
|
|
JLOG(j.debug()) << "Must wait minimum time before closing";
|
|
return false;
|
|
}
|
|
|
|
// Don't let this ledger close more than twice as fast as the previous
|
|
// ledger reached consensus so that slower validators can slow down
|
|
// the network
|
|
if (openTime < (prevRoundTime / 2))
|
|
{
|
|
JLOG(j.debug()) << "Ledger has not been open long enough";
|
|
return false;
|
|
}
|
|
|
|
// Close the ledger
|
|
return true;
|
|
}
|
|
|
|
bool
|
|
checkConsensusReached(
|
|
std::size_t agreeing,
|
|
std::size_t total,
|
|
bool count_self,
|
|
std::size_t minConsensusPct,
|
|
bool reachedMax)
|
|
{
|
|
// If we are alone for too long, we have consensus.
|
|
// Delaying consensus like this avoids a circumstance where a peer
|
|
// gets ahead of proposers insofar as it has not received any proposals.
|
|
// This could happen if there's a slowdown in receiving proposals. Reaching
|
|
// consensus prematurely in this way means that the peer will likely desync.
|
|
// The check for reachedMax should allow plenty of time for proposals to
|
|
// arrive, and there should be no downside. If a peer is truly not
|
|
// receiving any proposals, then there should be no hurry. There's
|
|
// really nowhere to go.
|
|
if (total == 0)
|
|
{
|
|
if (reachedMax)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
if (count_self)
|
|
{
|
|
++agreeing;
|
|
++total;
|
|
}
|
|
|
|
std::size_t currentPercentage = (agreeing * 100) / total;
|
|
|
|
return currentPercentage >= minConsensusPct;
|
|
}
|
|
|
|
ConsensusState
|
|
checkConsensus(
|
|
std::size_t prevProposers,
|
|
std::size_t currentProposers,
|
|
std::size_t currentAgree,
|
|
std::size_t currentFinished,
|
|
std::chrono::milliseconds previousAgreeTime,
|
|
std::chrono::milliseconds currentAgreeTime,
|
|
ConsensusParms const& parms,
|
|
bool proposing,
|
|
beast::Journal j)
|
|
{
|
|
JLOG(j.trace()) << "checkConsensus: prop=" << currentProposers << "/"
|
|
<< prevProposers << " agree=" << currentAgree
|
|
<< " validated=" << currentFinished
|
|
<< " time=" << currentAgreeTime.count() << "/"
|
|
<< previousAgreeTime.count() << " proposing? " << proposing
|
|
<< " minimum duration to reach consensus: "
|
|
<< parms.ledgerMIN_CONSENSUS.count() << "ms"
|
|
<< " max consensus time "
|
|
<< parms.ledgerMAX_CONSENSUS.count() << "s"
|
|
<< " minimum consensus percentage: "
|
|
<< parms.minCONSENSUS_PCT;
|
|
|
|
if (currentAgreeTime <= parms.ledgerMIN_CONSENSUS)
|
|
return ConsensusState::No;
|
|
|
|
if (currentProposers < (prevProposers * 3 / 4))
|
|
{
|
|
// Less than 3/4 of the last ledger's proposers are present; don't
|
|
// rush: we may need more time.
|
|
if (currentAgreeTime < (previousAgreeTime + parms.ledgerMIN_CONSENSUS))
|
|
{
|
|
JLOG(j.trace()) << "too fast, not enough proposers";
|
|
return ConsensusState::No;
|
|
}
|
|
}
|
|
|
|
// Have we, together with the nodes on our UNL list, reached the threshold
|
|
// to declare consensus?
|
|
if (checkConsensusReached(
|
|
currentAgree,
|
|
currentProposers,
|
|
proposing,
|
|
parms.minCONSENSUS_PCT,
|
|
currentAgreeTime > parms.ledgerMAX_CONSENSUS))
|
|
{
|
|
JLOG(j.debug()) << "normal consensus";
|
|
return ConsensusState::Yes;
|
|
}
|
|
|
|
// Have sufficient nodes on our UNL list moved on and reached the threshold
|
|
// to declare consensus?
|
|
if (checkConsensusReached(
|
|
currentFinished,
|
|
currentProposers,
|
|
false,
|
|
parms.minCONSENSUS_PCT,
|
|
currentAgreeTime > parms.ledgerMAX_CONSENSUS))
|
|
{
|
|
JLOG(j.warn()) << "We see no consensus, but 80% of nodes have moved on";
|
|
return ConsensusState::MovedOn;
|
|
}
|
|
|
|
// no consensus yet
|
|
JLOG(j.trace()) << "no consensus";
|
|
return ConsensusState::No;
|
|
}
|
|
|
|
} // namespace ripple
|