put release builds into a candidate folder to prevent auto-update scripts running before smoke tests

include/xrpl/protocol/detail/features.macro

@@ -34,7 +34,6 @@
 // If you add an amendment here, then do not forget to increment `numFeatures`
 // in include/xrpl/protocol/Feature.h.
 
-XRPL_FIX    (HookNameValidation,         Supported::yes, VoteBehavior::DefaultYes)
 XRPL_FIX    (HookMap,                    Supported::yes, VoteBehavior::DefaultYes)
 XRPL_FIX    (GuardDepth32,               Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(NamedHooks,                 Supported::yes, VoteBehavior::DefaultNo)

src/test/app/SetHook_test.cpp

@@ -2002,35 +2002,11 @@ public:
             BEAST_EXPECT(!env.meta()->isFieldPresent(sfHookEmissions));
         }
 
-        // Call named hook with the wrong hook name (size == 0)
-        for (auto const fix : {true, false})
-        {
-            auto f = features - fixHookNameValidation;
-            if (fix)
-                f = f | fixHookNameValidation;
-            Env env{*this, f};
-
-            env.fund(XRP(10000), alice);
-            // execute both named and non-named hooks
-
-            auto jv = invoke::invoke(alice);
-            jv[jss::HookName] = "";
-
-            auto const expected = fix ? ter(temMALFORMED) : ter(tesSUCCESS);
-            env(jv,
-                M("Call named hook with the wrong hook name (size == 0)"),
-                HSFEE,
-                ter(expected));
-            env.close();
-        }
-
-        // Call named hook with the wrong hook name (size > 0)
+        // Call named hook with the wrong hook name
         {
             auto jv = invoke::invoke(alice);
             jv[jss::HookName] = "41424345";
-            env(jv,
-                M("Call named hook with the wrong hook name (size > 0)"),
-                HSFEE);
+            env(jv, M("Call named hook with the wrong hook name"), HSFEE);
             env.close();
             // execute only non-named hook
             BEAST_EXPECT(!env.meta()->isFieldPresent(sfHookEmissions));

src/xrpld/app/tx/detail/Transactor.cpp

@@ -155,11 +155,7 @@ preflight1(PreflightContext const& ctx)
             !ctx.rules.enabled(featureNamedHooks))
             return temMALFORMED;
 
-        auto const& name = ctx.tx.getFieldVL(sfHookName);
-
-        if (name.size() == 0 && ctx.rules.enabled(fixHookNameValidation))
-            return temMALFORMED;
-        if (!SetHook::validateHookName(name, ctx.j))
+        if (!SetHook::validateHookName(ctx.tx.getFieldVL(sfHookName), ctx.j))
             return temMALFORMED;
     }