Merge branch 'dev' into fix-etxn-fee-base-view

HookAPI::etxn_fee_base computed the emitted txn's minimum fee against
the node-local open ledger. HookAPI::emit uses that value for its
minimum-fee check, so a hook definition (e.g. HookCallbackFee) present in
the ledger being built but not yet in a node's open ledger, or vice
versa, could make emit() succeed on one node and fail on another. Under
fix20261001 the fee is computed against the view being applied.

.github/workflows/build-in-docker.yml

@@ -91,11 +91,5 @@ jobs:
       - name: Cleanup workspace
         run: |
           CHECKOUT_PATH="${{ needs.checkout.outputs.checkout_path }}"
-          # A run cancelled before checkout has no path; an empty one would
-          # make the rm below delete every run's checkout on the runner.
-          if [[ -z "${CHECKOUT_PATH}" ]]; then
-            echo "No checkout path (cancelled before checkout); nothing to clean"
-            exit 0
-          fi
           echo "Cleaning workspace for ${CHECKOUT_PATH}"
           rm -rf "${{ github.workspace }}/${CHECKOUT_PATH}"

include/xrpl/protocol/detail/features.macro

@@ -36,7 +36,7 @@
 
 XRPL_FIX    (20261001,                   Supported::yes, VoteBehavior::DefaultYes)
 XRPL_FEATURE(HookOnV2_1,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(OnChainManifests,           Supported::no, VoteBehavior::DefaultNo)
+XRPL_FEATURE(OnChainManifests,           Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FIX    (HookMap,                    Supported::yes, VoteBehavior::DefaultYes)
 XRPL_FIX    (GuardDepth32,               Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(NamedHooks,                 Supported::yes, VoteBehavior::DefaultNo)

src/xrpld/app/tx/detail/Transactor.cpp

@@ -2050,16 +2050,6 @@ Transactor::operator()()
     if (auto stream = j_.trace())
         stream << "preclaim result: " << transToken(result);
 
-    return finishApply(result, hooksEnabled, aawMap, tsh);
-}
-
-ApplyResult
-Transactor::finishApply(
-    TER result,
-    bool hooksEnabled,
-    std::map<AccountID, std::set<uint256>>& aawMap,
-    std::vector<std::pair<AccountID, bool>>& tsh)
-{
     bool applied = isTesSuccess(result);
 
     auto fee = ctx_.tx.getFieldAmount(sfFee).xrp();

src/xrpld/app/tx/detail/Transactor.h

@@ -228,15 +228,6 @@ protected:
                              // deduced until after apply i.e. pathing
                              // participants, crossed offers
 
-    // The post-apply pipeline of operator(): tec handling (reset),
-    // invariants, balance rewards, weak hooks and commit.
-    ApplyResult
-    finishApply(
-        TER result,
-        bool hooksEnabled,
-        std::map<AccountID, std::set<uint256>>& aawMap,
-        std::vector<std::pair<AccountID, bool>>& tsh);
-
     ///////////////////////////////////////////////////
 
     TER