Merge branch 'dev' into switch-statement-700

fix: resolve switch fall-through in util_keylet unimplemented cases (#700 )
Merge fixAMMClawbackRounding amendment into featureAMMClawback amendment
2026-04-29 15:37:46 +00:00 · 2026-04-29 10:35:43 +10:00 · 2026-03-04 11:26:38 +07:00 · 2026-02-25 19:07:45 +10:00 · 2026-02-25 19:07:45 +10:00 · 2026-02-25 16:20:43 +10:00
1 changed files with 14 additions and 17 deletions
--- a/src/xrpld/app/hook/detail/applyHook.cpp
+++ b/src/xrpld/app/hook/detail/applyHook.cpp
@@ -2730,26 +2730,23 @@ DEFINE_HOOK_FUNCTION(

                return serialize_keylet(kl, memory, write_ptr, write_len);
            }
+            // These keylet types are not yet implemented. Their
+            // corresponding amendments are not yet supported on the
+            // network. Each case needs a full implementation (see
+            // above cases for reference) before its amendment can be
+            // enabled.
+            // featureXChainBridge
            case keylet_code::BRIDGE:
            case keylet_code::XCHAIN_OWNED_CLAIM_ID:
-            case keylet_code::XCHAIN_OWNED_CREATE_ACCOUNT_CLAIM_ID: {
-                if (!applyCtx.view().rules().enabled(featureXChainBridge))
-                    return INVALID_ARGUMENT;
-            }
+            case keylet_code::XCHAIN_OWNED_CREATE_ACCOUNT_CLAIM_ID:
+            // featureMPTokensV1
            case keylet_code::MPTOKEN_ISSUANCE:
-            case keylet_code::MPTOKEN: {
-                if (!applyCtx.view().rules().enabled(featureMPTokensV1))
-                    return INVALID_ARGUMENT;
-            }
-            case keylet_code::CREDENTIAL: {
-                if (!applyCtx.view().rules().enabled(featureCredentials))
-                    return INVALID_ARGUMENT;
-            }
-            case keylet_code::PERMISSIONED_DOMAIN: {
-                if (!applyCtx.view().rules().enabled(
-                        featurePermissionedDomains))
-                    return INVALID_ARGUMENT;
-            }
+            case keylet_code::MPTOKEN:
+            // featureCredentials
+            case keylet_code::CREDENTIAL:
+            // featurePermissionedDomains
+            case keylet_code::PERMISSIONED_DOMAIN:
+                return INVALID_ARGUMENT;
        }
    }
    catch (std::exception& e)
Author	SHA1	Message	Date
Richard Holland	b350df0eda	Merge branch 'dev' into switch-statement-700	2026-04-29 10:35:43 +10:00
Nicholas Dudfield	b960026701	fix: resolve switch fall-through in util_keylet unimplemented cases (#700 )	2026-03-04 11:26:38 +07:00
tequ	8cfee6c8a3	Merge fixAMMClawbackRounding amendment into featureAMMClawback amendment	2026-02-25 19:07:45 +10:00
yinyiqian1	8673599d2b	fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513 ) Due to rounding, the LPTokenBalance of the last LP might not match the LP's trustline balance. This was fixed for `AMMWithdraw` in `fixAMMv1_1` by adjusting the LPTokenBalance to be the same as the trustline balance. Since `AMMClawback` is also performing a withdrawal, we need to adjust LPTokenBalance as well in `AMMClawback.` This change includes: 1. Refactored `verifyAndAdjustLPTokenBalance` function in `AMMUtils`, which both`AMMWithdraw` and `AMMClawback` call to adjust LPTokenBalance. 2. Added the unit test `testLastHolderLPTokenBalance` to test the scenario. 3. Modify the existing unit tests for `fixAMMClawbackRounding`.	2026-02-25 19:07:45 +10:00
tequ	ec65e622aa	Merge fixAMMv1_3 amendment into featureAMM amendment	2026-02-25 16:20:43 +10:00
Gregory Tsipenyuk	65837f49e1	fix: Add AMMv1_3 amendment (#5203 ) * Add AMM bid/create/deposit/swap/withdraw/vote invariants: - Deposit, Withdrawal invariants: `sqrt(asset1Balance * asset2Balance) >= LPTokens`. - Bid: `sqrt(asset1Balance * asset2Balance) > LPTokens` and the pool balances don't change. - Create: `sqrt(asset1Balance * assetBalance2) == LPTokens`. - Swap: `asset1BalanceAfter * asset2BalanceAfter >= asset1BalanceBefore * asset2BalanceBefore` and `LPTokens` don't change. - Vote: `LPTokens` and pool balances don't change. - All AMM and swap transactions: amounts and tokens are greater than zero, except on withdrawal if all tokens are withdrawn. * Add AMM deposit and withdraw rounding to ensure AMM invariant: - On deposit, tokens out are rounded downward and deposit amount is rounded upward. - On withdrawal, tokens in are rounded upward and withdrawal amount is rounded downward. * Add Order Book Offer invariant to verify consumed amounts. Consumed amounts are less than the offer. * Fix Bid validation. `AuthAccount` can't have duplicate accounts or the submitter account.	2026-02-25 16:20:43 +10:00
RichardAH	e5b21f026e	Merge pull request #692 from Xahau/sync-2.4.0-rebased Sync: Ripple(d) 2.4.0	2026-02-24 16:07:09 +10:00