Scott Schurr
3c4731a676
fixReducedOffersV1: prevent offers from blocking order books: (#4512 )
...
Curtail the occurrence of order books that are blocked by reduced offers
with the implementation of the fixReducedOffersV1 amendment.
This commit identifies three ways in which offers can be reduced:
1. A new offer can be partially crossed by existing offers, so the new
offer is reduced when placed in the ledger.
2. An in-ledger offer can be partially crossed by a new offer in a
transaction. So the in-ledger offer is reduced by the new offer.
3. An in-ledger offer may be under-funded. In this case the in-ledger
offer is scaled down to match the available funds.
Reduced offers can block order books if the effective quality of the
reduced offer is worse than the quality of the original offer (from the
perspective of the taker). It turns out that, for small values, the
quality of the reduced offer can be significantly affected by the
rounding mode used during scaling computations.
This commit adjusts some rounding modes so that the quality of a reduced
offer is always at least as good (from the taker's perspective) as the
original offer.
The amendment is titled fixReducedOffersV1 because additional ways of
producing reduced offers may come to light. Therefore, there may be a
future need for a V2 amendment.
2025-06-15 23:06:42 +09:00
Ed Hennis
995e70c2b0
Enable the Beta RPC API (v2) for all unit tests: ( #4573 )
...
* Enable api_version 2, which is currently in beta. It is expected to be
marked stable by the next stable release.
* This does not change any defaults.
* The only existing tests changed were one that set the same flag, which
was now redundant, and a couple that tested versioning explicitly.
2025-06-15 23:05:35 +09:00
Denis Angell
a5ea86fdfc
Add Conan Building For Development ( #432 )
2025-05-14 14:00:20 +10:00
RichardAH
615f56570a
Sus pat ( #507 )
2025-05-01 17:23:56 +10:00
RichardAH
5e005cd6ee
remove false positives from sus pat finder ( #506 )
2025-05-01 09:54:41 +10:00
Denis Angell
80a7197590
fix warnings ( #505 )
2025-04-30 11:51:58 +02:00
tequ
7b581443d1
Suppress build warning introduced in Catalogue ( #499 )
2025-04-29 08:25:55 +10:00
tequ
5400f43359
Supress logs for Catalogue_test, Import_test ( #495 )
2025-04-24 17:46:09 +10:00
Denis Angell
8cf7d485ab
fix: ledger_index ( #498 )
2025-04-24 16:45:01 +10:00
tequ
372f25d09b
Remove #ifndef DEBUG guards and exception handling wrappers ( #496 )
2025-04-24 16:38:14 +10:00
Denis Angell
401395a204
patch remarks ( #497 )
2025-04-24 16:36:57 +10:00
tequ
4221dcf568
Add tests for SetRemarks ( #491 )
2025-04-18 09:34:44 +10:00
tequ
989532702d
Update clang-format workflow ( #490 )
2025-04-17 16:16:59 +10:00
RichardAH
f9cd2e0d21
Remarks amendment ( #301 )
...
Co-authored-by: Denis Angell <dangell@transia.co >
2025-04-16 08:42:04 +10:00
tequ
59e334c099
fixRewardClaimFlags ( #487 )
2025-04-15 20:08:19 +10:00
tequ
9018596532
HookCanEmit ( #392 )
2025-04-15 13:32:35 +10:00
Niq Dudfield
b827f0170d
feat(catalogue): add cli commands and fix file_size ( #486 )
...
* feat(catalogue): add cli commands and fix file_size
* feat(catalogue): add cli commands and fix file_size
* feat(catalogue): fix tests
* feat(catalogue): fix tests
* feat(catalogue): use formatBytesIEC
* feat: add file_size_estimated
* feat: add file_size_estimated
* feat: add file_size_estimated
2025-04-15 08:50:15 +10:00
tequ
e4b7e8f0f2
Update sfcodes script ( #479 )
2025-04-10 09:44:31 +10:00
tequ
1485078d91
Update CHooks build script ( #465 )
2025-04-09 20:22:34 +10:00
tequ
6625d2be92
Add xpop_slot test ( #470 )
2025-04-09 20:20:23 +10:00
tequ
2fb5c92140
feat: Run unittests in parallel with Github Actions ( #483 )
...
Implement parallel execution for unit tests using Github Actions to improve CI pipeline efficiency and reduce build times.
2025-04-04 19:32:47 +02:00
Niq Dudfield
c4b5ae3787
Fix missing includes in Catalogue.cpp for non-unity builds ( #485 )
2025-04-04 12:53:45 +10:00
Niq Dudfield
d546d761ce
Fix using using Status with rpcError ( #484 )
2025-04-01 21:00:13 +10:00
RichardAH
e84a36867b
Catalogue ( #443 )
2025-04-01 16:47:48 +10:00
Niq Dudfield
0b675465b4
Fix ServerDefinitions_test regression intro in #475 ( #477 )
2025-03-19 12:32:27 +10:00
Niq Dudfield
d088ad61a9
Prevent dangling reference in getHash() ( #475 )
...
Replace temporary uint256 with static variable when returning fallback hash
to avoid returning a const reference to a local temporary object.
2025-03-18 18:37:18 +10:00
Niq Dudfield
ef77b02d7f
CI Release Builder ( #455 )
2025-03-11 13:19:28 +01:00
RichardAH
7385828983
Touch Amendment ( #294 )
2025-03-06 08:25:42 +01:00
Niq Dudfield
88b01514c1
fix: remove negative rate test failing on MacOS ( #452 )
2025-03-03 13:12:13 +01:00
Denis Angell
aeece15096
[fix] github runner ( #451 )
...
Co-authored-by: Niq Dudfield <ndudfield@gmail.com >
2025-03-03 09:55:51 +01:00
tequ
89cacb1258
Enhance shell script error handling and debugging on GHA ( #447 )
2025-02-24 10:33:21 +01:00
tequ
8ccff44e8c
Fix Error handling on build action ( #412 )
2025-02-24 18:16:21 +10:00
tequ
420240a2ab
Fixed not to use a large fixed range in the magic_enum. ( #436 )
2025-02-24 17:46:42 +10:00
Richard Holland
230873f196
debug gh builds
2025-02-06 15:21:37 +11:00
Wietse Wind
1fb1a99ea2
Update build-in-docker.yml
2025-02-05 08:23:49 +01:00
Richard Holland
e0b63ac70e
Revert "debug account tx tests under release builder"
...
This reverts commit da8df63be3#429 )"
This reverts commit 317bd4bc6e
2025-02-05 14:59:33 +11:00
Richard Holland
da8df63be3
debug account tx tests under release builder
2025-02-04 17:02:17 +11:00
RichardAH
317bd4bc6e
add strict filtering to account_tx api ( #429 )
2025-02-03 17:56:08 +10:00
RichardAH
2fd465bb3f
fix20250131 ( #428 )
...
Co-authored-by: Denis Angell <dangell@transia.co >
2025-02-03 10:33:19 +10:00
Wietse Wind
fa71bda29c
Artifact v4 continue on error
2025-02-01 08:58:13 +01:00
Wietse Wind
412593d7bc
Update artifact
2025-02-01 08:57:48 +01:00
Wietse Wind
12d8342c34
Update artifact
2025-02-01 08:57:25 +01:00
tequ
d17f7151ab
Fix HookResult(ExitType) when accept() is not called ( #415 )
2025-01-22 13:33:59 +10:00
tequ
4466175231
Update boost link for build-full.sh ( #421 )
2025-01-22 08:38:12 +10:00
tequ
621ca9c865
Add space to trace_float log ( #424 )
2025-01-22 08:34:33 +10:00
tequ
85a752235a
add URITokenIssuer to account_flags for account_info ( #404 )
2024-12-16 16:10:01 +10:00
RichardAH
d878fd4a6e
allow multiple datagram monitor endpoints ( #408 )
2024-12-14 08:44:40 +10:00
Richard Holland
532a471a35
fixReduceImport ( #398 )
...
Co-authored-by: Denis Angell <dangell@transia.co >
2024-12-11 13:29:37 +11:00
RichardAH
e9468d8b4a
Datagram monitor ( #400 )
...
Co-authored-by: Denis Angell <dangell@transia.co >
2024-12-11 13:29:30 +11:00
Denis Angell
9d54da3880
Fix: failing assert ( #397 )
2024-12-11 13:08:50 +11:00
