ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-06-03 16:56:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

consensus: reduce entropy-set proposal fanout

Browse Source 
Keep entropy-set recovery path but elect a deterministic single broadcaster (lowest NodeID among tx-converged participants) instead of every proposer broadcasting entropySetHash.

This lowers steady-state proposal chatter while preserving liveness for lagging peers that need entropy-set fetch/merge.
This commit is contained in:
Nicholas Dudfield
2026-03-03 07:42:27 +07:00
parent 34c0f17b6b
commit fc23fa8535
1 changed files with 30 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/xrpld/consensus/Consensus.h
View File

@@ -1853,22 +1853,38 @@ Consensus<Adaptor>::phaseEstablish(
asCloseTime(result_->position.closeTime()),
now_);
// Publish entropySetHash before accepting so peers (and
// observers recovering from dropped reveal proposals) can
// fetch/merge entropy sets in ConvergingReveal.
// Publish entropySetHash before accepting so lagging peers
// can fetch/merge reveal sets in ConvergingReveal.
//
// Tradeoff:
// - Adds one extra proposal broadcast in rounds that make
// it to ConvergingReveal (often a 4th proposal in quiet
// rounds: seq0, commitSet, reveal, entropySet).
// - In return, lagging nodes can deterministically recover
// reveal sets instead of building a divergent entropy
// transaction and falling into sync/jump loops.
//
// We intentionally bias toward consensus safety/liveness
// under packet loss or drop-injection, accepting small
// bandwidth/CPU overhead.
// Optimization:
// Avoid every proposer sending this final position update.
// Elect one deterministic broadcaster per tx-converged
// group (lowest NodeID among self + tx-converged peers).
// This keeps the recovery path while reducing steady-state
// proposal traffic in quiet rounds.
bool publishEntropySet = true;
if (mode_.get() == ConsensusMode::proposing)
{
auto const ourPos = result_->position.position();
auto const selfNode = result_->position.nodeID();
auto electedNode = selfNode;
for (auto const& [nodeId, peerPos] : currPeerPositions_)
{
if (!(peerPos.proposal().position() == ourPos))
continue;
if (nodeId < electedNode)
electedNode = nodeId;
}
publishEntropySet = (selfNode == electedNode);
JLOG(j_.debug())
<< "RNG: entropySet broadcaster election self="
<< selfNode << " elected=" << electedNode
<< " publish="
<< (publishEntropySet ? "yes" : "no");
}
if (mode_.get() == ConsensusMode::proposing &&
publishEntropySet)
adaptor_.propose(result_->position);
JLOG(j_.debug()) << "RNG: built entropySet";