ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-06-04 09:16:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(cov): drop dead BASE_DIRECTORY arg + revert .disabled file edit

Browse Source 
- CodeCoverageLLVM.cmake: BASE_DIRECTORY was parsed but never used
  (no analog to gcovr's -r in the llvm-cov commands we emit). dead arg.
- xahau-ga-macos.yml.disabled: revert the conan_deps_cxxflags addition.
  the file is disabled so the edit was bit-rotting in unreachable code.
  whoever revives the macOS workflow can wire up the field then.
This commit is contained in:
Nicholas Dudfield
2026-05-05 09:25:30 +07:00
parent fe162a99a9
commit f8a30c528d
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/xahau-ga-macos.yml.disabled vendored
View File

@@ -107,9 +107,6 @@ jobs:
compiler: apple-clang compiler: apple-clang
compiler_version: ${{ steps.detect-compiler.outputs.compiler_version }} compiler_version: ${{ steps.detect-compiler.outputs.compiler_version }}
stdlib: libcxx stdlib: libcxx
# grpc 1.50.1 trips this on newer Apple Clang (clang-19+ frontend).
# Drop when grpc is bumped past the fix.
conan_deps_cxxflags: '["-Wno-missing-template-arg-list-after-template-kw"]'
- name: Build - name: Build
uses: ./.github/actions/xahau-ga-build uses: ./.github/actions/xahau-ga-build

2
cmake/CodeCoverageLLVM.cmake
View File

@@ -59,7 +59,7 @@ function(_find_llvm_cov_tools)
endfunction() endfunction()
function(setup_target_for_coverage_llvm) function(setup_target_for_coverage_llvm)
set(oneValueArgs NAME FORMAT BASE_DIRECTORY) set(oneValueArgs NAME FORMAT)
set(multiValueArgs EXCLUDE EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES) set(multiValueArgs EXCLUDE EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES)
cmake_parse_arguments(Cov "" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) cmake_parse_arguments(Cov "" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})