From f8a30c528d936d5a91618315a89d9f1f3d5e23f1 Mon Sep 17 00:00:00 2001 From: Nicholas Dudfield Date: Tue, 5 May 2026 09:25:30 +0700 Subject: [PATCH] chore(cov): drop dead BASE_DIRECTORY arg + revert .disabled file edit - CodeCoverageLLVM.cmake: BASE_DIRECTORY was parsed but never used (no analog to gcovr's -r in the llvm-cov commands we emit). dead arg. - xahau-ga-macos.yml.disabled: revert the conan_deps_cxxflags addition. the file is disabled so the edit was bit-rotting in unreachable code. whoever revives the macOS workflow can wire up the field then. --- .github/workflows/xahau-ga-macos.yml.disabled | 3 --- cmake/CodeCoverageLLVM.cmake | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/xahau-ga-macos.yml.disabled b/.github/workflows/xahau-ga-macos.yml.disabled index 4748abded..65d547093 100644 --- a/.github/workflows/xahau-ga-macos.yml.disabled +++ b/.github/workflows/xahau-ga-macos.yml.disabled @@ -107,9 +107,6 @@ jobs: compiler: apple-clang compiler_version: ${{ steps.detect-compiler.outputs.compiler_version }} stdlib: libcxx - # grpc 1.50.1 trips this on newer Apple Clang (clang-19+ frontend). - # Drop when grpc is bumped past the fix. - conan_deps_cxxflags: '["-Wno-missing-template-arg-list-after-template-kw"]' - name: Build uses: ./.github/actions/xahau-ga-build diff --git a/cmake/CodeCoverageLLVM.cmake b/cmake/CodeCoverageLLVM.cmake index f986ec625..b67855999 100644 --- a/cmake/CodeCoverageLLVM.cmake +++ b/cmake/CodeCoverageLLVM.cmake @@ -59,7 +59,7 @@ function(_find_llvm_cov_tools) endfunction() function(setup_target_for_coverage_llvm) - set(oneValueArgs NAME FORMAT BASE_DIRECTORY) + set(oneValueArgs NAME FORMAT) set(multiValueArgs EXCLUDE EXECUTABLE EXECUTABLE_ARGS DEPENDENCIES) cmake_parse_arguments(Cov "" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})