ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-06-03 16:56:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix js otxn_id hook_account bugs

Browse Source
This commit is contained in:
Richard Holland
2024-05-24 01:18:36 +10:00
committed by RichardAH
parent 71675c4fed
commit c9dcff90fa
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ripple/app/hook/impl/applyHook.cpp
View File

@@ -2849,8 +2849,12 @@ DEFINE_JS_FUNCTION(
? applyCtx.tx.getFieldH256(sfTransactionHash)
: applyCtx.tx.getTransactionID());
// RH TODO: this can fail with a JSException, replace all instances with something safer V
return JS_NewArrayBufferCopy(ctx, txID.data(), txID.size());
auto out = ToJSIntArray(ctx, Slice{txID.data(), txID.size()});
if (!out.has_value())
returnJS(INTERNAL_ERROR);
return *out;
JS_HOOK_TEARDOWN();
}
@@ -5529,7 +5533,12 @@ DEFINE_JS_FUNCNARG(
{
JS_HOOK_SETUP();
return JS_NewArrayBufferCopy(ctx, hookCtx.result.account.data(), 20);
auto out = ToJSIntArray(ctx, Slice{hookCtx.result.account.data(), 20u});
if (!out.has_value())
returnJS(INTERNAL_ERROR);
return *out;
JS_HOOK_TEARDOWN();
}