Remove comments about featureFeeEscalation enabled 19May2016

This commit is contained in:
Scott Schurr
2020-01-13 16:17:08 -08:00
committed by Manoj doshi
parent ecbbabfc3c
commit c48be14f4f
3 changed files with 10 additions and 11 deletions

View File

@@ -563,9 +563,6 @@ TxQ::tryClearAccountQueue(Application& app, OpenView& view,
/* /*
How the decision to apply, queue, or reject is made: How the decision to apply, queue, or reject is made:
0. Is `featureFeeEscalation` enabled?
Yes: Continue to next step.
No: Fallback to `ripple::apply`. Stop.
1. Does `preflight` indicate that the tx is valid? 1. Does `preflight` indicate that the tx is valid?
No: Return the `TER` from `preflight`. Stop. No: Return the `TER` from `preflight`. Stop.
Yes: Continue to next step. Yes: Continue to next step.
@@ -1170,9 +1167,6 @@ TxQ::apply(Application& app, OpenView& view,
} }
/* /*
0. Is `featureFeeEscalation` enabled?
Yes: Continue to next step.
No: Stop.
1. Update the fee metrics based on the fee levels of the 1. Update the fee metrics based on the fee levels of the
txs in the validated ledger and whether consensus is txs in the validated ledger and whether consensus is
slow. slow.
@@ -1229,9 +1223,6 @@ TxQ::processClosedLedger(Application& app,
/* /*
How the txs are moved from the queue to the new open ledger. How the txs are moved from the queue to the new open ledger.
0. Is `featureFeeEscalation` enabled?
Yes: Continue to next step.
No: Don't do anything to the open ledger. Stop.
1. Iterate over the txs from highest fee level to lowest. 1. Iterate over the txs from highest fee level to lowest.
For each tx: For each tx:
a) Is this the first tx in the queue for this account? a) Is this the first tx in the queue for this account?

View File

@@ -53,7 +53,7 @@ class FeatureCollections
"MultiSign", "MultiSign",
"Tickets", "Tickets",
"TrustSetAuth", "TrustSetAuth",
"FeeEscalation", "FeeEscalation", // Unconditionally supported.
"OwnerPaysFee", "OwnerPaysFee",
"CompareFlowV1V2", "CompareFlowV1V2",
"PayChan", "PayChan",

View File

@@ -82,12 +82,20 @@ detail::supportedAmendments ()
{ {
// Commented out amendments will be supported in a future release (and // Commented out amendments will be supported in a future release (and
// uncommented at that time). // uncommented at that time).
//
// There are also unconditionally supported amendments in the list.
// Those are amendments that were enabled some time ago and the
// amendment conditional code has been removed.
//
// ** WARNING **
// Unconditionally supported amendments need to remain in the list.
// Removing them will cause servers to become amendment blocked.
static std::vector<std::string> const supported static std::vector<std::string> const supported
{ {
"MultiSign", "MultiSign",
// "Tickets", // "Tickets",
"TrustSetAuth", "TrustSetAuth",
"FeeEscalation", // Looks unused, but do not remove; Servers will be amendment blocked. "FeeEscalation", // Unconditionally supported.
// "OwnerPaysFee", // "OwnerPaysFee",
"PayChan", "PayChan",
"Flow", "Flow",