diff --git a/src/ripple/app/misc/impl/TxQ.cpp b/src/ripple/app/misc/impl/TxQ.cpp index a5e669b0b..59b604b43 100644 --- a/src/ripple/app/misc/impl/TxQ.cpp +++ b/src/ripple/app/misc/impl/TxQ.cpp @@ -563,9 +563,6 @@ TxQ::tryClearAccountQueue(Application& app, OpenView& view, /* How the decision to apply, queue, or reject is made: - 0. Is `featureFeeEscalation` enabled? - Yes: Continue to next step. - No: Fallback to `ripple::apply`. Stop. 1. Does `preflight` indicate that the tx is valid? No: Return the `TER` from `preflight`. Stop. Yes: Continue to next step. @@ -1170,9 +1167,6 @@ TxQ::apply(Application& app, OpenView& view, } /* - 0. Is `featureFeeEscalation` enabled? - Yes: Continue to next step. - No: Stop. 1. Update the fee metrics based on the fee levels of the txs in the validated ledger and whether consensus is slow. @@ -1229,9 +1223,6 @@ TxQ::processClosedLedger(Application& app, /* How the txs are moved from the queue to the new open ledger. - 0. Is `featureFeeEscalation` enabled? - Yes: Continue to next step. - No: Don't do anything to the open ledger. Stop. 1. Iterate over the txs from highest fee level to lowest. For each tx: a) Is this the first tx in the queue for this account? diff --git a/src/ripple/protocol/Feature.h b/src/ripple/protocol/Feature.h index 5b3aa8455..60bee93ff 100644 --- a/src/ripple/protocol/Feature.h +++ b/src/ripple/protocol/Feature.h @@ -53,7 +53,7 @@ class FeatureCollections "MultiSign", "Tickets", "TrustSetAuth", - "FeeEscalation", + "FeeEscalation", // Unconditionally supported. "OwnerPaysFee", "CompareFlowV1V2", "PayChan", diff --git a/src/ripple/protocol/impl/Feature.cpp b/src/ripple/protocol/impl/Feature.cpp index 90ef99a7e..22645e4b1 100644 --- a/src/ripple/protocol/impl/Feature.cpp +++ b/src/ripple/protocol/impl/Feature.cpp @@ -82,12 +82,20 @@ detail::supportedAmendments () { // Commented out amendments will be supported in a future release (and // uncommented at that time). + // + // There are also unconditionally supported amendments in the list. + // Those are amendments that were enabled some time ago and the + // amendment conditional code has been removed. + // + // ** WARNING ** + // Unconditionally supported amendments need to remain in the list. + // Removing them will cause servers to become amendment blocked. static std::vector const supported { "MultiSign", // "Tickets", "TrustSetAuth", - "FeeEscalation", // Looks unused, but do not remove; Servers will be amendment blocked. + "FeeEscalation", // Unconditionally supported. // "OwnerPaysFee", "PayChan", "Flow",