ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-09-28 07:58:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(manifest): bound cold lookup to one in-flight job

Browse Source 
A cache-miss naked validation queued a probe job per hash, so a burst of
unknown signers bypassed the connection's one-in-flight token. Share that
token with the cold lookup, and do not probe while a pending candidate
occupies the slot.
This commit is contained in:
Nicholas Dudfield
2026-08-31 15:40:02 +07:00
parent 1ffd07b15e
commit c129d456de
1 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/xrpld/overlay/detail/PeerImp.cpp
View File

@@ -2626,7 +2626,8 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMValidation> const& m)
// then performs the bounded cold lookup against the validated ledger.
auto const validatedLedger =
app_.getLedgerMaster().getValidatedLedger();
bool const mayResolveFromLedger = !manifestContext && !isTrusted &&
bool const mayResolveFromLedger = !manifestContext &&
!pendingManifest_ && !manifestVerificationInFlight_ && !isTrusted &&
masterKey == signingKey && !app_.validators().listed(signingKey) &&
validatedLedger &&
validatedLedger->rules().enabled(featureOnChainManifests);
@@ -2729,7 +2730,9 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMValidation> const& m)
}();
std::weak_ptr<PeerImp> weak = shared_from_this();
auto pairedPeer = manifestContext ? shared_from_this() : nullptr;
auto pairedPeer = (manifestContext || mayResolveFromLedger)
? shared_from_this()
: nullptr;
bool const pairedJob = manifestContext.has_value();
if (pairedJob)
{
@@ -2746,6 +2749,12 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMValidation> const& m)
<< "manifest_validation candidate_claimed peer=" << id_
<< " state=verification_in_flight";
}
else if (mayResolveFromLedger)
{
// The same one-in-flight token covers a cold ledger probe.
// Otherwise each unknown signing key would mint a validation job.
manifestVerificationInFlight_ = true;
}
bool queued = false;
try
@@ -2771,12 +2780,12 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMValidation> const& m)
}
catch (...)
{
if (pairedJob)
if (pairedJob || mayResolveFromLedger)
finishManifestVerification();
throw;
}
if (!queued && pairedJob)
if (!queued && (pairedJob || mayResolveFromLedger))
{
finishManifestVerification();
JLOG(p_journal_.debug())
@@ -3498,11 +3507,11 @@ PeerImp::checkValidation(
bool delayValidationHash)
{
bool const pairedJob = manifestContext.has_value();
// The queued job owns the moved association. This scope guard is its
// all-exits terminal: success, refusal, and exception consume the active
// connection token exactly once.
scope_exit finishPairVerification([this, pairedJob]() {
if (pairedJob)
// The queued job owns the moved association, or the connection's cold
// probe token. This scope guard is its all-exits terminal: success,
// refusal, and exception consume the active connection token exactly once.
scope_exit finishPairVerification([this, pairedJob, delayValidationHash]() {
if (pairedJob || delayValidationHash)
finishManifestVerification();
});