ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

NuDBBackend destructor should not throw

Browse Source
This commit is contained in:
Scott Schurr
2021-12-06 12:55:01 -08:00
committed by Nik Bougalis
parent ad805eb95b
commit 8ca2d98496
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/ripple/nodestore/backend/NuDBFactory.cpp
View File

@@ -92,7 +92,16 @@ public:
~NuDBBackend() override
{
close();
try
{
// close can throw and we don't want the destructor to throw.
close();
}
catch (nudb::system_error const&)
{
// Don't allow exceptions to propagate out of destructors.
// close() has already logged the error.
}
}
std::string
@@ -174,10 +183,20 @@ public:
nudb::error_code ec;
db_.close(ec);
if (ec)
{
// Log to make sure the nature of the error gets to the user.
JLOG(j_.fatal()) << "NuBD close() failed: " << ec.message();
Throw<nudb::system_error>(ec);
}
if (deletePath_)
{
boost::filesystem::remove_all(name_);
boost::filesystem::remove_all(name_, ec);
if (ec)
{
JLOG(j_.fatal()) << "Filesystem remove_all of " << name_
<< " failed with: " << ec.message();
}
}
}
}