ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

enforce network ID on peer handshake

Browse Source
This commit is contained in:
Richard Holland
2023-02-16 13:54:36 +00:00
parent 4f44747342
commit 7a008c21ee
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ripple/overlay/impl/Handshake.cpp
View File

@@ -237,14 +237,17 @@ verifyHandshake(
throw std::runtime_error("Invalid server domain");
}
if (auto const iter = headers.find("Network-ID"); iter != headers.end())
// Check the network. Omitting Network-ID (on either side ours, or theirs) means NID=0
{
std::uint32_t nid;
uint32_t peer_nid = 0;
if (auto const iter = headers.find("Network-ID"); iter != headers.end())
{
if (!beast::lexicalCastChecked(peer_nid, iter->value().to_string()))
throw std::runtime_error("Invalid peer network identifier");
}
if (!beast::lexicalCastChecked(nid, iter->value().to_string()))
throw std::runtime_error("Invalid peer network identifier");
if (networkID && nid != *networkID)
uint32_t our_nid = networkID ? *networkID : 0;
if (peer_nid != our_nid)
throw std::runtime_error("Peer is on a different network");
}