bug fixes

Builds/CMake/RippledCore.cmake

@@ -455,7 +455,7 @@ target_sources (rippled PRIVATE
   src/ripple/app/tx/impl/GenesisMint.cpp
   src/ripple/app/tx/impl/Import.cpp
   src/ripple/app/tx/impl/Invoke.cpp
-  src/ripple/app/tx/impl/Attestation.cpp
+  src/ripple/app/tx/impl/Attest.cpp
   src/ripple/app/tx/impl/SetSignerList.cpp
   src/ripple/app/tx/impl/SetTrust.cpp
   src/ripple/app/tx/impl/SignerEntries.cpp

src/ripple/app/tx/impl/Attest.cpp

@@ -59,7 +59,7 @@ Attest::preclaim(PreclaimContext const& ctx)
         return terNO_ACCOUNT;
 
     Keylet kl =
-        keylet::attestation(id, ctx.tx.getFieldH256(sfAttestedTxnId));
+        keylet::attestation(id, ctx.tx.getFieldH256(sfAttestedTxnID));
 
     uint32_t flags = ctx.tx.getFlags();
 
@@ -84,7 +84,7 @@ Attest::doApply()
         return tefINTERNAL;
 
     Keylet kl =
-        keylet::attestation(account_, ctx.tx.getFieldH256(sfAttestedTxnId));
+        keylet::attestation(account_, ctx_.tx.getFieldH256(sfAttestedTxnID));
 
     uint32_t flags = ctx_.tx.getFlags();
     
@@ -94,7 +94,7 @@ Attest::doApply()
     // delete mode
     if (exists && isDelete)
     {
-        auto sleA = view().peek(kl)
+        auto sleA = view().peek(kl);
 
         AccountID owner = sleA->getAccountID(sfOwner);
 
@@ -138,7 +138,7 @@ Attest::doApply()
     }
     // everything else is invalid
     else
-        return tecINTRERNAL;
+        return tecINTERNAL;
 }
 
 XRPAmount

src/ripple/protocol/impl/Indexes.cpp

@@ -436,7 +436,7 @@ nft_sells(uint256 const& id) noexcept
 }
 
 Keylet
-uritoken(AccountID const& issuer, Blob const& uri)
+uritoken(AccountID const& issuer, Blob const& uri) noexcept
 {
     return {
         ltURI_TOKEN,
@@ -444,12 +444,7 @@ uritoken(AccountID const& issuer, Blob const& uri)
             LedgerNameSpace::URI_TOKEN, issuer, Slice{uri.data(), uri.size()})};
 }
 
-Keylet attestationDir(uint32_t ledgerSeq)
-{
-    return {ltDIR_NODE, indexHash(LedgerNameSpace::ATTESTATION_DIR, ledgerSeq)};
-}
-
-Keylet attestation(AccountID const& issuer, uint256 const& txnid)
+Keylet attestation(AccountID const& issuer, uint256 const& txnid) noexcept
 {
     return {ltATTESTATION, indexHash(LedgerNameSpace::ATTESTATION, issuer, txnid)};
 }

src/ripple/protocol/impl/LedgerFormats.cpp

@@ -372,7 +372,7 @@ LedgerFormats::LedgerFormats()
             {sfPreviousTxnID,        soeREQUIRED},
             {sfPreviousTxnLgrSeq,    soeREQUIRED},
         },
-        commonField);
+        commonFields);
 
     // clang-format on
 }

src/ripple/protocol/jss.h

@@ -50,6 +50,8 @@ JSS(AccountSet);     // transaction type.
 JSS(Amendments);     // ledger type.
 JSS(Amount);         // in: TransactionSign; field.
 JSS(Authorize);      // field
+JSS(Attest);
+JSS(Attestation);
 JSS(Blob);
 JSS(Check);              // ledger type.
 JSS(CheckCancel);        // transaction type.

src/test/jtx/impl/acctdelete.cpp

@@ -17,6 +17,7 @@
 */
 //==============================================================================
 
+#include <ripple/protocol/jss.h>
 #include <test/jtx/Env.h>
 #include <test/jtx/acctdelete.h>