ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not destroy objects until all threads exit in Stoppable test

Browse Source 
Objects of class `A` could be destroyed before all their member
functions finished running.
This commit is contained in:
seelabs
2016-01-22 12:19:55 -05:00
committed by Nik Bougalis
parent 046a8f443d
commit 6701b7f1d0
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
beast/threads/impl/Stoppable.test.cpp
View File

@@ -169,7 +169,7 @@ class Stoppable_test
class A
: public Stoppable
{
enum {running, please_stop, have_stopped};
enum {running, please_stop, stopping, stopped};
D d_;
E e_;
F f_;
@@ -184,12 +184,17 @@ class Stoppable_test
, test_(test)
, stop_(running)
{}
~A()
{
while (stop_ != stopped)
;
}
void run()
{
while (stop_ == running)
;
stop_ = have_stopped;
stop_ = stopping;
}
void onPrepare() override
@@ -210,10 +215,11 @@ class Stoppable_test
void onChildrenStopped() override
{
stop_ = please_stop;
while (stop_ != have_stopped)
while (stop_ != stopping)
;
Stoppable::stopped();
test_.expect(--test_.count == 1, "A::onChildrenStopped called out of order");
stop_ = stopped;
}
};