FXV1: Meta Amount (#225)

ensure default-value amount fields are correctly recorded in metadata for created nodes (fixXahau1)

src/ripple/ledger/impl/ApplyStateTable.cpp

@@ -130,6 +130,8 @@ ApplyStateTable::generateTxMeta(
     if (!hookEmission.empty())
         meta.setHookEmissions(STArray{hookEmission, sfHookEmissions});
 
+    bool const recordDefaultAmounts = to.rules().enabled(fixXahauV1);
+
     Mods newMod;
     for (auto& item : items_)
     {
@@ -232,8 +234,12 @@ ApplyStateTable::generateTxMeta(
             STObject news(sfNewFields);
             for (auto const& obj : *curNode)
             {
+                bool const shouldRecord =
+                    (obj.getSType() == STI_AMOUNT && recordDefaultAmounts) ||
+                    !obj.isDefault();
+
                 // save non-default values
-                if (!obj.isDefault() &&
+                if (shouldRecord &&
                     obj.getFName().shouldMeta(
                         SField::sMD_Create | SField::sMD_Always))
                     news.emplace_back(obj);

src/ripple/protocol/Feature.h

@@ -74,7 +74,7 @@ namespace detail {
 // Feature.cpp. Because it's only used to reserve storage, and determine how
 // large to make the FeatureBitset, it MAY be larger. It MUST NOT be less than
 // the actual number of amendments. A LogicError on startup will verify this.
-static constexpr std::size_t numFeatures = 66;
+static constexpr std::size_t numFeatures = 67;
 
 /** Amendments that this server supports and the default voting behavior.
    Whether they are enabled depends on the Rules defined in the validated
@@ -354,6 +354,7 @@ extern uint256 const featureImport;
 extern uint256 const featureXahauGenesis;
 extern uint256 const featureHooksUpdate1;
 extern uint256 const fixURITokenV1;
+extern uint256 const fixXahauV1;
 
 }  // namespace ripple
 

src/ripple/protocol/impl/Feature.cpp

@@ -460,6 +460,7 @@ REGISTER_FEATURE(Import,                        Supported::yes, VoteBehavior::De
 REGISTER_FEATURE(XahauGenesis,                  Supported::yes, VoteBehavior::DefaultYes);
 REGISTER_FEATURE(HooksUpdate1,                  Supported::yes, VoteBehavior::DefaultYes);
 REGISTER_FIX    (fixURITokenV1,                 Supported::yes, VoteBehavior::DefaultNo);
+REGISTER_FIX    (fixXahauV1,                    Supported::yes, VoteBehavior::DefaultNo);
 
 
 // The following amendments are obsolete, but must remain supported