ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-08-23 16:30:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(protocol): preserve local TER code values

Browse Source 
Keep telENV_RPC_FAILED in its original local-error slot and append telSHADOW_TICKET_REQUIRED after it, with a TER regression test pinning both values.
This commit is contained in:
Nicholas Dudfield
2026-06-26 17:40:46 +07:00
parent 07030e2b87
commit 3c108d3a87
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/xrpl/protocol/TER.h
View File

@@ -68,8 +68,10 @@ enum TELcodes : TERUnderlyingType {
telNON_LOCAL_EMITTED_TXN,
telIMPORT_VL_KEY_NOT_RECOGNISED,
telCAN_NOT_QUEUE_IMPORT,
telSHADOW_TICKET_REQUIRED,
// Keep test-only sentinels before appended branch-local TEL codes so their
// numeric values do not move.
telENV_RPC_FAILED,
telSHADOW_TICKET_REQUIRED,
};
//------------------------------------------------------------------------------

2
src/libxrpl/protocol/TER.cpp
View File

@@ -172,8 +172,8 @@ transResults()
MAKE_ERROR(telNON_LOCAL_EMITTED_TXN, "Emitted transaction cannot be applied because it was not generated locally."),
MAKE_ERROR(telIMPORT_VL_KEY_NOT_RECOGNISED, "Import vl key was not recognized."),
MAKE_ERROR(telCAN_NOT_QUEUE_IMPORT, "Import transaction was not able to be directly applied and cannot be queued."),
MAKE_ERROR(telSHADOW_TICKET_REQUIRED, "The imported transaction uses a TicketSequence but no shadow ticket exists."),
MAKE_ERROR(telENV_RPC_FAILED, "Unit test RPC failure."),
MAKE_ERROR(telSHADOW_TICKET_REQUIRED, "The imported transaction uses a TicketSequence but no shadow ticket exists."),
MAKE_ERROR(temMALFORMED, "Malformed transaction."),
MAKE_ERROR(temBAD_AMM_TOKENS, "Malformed: Invalid LPTokens."),

12
src/test/protocol/TER_test.cpp
View File

@@ -49,6 +49,17 @@ struct TER_test : public beast::unit_test::suite
}
}
void
testLocalCodeValues()
{
// Local TEL codes are still serialized and surfaced by tests/tools, so
// new branch-local codes should append without moving existing values.
static_assert(TERtoInt(telENV_RPC_FAILED) == -380);
static_assert(TERtoInt(telSHADOW_TICKET_REQUIRED) == -379);
BEAST_EXPECT(TER::fromInt(-380) == telENV_RPC_FAILED);
BEAST_EXPECT(TER::fromInt(-379) == telSHADOW_TICKET_REQUIRED);
}
// Helper template that makes sure two types are not convertible or
// assignable if not the same.
// o I1 one tuple index.
@@ -288,6 +299,7 @@ struct TER_test : public beast::unit_test::suite
run() override
{
testTransResultInfo();
testLocalCodeValues();
testConversion();
testComparison();
}