ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-04-29 15:37:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

APIv2(account_info): handle invalid "signer_lists" value (#4585)

Browse Source 
When requesting `account_info` with an invalid `signer_lists` value, the
API should return an "invalidParams" error.

`signer_lists` should have a value of type boolean. If it is not a
boolean, then it is invalid input. The response now indicates that.

* This is an API breaking change, so the change is only reflected for
  requests containing `"api_version": 2`
* Fix #4539
This commit is contained in:
Peter Chen
2023-06-30 02:05:21 -04:00
committed by tequ
parent 8531ba5838
commit 224ae4e70f
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/ripple/rpc/handlers/AccountInfo.cpp
View File

@@ -128,6 +128,15 @@ doAccountInfo(RPC::JsonContext& context)
}
result[jss::account_flags] = std::move(acctFlags);
// The document states that signer_lists is a bool, however
// assigning any string value works. Do not allow this.
// This check is for api Version 2 onwards only
if (!params[jss::signer_lists].isBool() && context.apiVersion > 1)
{
RPC::inject_error(rpcINVALID_PARAMS, result);
return result;
}
// Return SignerList(s) if that is requested.
if (params.isMember(jss::signer_lists) &&
params[jss::signer_lists].asBool())

11
src/test/rpc/AccountInfo_test.cpp
View File

@@ -217,6 +217,10 @@ public:
"\"api_version\": 2, \"account\": \"" + alice.human() + "\", " +
"\"signer_lists\": true }";
auto const withSignersAsString = std::string("{ ") +
"\"api_version\": 2, \"account\": \"" + alice.human() + "\", " +
"\"signer_lists\": asdfggh }";
// Alice has no SignerList yet.
{
// account_info without the "signer_lists" argument.
@@ -263,6 +267,13 @@ public:
auto const& entry0 = signerEntries[0u][sfSignerEntry.jsonName];
BEAST_EXPECT(entry0[sfSignerWeight.jsonName] == 3);
}
{
// account_info with "signer_lists" as not bool should error out
auto const info =
env.rpc("json", "account_info", withSignersAsString);
BEAST_EXPECT(info[jss::status] == "error");
BEAST_EXPECT(info[jss::error] == "invalidParams");
}
// Give alice a big signer list
Account const demon{"demon"};