ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve the humanAccountID cache (RIPD-693)

Browse Source 
Profiling indicated some performance issues coming from the
cache of 160-bit account IDs to base58 format. This replaces
the single cache with two caches and rotates out old
entries.
This commit is contained in:
David Schwartz
2014-11-18 13:31:14 -08:00
committed by Nik Bougalis
parent 86df482842
commit 1084a39a45
3 changed files with 45 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/ripple/app/main/Application.cpp
View File

@@ -852,6 +852,7 @@ public:
mValidations->flush ();
RippleAddress::clearCache ();
stopped ();
}

2
src/ripple/protocol/RippleAddress.h
View File

@@ -67,6 +67,8 @@ public:
void clear ();
bool isSet () const;
static void clearCache ();
//
// Node Public - Also used for Validators
//

55
src/ripple/protocol/impl/RippleAddress.cpp
View File

@@ -330,9 +330,17 @@ Account RippleAddress::getAccountID () const
typedef std::mutex StaticLockType;
typedef std::lock_guard <StaticLockType> StaticScopedLockType;
static StaticLockType s_lock;
static hash_map< Blob , std::string > rncMap;
static StaticLockType s_lock;
static hash_map <Blob, std::string> rncMapOld, rncMapNew;
void RippleAddress::clearCache ()
{
StaticScopedLockType sl (s_lock);
rncMapOld.clear ();
rncMapNew.clear ();
}
std::string RippleAddress::humanAccountID () const
{
@@ -343,21 +351,42 @@ std::string RippleAddress::humanAccountID () const
case VER_ACCOUNT_ID:
{
StaticScopedLockType sl (s_lock);
std::string ret;
auto it = rncMap.find (vchData);
{
StaticScopedLockType sl (s_lock);
if (it != rncMap.end ())
return it->second;
auto it = rncMapNew.find (vchData);
// VFALCO NOTE Why do we throw everything out? We could keep two maps
// here, switch back and forth keep one of them full and clear the
// other on a swap - but always check both maps for cache hits.
//
if (rncMap.size () > 250000)
rncMap.clear ();
if (it != rncMapNew.end ())
{
// Found in new map, nothing to do
ret = it->second;
}
else
{
it = rncMapOld.find (vchData);
return rncMap[vchData] = ToString ();
if (it != rncMapOld.end ())
{
ret = it->second;
rncMapOld.erase (it);
}
else
ret = ToString ();
if (rncMapNew.size () >= 128000)
{
rncMapOld = std::move (rncMapNew);
rncMapNew.clear ();
rncMapNew.reserve (128000);
}
rncMapNew[vchData] = ret;
}
}
return ret;
}
case VER_ACCOUNT_PUBLIC: