ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2026-06-02 08:16:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #89 from Xahau/uritoken-v2-testing

Browse Source 
add `sfDestination` tests for URIToken
This commit is contained in:
RichardAH
2023-08-17 11:47:03 +02:00
committed by GitHub
parent 129c25a90a e7dab07e91
commit 032e61a784
2 changed files with 94 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ripple/app/tx/impl/URIToken.cpp
View File

@@ -60,7 +60,8 @@ URIToken::preflight(PreflightContext const& ctx)
return temBAD_CURRENCY;
}
if (amt == beast::zero && !ctx.tx.isFieldPresent(sfDestination))
if (tt == ttURITOKEN_MINT && amt == beast::zero &&
!ctx.tx.isFieldPresent(sfDestination))
{
JLOG(ctx.j.warn()) << "Malformed transaction. "
<< "If no sell-to destination is specified "

97
src/test/app/URIToken_test.cpp
View File

@@ -24,6 +24,7 @@
#include <ripple/protocol/TxFlags.h>
#include <ripple/protocol/jss.h>
#include <test/jtx.h>
#include <ripple/core/ConfigSections.h>
#include <chrono>
@@ -263,9 +264,14 @@ struct URIToken_test : public beast::unit_test::suite
Env env{*this, features};
auto const alice = Account("alice");
auto const bob = Account("bob");
auto const gw = Account("gw");
auto const USD = gw["USD"];
env.fund(XRP(200), alice);
env.fund(XRP(200), gw, alice);
env.close();
env.trust(USD(100'000), alice);
env.close();
env(pay(gw, alice, USD(10'000)));
std::string const uri(2, '?');
auto const tid = tokenid(alice, uri);
@@ -275,6 +281,35 @@ struct URIToken_test : public beast::unit_test::suite
// preflight
{
// temBAD_AMOUNT - !isLegalNet - !value.native()
// temBAD_AMOUNT - !isLegalNet - value.mantissa() <= cMaxNativeN
// temBAD_AMOUNT - negative XRP
Json::Value negXrpTx = mint(alice, uri);
negXrpTx[jss::Amount] = XRP(-100).value().getJson(JsonOptions::none);
env(negXrpTx, ter(temBAD_AMOUNT));
env.close();
IOU const BAD{bob, badCurrency()};
// temBAD_CURRENCY - bad currency
Json::Value badXrpTx = mint(alice, uri);
badXrpTx[jss::Amount] = BAD(100).value().getJson(JsonOptions::none);
env(badXrpTx, ter(temBAD_CURRENCY));
env.close();
// temMALFORMED - XRP must cannot be 0 without sfDestination
Json::Value nodestTx = mint(alice, uri);
nodestTx[jss::Amount] = XRP(0).value().getJson(JsonOptions::none);
env(nodestTx, ter(temMALFORMED));
env.close();
// temREDUNDANT - sfDestination cannot be sfAccount
Json::Value destSameTx = mint(alice, uri);
destSameTx[jss::Destination] = alice.human();
destSameTx[jss::Amount] = XRP(0).value().getJson(JsonOptions::none);
env(destSameTx, ter(temREDUNDANT));
env.close();
// temINVALID_FLAG - invalid flags
env(mint(alice, uri), txflags(tfAllowXRP), ter(temINVALID_FLAG));
env.close();
@@ -418,10 +453,6 @@ struct URIToken_test : public beast::unit_test::suite
IOU const BAD{gw, badCurrency()};
env(sell(alice, id, BAD(10)), ter(temBAD_CURRENCY));
// temMALFORMED - no destination and 0 value
env(sell(alice, id, USD(0)), ter(temMALFORMED));
env.close();
//----------------------------------------------------------------------
// preclaim
// tecNO_PERMISSION - invalid account
@@ -709,6 +740,62 @@ struct URIToken_test : public beast::unit_test::suite
env.close();
BEAST_EXPECT(!inOwnerDir(*env.current(), alice, tid));
}
// 0 amount and destination
{
Json::Value tx = mint(alice, uri);
tx[jss::Destination] = bob.human();
tx[jss::Amount] = XRP(0).value().getJson(JsonOptions::none);
// mint
env(tx, txflags(tfBurnable), ter(tesSUCCESS));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), alice, tid));
// buy
env(buy(bob, hexid, XRP(0)));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), bob, tid));
// cleanup
env(burn(bob, hexid));
env.close();
BEAST_EXPECT(!inOwnerDir(*env.current(), bob, tid));
}
// has amount and destination
{
Json::Value tx = mint(alice, uri);
tx[jss::Destination] = bob.human();
tx[jss::Amount] = XRP(10).value().getJson(JsonOptions::none);
// mint
env(tx, txflags(tfBurnable), ter(tesSUCCESS));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), alice, tid));
// buy
env(buy(bob, hexid, XRP(10)));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), bob, tid));
// cleanup
env(burn(bob, hexid));
env.close();
BEAST_EXPECT(!inOwnerDir(*env.current(), bob, tid));
}
// has amount and no destination
{
Json::Value tx = mint(alice, uri);
tx[jss::Amount] = XRP(10).value().getJson(JsonOptions::none);
// mint
env(tx, txflags(tfBurnable), ter(tesSUCCESS));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), alice, tid));
// buy
env(buy(bob, hexid, XRP(10)));
env.close();
BEAST_EXPECT(inOwnerDir(*env.current(), bob, tid));
// cleanup
env(burn(bob, hexid));
env.close();
BEAST_EXPECT(!inOwnerDir(*env.current(), bob, tid));
}
}
void