fix UNL

fix tests
update CONTRIBUTING
2025-11-05 05:15:48 +00:00 · 2022-07-11 18:09:28 -04:00 · 2022-07-11 16:23:11 -04:00 · 2022-07-11 16:20:31 -04:00 · 2022-07-11 16:18:15 -04:00
3 changed files with 786 additions and 433 deletions
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -83,6 +83,9 @@ npm run docgen

 This updates `docs/` at the top level, where GitHub Pages looks for the docs.

+## Update `definitions.json`
+Use [this repo](https://github.com/RichardAH/xrpl-codec-gen) to generate a new `definitions.json` file from the rippled source code. Instructions are available in that README.
+
 ## Adding and removing packages

 `xrpl.js` uses `lerna` and `npm`'s workspaces features to manage a monorepo.
--- a/packages/ripple-binary-codec/src/enums/definitions.json
+++ b/packages/ripple-binary-codec/src/enums/definitions.json
--- a/packages/ripple-binary-codec/test/fixtures/data-driven-tests.json
+++ b/packages/ripple-binary-codec/test/fixtures/data-driven-tests.json
@@ -483,13 +483,6 @@
            "type": 5,
            "expected_hex": "5013"
        },
-        {
-            "type_name": "Hash256",
-            "name": "TicketID",
-            "nth_of_type": 20,
-            "type": 5,
-            "expected_hex": "5014"
-        },
        {
            "type_name": "Hash256",
            "name": "Digest",
@@ -721,13 +714,6 @@
            "type": 8,
            "expected_hex": "84"
        },
-        {
-            "type_name": "AccountID",
-            "name": "Target",
-            "nth_of_type": 7,
-            "type": 8,
-            "expected_hex": "87"
-        },
        {
            "type_name": "AccountID",
            "name": "RegularKey",
Author	SHA1	Message	Date
Mayukha Vadari	742b9d0971	fix UNL	2022-07-11 18:09:28 -04:00
Mayukha Vadari	264a95b028	fix tests	2022-07-11 16:23:11 -04:00
Mayukha Vadari	1b02d95ad2	update CONTRIBUTING	2022-07-11 16:20:31 -04:00
Mayukha Vadari	234a2156d3	Update definitions.json	2022-07-11 16:18:15 -04:00