release: 1.9.6 (#1436)

Bumps [mocha](https://github.com/mochajs/mocha) from 7.2.0 to 8.4.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v7.2.0...v8.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

APPLICATIONS.md

@@ -20,7 +20,7 @@ Warning: Use at your own risk.
 
   Exchange allowing clients to buy and sell XRP, based in Mexico.
 
-## Data and visualizations
+## Explorers
 
 - **[xrpintel - XRP Intelligence](https://xrpintel.com/)**
 
@@ -58,10 +58,20 @@ Warning: Use at your own risk.
 
   XRP Ledger explorer, API, metrics, and analytics using a graph database that is synchronized live with the XRPL.
 
+## Data monitoring
+
 - **[zerptracker](https://zerptracker.com)**
 
   Monitor the XRPL using powerful JSONPath expressions, and receive notifications via email, SMS, webhooks, and more.
 
+- **[Utility-Scan](https://utility-scan.com)**
+
+  Attempts to detect RippleNet on-demand liquidity (ODL) transactions through known fiat corridors and report these transactions in real time.
+
+- **[XRPL Rosetta](https://xrpl-rosetta-oepox.ondigitalocean.app)**
+
+  3D Globe written in three.js connected to a Node.js websocket server that is listening to exchanges and the XRPL. The visualization aims to show trading, ODL, and liquidity at exchanges, intra-exchange volume, and flows.
+
 ## Wallets and wallet tools
 
 - **[XUMM](https://xumm.app/)**

HISTORY.md

@@ -2,6 +2,40 @@
 
 Subscribe to [the **ripple-lib-announce** mailing list](https://groups.google.com/forum/#!forum/ripple-lib-announce) for release announcements. We recommend that ripple-lib users stay up-to-date with the latest stable release.
 
+## 1.9.6 (2021-07-01)
+
+* Bug fixes
+  * Use 'current' ledger when preparing txs (#1429) (#999)
+  * Allow multiple settings at once (#1435)
+* Dependencies
+  * ripple-address-codec, prettier, mocha
+
+The SHA-256 checksums for the browser version of this release can be found below.
+```
+% shasum -a 256 build/*
+cac7f6f3be93efbd61dc5fd527c40f0d1baec06f2f9faa64e9eeb191cc85a710  build/ripple-latest-min.js
+fc17a5572001d814ea6b81aa701fcb66882ec031c68afb769a8ea8b71c6529a6  build/ripple-latest-min.js.LICENSE.txt
+5737483e940dca8b73768d8a1de8217c7e921a9cebaadef02d2b16867658f331  build/ripple-latest.js
+```
+
+## 1.9.5 (2021-06-01)
+
+* Bug fixes
+  * Prevent getFee from returning NaN from Reporting Mode (#1401) (#1398)
+  * Return promise inside catch block of reconnect to propagate promise (#1418) (#1113) (thanks @camposfyi)
+  * Internal
+    * Update mocha to use RC file config (#1417) (#1210) (thanks @camposfyi)
+* Dependencies
+  * @types/ws, ws, browserslist, @types/lodash
+
+The SHA-256 checksums for the browser version of this release can be found below.
+```
+% shasum -a 256 build/*
+fcdc4aa1e1df7cb788b68f3d036e168aa64f9e818f441b99fef62d4571c0387d  build/ripple-latest-min.js
+fc17a5572001d814ea6b81aa701fcb66882ec031c68afb769a8ea8b71c6529a6  build/ripple-latest-min.js.LICENSE.txt
+dfb7a92c4156fb3ee367254b5ea0935cda741cd3b5c36cdca695e7d89f88605e  build/ripple-latest.js
+```
+
 ## 1.9.4 (2021-04-18)
 
 * Add memos support for all transaction types for getTransactions (#1353, #1397)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ripple-lib",
-  "version": "1.9.4",
+  "version": "1.9.6",
   "license": "ISC",
   "description": "A TypeScript/JavaScript API for interacting with the XRP Ledger in Node.js and the browser",
   "files": [
@@ -38,7 +38,7 @@
   },
   "devDependencies": {
     "@types/mocha": "^8.2.1",
-    "@types/node": "^14.0.1",
+    "@types/node": "^15.0.1",
     "@typescript-eslint/eslint-plugin": "^2.3.3",
     "@typescript-eslint/parser": "^2.27.0",
     "assert": "^2.0.0",
@@ -50,7 +50,7 @@
     "eslint": "^6.5.1",
     "eventemitter2": "^6.0.0",
     "json-schema-to-markdown-table": "^0.4.0",
-    "mocha": "^7",
+    "mocha": "^8",
     "nyc": "^15",
     "prettier": "^2.0.5",
     "process": "^0.11.10",
@@ -73,7 +73,7 @@
     "doctoc": "doctoc docs/index.md --title '# RippleAPI Reference' --github --maxlevel 2",
     "docgen": "node --harmony scripts/build_docs.js",
     "prepublish": "yarn clean && yarn build",
-    "test": "TS_NODE_PROJECT=src/tsconfig.json nyc mocha --exit",
+    "test": "TS_NODE_PROJECT=src/tsconfig.json nyc mocha --config=test/.mocharc.json --exit",
     "test:watch": "TS_NODE_PROJECT=src/tsconfig.json mocha --watch --reporter dot",
     "format": "prettier --write '{src,test}/**/*.ts'",
     "lint": "eslint 'src/**/*.ts' 'test/*-test.{ts,js}'",

src/common/connection.ts

@@ -390,7 +390,7 @@ export class Connection extends EventEmitter {
    */
   private _heartbeat = () => {
     return this.request({command: 'ping'}).catch(() => {
-      this.reconnect().catch((error) => {
+      return this.reconnect().catch((error) => {
         this.emit('error', 'reconnect', error.message, error)
       })
     })

src/common/serverinfo.ts

@@ -71,6 +71,10 @@ async function getFee(this: RippleAPI, cushion?: number): Promise<string> {
 
   const serverInfo = (await this.request('server_info')).info
   const baseFeeXrp = new BigNumber(serverInfo.validated_ledger.base_fee_xrp)
+  if (serverInfo.load_factor === undefined) {
+    // https://github.com/ripple/rippled/issues/3812#issuecomment-816871100
+    serverInfo.load_factor = 1
+  }
   let fee = baseFeeXrp.times(serverInfo.load_factor).times(cushion)
 
   // Cap fee to `this._maxFeeXRP`

src/transaction/settings.ts

@@ -17,9 +17,9 @@ function setTransactionFlags(
   txJSON: TransactionJSON,
   values: FormattedSettings
 ) {
-  const keys = Object.keys(values)
+  const keys = Object.keys(values).filter((key) => AccountFlagIndices[key] !== undefined)
   assert.ok(
-    keys.length === 1,
+    keys.length <= 1,
     'ERROR: can only set one setting per transaction'
   )
   const flagName = keys[0]

src/transaction/utils.ts

@@ -346,9 +346,9 @@ function prepareTransaction(
     }
 
     try {
-      // Consider requesting from the 'current' ledger (instead of 'validated').
       const response = await api.request('account_info', {
-        account: classicAccount
+        account: classicAccount,
+        ledger_index: 'current' // Fix #999
       })
       newTxJSON.Sequence = response.account_data.Sequence
       return Promise.resolve()

test/.mocharc.json

@@ -0,0 +1,21 @@
+{
+  "diff": true,
+  "spec": ["./test/*.ts"],
+  "extension": ["ts"],
+  "package": "../package.json",
+  "require": "ts-node/register",
+  "reporter": "spec",
+  "slow": 500,
+  "timeout": 5000,
+  "recursive": true,
+  "file": [],
+  "ui": "bdd",
+  "watch-files": [
+    "src/**/*.ts",
+    "test/**/*.ts"
+  ],
+  "watch-ignore": [
+    "test/node_modules/**/*",
+    "test/vendor/**/*"
+  ]
+}

test/api/getFee/index.ts

@@ -51,5 +51,14 @@ export default <TestSuite>{
     api._feeCushion = 0.9
     const fee = await api.getFee()
     assert.strictEqual(fee, '0.000009')
+  },
+
+  'getFee reporting': async (api, address) => {
+    api.connection.request({
+      command: 'config',
+      data: {reporting: true}
+    })
+    const fee = await api.getFee()
+    assert.strictEqual(fee, '0.000012')
   }
 }

test/fixtures/rippled/index.js

@@ -50,7 +50,8 @@ module.exports = {
     normal: require('./server-info'),
     noValidated: require('./server-info-no-validated'),
     syncing: require('./server-info-syncing'),
-    error: require('./server-info-error')
+    error: require('./server-info-error'),
+    reporting: require('./server-info-reporting')
   },
   path_find: {
     generate: require('./path-find'),

test/fixtures/rippled/server-info-reporting.json

@@ -0,0 +1,82 @@
+{
+  "id": 0,
+  "status": "success",
+  "type": "response",
+  "result": {
+    "info": {
+      "build_version": "1.7.0",
+      "complete_ledgers": "32570-62713383",
+      "hostid": "DUG",
+      "io_latency_ms": 1,
+      "last_close": {
+        "converge_time_s": 0,
+        "proposers": 0
+      },
+      "pubkey_node": "n9Krd83Ab8rW29LhNZPNQ3EFYBs59V1k7sGu1WizLNogrCEi56kF",
+      "published_ledger": "none",
+      "reporting": {
+        "etl_sources": [
+          {
+            "connected": true,
+            "grpc_port": "50051",
+            "ip": "10.30.32.34",
+            "last_message_arrival_time": "2021-Apr-06 10:34:33.171053 UTC",
+            "validated_ledgers_range": "61506690-62713383",
+            "websocket_port": "51233"
+          },
+          {
+            "connected": true,
+            "grpc_port": "50051",
+            "ip": "10.30.32.170",
+            "last_message_arrival_time": "2021-Apr-06 10:34:33.172233 UTC",
+            "validated_ledgers_range": "61916861-62713383",
+            "websocket_port": "51233"
+          }
+        ],
+        "is_writer": true,
+        "last_publish_time": "2021-Apr-06 10:34:31.612887 UTC"
+      },
+      "server_state": "full",
+      "server_state_duration_us": "649088585088",
+      "state_accounting": {
+        "connected": {
+          "duration_us": "0",
+          "transitions": 0
+        },
+        "disconnected": {
+          "duration_us": "34471",
+          "transitions": 1
+        },
+        "full": {
+          "duration_us": "649088585088",
+          "transitions": 1
+        },
+        "syncing": {
+          "duration_us": "0",
+          "transitions": 0
+        },
+        "tracking": {
+          "duration_us": "0",
+          "transitions": 0
+        }
+      },
+      "time": "2021-Apr-06 10:34:33.293823 UTC",
+      "uptime": 649092,
+      "validated_ledger": {
+        "age": 3,
+        "base_fee_xrp": 1e-05,
+        "hash": "F04E9B08596F86DEF1F55FA29380C1ECC04079DA0A9539FE60E85ADC092C292A",
+        "reserve_base_xrp": 20,
+        "reserve_inc_xrp": 5,
+        "seq": 62713383
+      },
+      "validation_quorum": 1
+    },
+    "warnings": [
+      {
+        "id": 1004,
+        "message": "This is a reporting server.  The default behavior of a reporting server is to only return validated data. If you are looking for not yet validated data, include \"ledger_index : current\" in your request, which will cause this server to forward the request to a p2p node. If the forward is successful the response will include \"forwarded\" : \"true\""
+      }
+    ]
+  }
+}

test/mocha.opts

@@ -1,6 +0,0 @@
---reporter spec
---timeout 5000
---slow 500
---require ts-node/register
---watch-extensions ts
-./test/*.{ts,js}

test/mock-rippled.ts

@@ -224,6 +224,8 @@ export function createMockRippled(port) {
         }
       }
       conn.send(createResponse(request, response))
+    } else if (conn.config.reporting) {
+      conn.send(createResponse(request, fixtures.server_info.reporting))
     } else if (conn.config.returnErrorOnServerInfo) {
       conn.send(createResponse(request, fixtures.server_info.error))
     } else if (conn.config.disconnectOnServerInfo) {