ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-20 20:25:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove sidechain-devnet faucet (#2518)

Browse Source 
Removes faucet support for the sidechain devnet since the bridge has been moved to Devnet, which already has a faucet.
This commit is contained in:
Mayukha Vadari
2023-10-17 13:30:52 -04:00
committed by GitHub
parent e941b73c4b
commit 8e929c5a57
4 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/xrpl/HISTORY.md
View File

@@ -14,6 +14,9 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr
* Make `LedgerEntryResponse` a generic so it can be used like `LedgerEntryResponse<Escrow>` * Make `LedgerEntryResponse` a generic so it can be used like `LedgerEntryResponse<Escrow>`
* Clean up typing of `type` param and the response property `account_objects` of the `account_objects` request. * Clean up typing of `type` param and the response property `account_objects` of the `account_objects` request.
### Changed
* Removed sidechain-devnet faucet support as it is being moved to Devnet
## 2.12.0 (2023-09-27) ## 2.12.0 (2023-09-27)
### Added ### Added
* Added `ports` field to `ServerInfoResponse` * Added `ports` field to `ServerInfoResponse`

9
packages/xrpl/snippets/src/bridgeTransfer.ts
View File

@@ -20,11 +20,9 @@ async function sleep(sec: number): Promise<void> {
}) })
} }
const lockingClient = new Client( const lockingClient = new Client('wss://s.devnet.rippletest.net:51233')
'wss://sidechain-net1.devnet.rippletest.net:51233',
)
const issuingClient = new Client( const issuingClient = new Client(
'wss://sidechain-net2.devnet.rippletest.net:51233', 'wss://devnetsidechain2.devnet.rippletest.net:51233',
) )
const MAX_LEDGERS_WAITED = 5 const MAX_LEDGERS_WAITED = 5
const LEDGER_CLOSE_TIME = 4 const LEDGER_CLOSE_TIME = 4
@@ -34,7 +32,7 @@ void bridgeTransfer()
async function bridgeTransfer(): Promise<void> { async function bridgeTransfer(): Promise<void> {
await lockingClient.connect() await lockingClient.connect()
await issuingClient.connect() await issuingClient.connect()
const lockingChainDoor = 'rMAXACCrp3Y8PpswXcg3bKggHX76V3F8M4' const lockingChainDoor = 'rNQQyL2bJqbtgP5zXHJyQXamtrKYpgsbzV'
const accountObjectsRequest: AccountObjectsRequest = { const accountObjectsRequest: AccountObjectsRequest = {
command: 'account_objects', command: 'account_objects',
@@ -72,6 +70,7 @@ async function bridgeTransfer(): Promise<void> {
parseInt(bridgeData.MinAccountCreateAmount as string, 10) * 2 parseInt(bridgeData.MinAccountCreateAmount as string, 10) * 2
).toString(), ).toString(),
} }
console.log(fundTx)
const fundResponse = await lockingClient.submitAndWait(fundTx, { const fundResponse = await lockingClient.submitAndWait(fundTx, {
wallet: wallet1, wallet: wallet1,
}) })

4
packages/xrpl/src/Wallet/defaultFaucets.ts
View File

@@ -50,10 +50,6 @@ export function getFaucetHost(client: Client): FaucetNetwork | undefined {
return FaucetNetwork.AMMDevnet return FaucetNetwork.AMMDevnet
} }
if (connectionUrl.includes('sidechain-net1')) {
return FaucetNetwork.SidechainDevnet
}
if (connectionUrl.includes('sidechain-net2')) { if (connectionUrl.includes('sidechain-net2')) {
throw new XRPLFaucetError( throw new XRPLFaucetError(
'Cannot fund an account on an issuing chain. Accounts must be created via the bridge.', 'Cannot fund an account on an issuing chain. Accounts must be created via the bridge.',

10
packages/xrpl/test/integration/fundWallet.test.ts
View File

@@ -126,16 +126,6 @@ describe('fundWallet', function () {
TIMEOUT, TIMEOUT,
) )
it(
'can generate and fund wallets on sidechain devnet',
async function () {
await generate_faucet_wallet_and_fund_again(
'wss://sidechain-net1.devnet.rippletest.net:51233',
)
},
TIMEOUT,
)
it( it(
'submit funds wallet with custom amount', 'submit funds wallet with custom amount',
async function () { async function () {