diff --git a/packages/xrpl/HISTORY.md b/packages/xrpl/HISTORY.md index 1ec9c0f3..ba2e1d74 100644 --- a/packages/xrpl/HISTORY.md +++ b/packages/xrpl/HISTORY.md @@ -14,6 +14,9 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr * Make `LedgerEntryResponse` a generic so it can be used like `LedgerEntryResponse` * Clean up typing of `type` param and the response property `account_objects` of the `account_objects` request. +### Changed +* Removed sidechain-devnet faucet support as it is being moved to Devnet + ## 2.12.0 (2023-09-27) ### Added * Added `ports` field to `ServerInfoResponse` diff --git a/packages/xrpl/snippets/src/bridgeTransfer.ts b/packages/xrpl/snippets/src/bridgeTransfer.ts index 8043a141..b7e25de5 100644 --- a/packages/xrpl/snippets/src/bridgeTransfer.ts +++ b/packages/xrpl/snippets/src/bridgeTransfer.ts @@ -20,11 +20,9 @@ async function sleep(sec: number): Promise { }) } -const lockingClient = new Client( - 'wss://sidechain-net1.devnet.rippletest.net:51233', -) +const lockingClient = new Client('wss://s.devnet.rippletest.net:51233') const issuingClient = new Client( - 'wss://sidechain-net2.devnet.rippletest.net:51233', + 'wss://devnetsidechain2.devnet.rippletest.net:51233', ) const MAX_LEDGERS_WAITED = 5 const LEDGER_CLOSE_TIME = 4 @@ -34,7 +32,7 @@ void bridgeTransfer() async function bridgeTransfer(): Promise { await lockingClient.connect() await issuingClient.connect() - const lockingChainDoor = 'rMAXACCrp3Y8PpswXcg3bKggHX76V3F8M4' + const lockingChainDoor = 'rNQQyL2bJqbtgP5zXHJyQXamtrKYpgsbzV' const accountObjectsRequest: AccountObjectsRequest = { command: 'account_objects', @@ -72,6 +70,7 @@ async function bridgeTransfer(): Promise { parseInt(bridgeData.MinAccountCreateAmount as string, 10) * 2 ).toString(), } + console.log(fundTx) const fundResponse = await lockingClient.submitAndWait(fundTx, { wallet: wallet1, }) diff --git a/packages/xrpl/src/Wallet/defaultFaucets.ts b/packages/xrpl/src/Wallet/defaultFaucets.ts index 78197089..f47c3ff7 100644 --- a/packages/xrpl/src/Wallet/defaultFaucets.ts +++ b/packages/xrpl/src/Wallet/defaultFaucets.ts @@ -50,10 +50,6 @@ export function getFaucetHost(client: Client): FaucetNetwork | undefined { return FaucetNetwork.AMMDevnet } - if (connectionUrl.includes('sidechain-net1')) { - return FaucetNetwork.SidechainDevnet - } - if (connectionUrl.includes('sidechain-net2')) { throw new XRPLFaucetError( 'Cannot fund an account on an issuing chain. Accounts must be created via the bridge.', diff --git a/packages/xrpl/test/integration/fundWallet.test.ts b/packages/xrpl/test/integration/fundWallet.test.ts index 9b757f51..173d4d19 100644 --- a/packages/xrpl/test/integration/fundWallet.test.ts +++ b/packages/xrpl/test/integration/fundWallet.test.ts @@ -126,16 +126,6 @@ describe('fundWallet', function () { TIMEOUT, ) - it( - 'can generate and fund wallets on sidechain devnet', - async function () { - await generate_faucet_wallet_and_fund_again( - 'wss://sidechain-net1.devnet.rippletest.net:51233', - ) - }, - TIMEOUT, - ) - it( 'submit funds wallet with custom amount', async function () {