ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-27 23:55:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

JS: Don't trigger global subscribe for remote.on('transaction').

Browse Source 
Now that all transactions we're subscribed to for any reason come in via
`type: transaction"`, users may need to subscribe to these events without
triggering a subscription to all transactions network-wide.

So if you were subscribing to the network-wide transaction firehose via:

    remote.on('transaction', ...);

Please change this to:

    remote.on('transaction_all', ...);
This commit is contained in:
Stefan Thomas
2013-03-06 21:52:48 +01:00
parent e194560de2
commit 8e8a10d90d
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/js/remote.js
View File

@@ -234,11 +234,15 @@ Request.prototype.books = function (books) {
// 'connected'
// 'disconnected'
// 'state':
// - 'online' : connected and subscribed
// - 'offline' : not subscribed or not connected.
// 'ledger_closed': A good indicate of ready to serve.
// 'subscribed' : This indicates stand-alone is available.
// - 'online' : Connected and subscribed.
// - 'offline' : Not subscribed or not connected.
// 'subscribed' : This indicates stand-alone is available.
//
// Server events:
// 'ledger_closed' : A good indicate of ready to serve.
// 'transaction' : Transactions we receive based on current subscriptions.
// 'transaction_all' : Listening triggers a subscribe to all transactions
// globally in the network.
// --> trusted: truthy, if remote is trusted
var Remote = function (opts, trace) {
@@ -309,7 +313,7 @@ var Remote = function (opts, trace) {
};
this.on('newListener', function (type, listener) {
if ('transaction' === type)
if ('transaction_all' === type)
{
if (!self._transaction_subs && 'open' === self._online_state)
{
@@ -322,7 +326,7 @@ var Remote = function (opts, trace) {
});
this.on('removeListener', function (type, listener) {
if ('transaction' === type)
if ('transaction_all' === type)
{
self._transaction_subs -= 1;
@@ -643,6 +647,7 @@ Remote.prototype._connect_message = function (ws, json) {
}
this.emit('transaction', message);
this.emit('transaction_all', message);
break;
case 'serverStatus':