Merge pull request #786 from ripple/escrow-execution-ValidationError

escrow-execution - Add reference to ValidationError

src/transaction/escrow-execution.js

@@ -3,6 +3,7 @@
 const _ = require('lodash')
 const utils = require('./utils')
 const validate = utils.common.validate
+const ValidationError = utils.common.errors.ValidationError
 import type {Instructions, Prepare} from './types.js'
 import type {Memo} from '../common/types.js'
 

test/api-test.js

@@ -302,6 +302,20 @@ describe('RippleAPI', function() {
           'prepare'));
   });
 
+  it('prepareEscrowExecution - no condition', function() {
+    assert.throws(() => {
+      this.api.prepareEscrowExecution(address,
+      requests.prepareEscrowExecution.noCondition, instructions);
+    }, /"condition" and "fulfillment" fields on EscrowFinish must only be specified together./);
+  });
+
+  it('prepareEscrowExecution - no fulfillment', function() {
+    assert.throws(() => {
+      this.api.prepareEscrowExecution(address,
+      requests.prepareEscrowExecution.noFulfillment, instructions);
+    }, /"condition" and "fulfillment" fields on EscrowFinish must only be specified together./);
+  });
+
   it('prepareEscrowCancellation', function() {
     return this.api.prepareEscrowCancellation(
       address,

test/fixtures/requests/index.js

@@ -30,7 +30,9 @@ module.exports = {
   },
   prepareEscrowExecution: {
     normal: require('./prepare-escrow-execution'),
-    simple: require('./prepare-escrow-execution-simple')
+    simple: require('./prepare-escrow-execution-simple'),
+    noCondition: require('./prepare-escrow-execution-no-condition'),
+    noFulfillment: require('./prepare-escrow-execution-no-fulfillment')
   },
   prepareEscrowCancellation: {
     normal: require('./prepare-escrow-cancellation'),

test/fixtures/requests/prepare-escrow-execution-no-condition.json

@@ -0,0 +1,5 @@
+{
+  "owner": "r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59",
+  "escrowSequence": 1234,
+  "fulfillment": "A0028000"
+}

test/fixtures/requests/prepare-escrow-execution-no-fulfillment.json

@@ -0,0 +1,5 @@
+{
+  "owner": "r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59",
+  "escrowSequence": 1234,
+  "condition": "A0258020E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855810100"
+}