mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-19 05:10:55 +00:00
ee6ddfbfdb
The stack asserted its preconditions and then went ahead regardless. Asserts expand to `assert`, so in a release build every one of those was a no-op in front of the operation it was guarding: reading or popping an empty `std::stack` is undefined, `pushChild`'s out-of-range branch check was missing entirely, and `getChildNodeID` throws `std::logic_error` at leaf depth. None of these conditions are reachable through any of `SHAMap`'s public entry points today, but the failure modes if they ever did happen would be disproportionate: an out-of-range branch would silently corrupt a node ID instead of failing loudly, and a `logic_error` reaching an unguarded call chain would abort the process, since nothing in this codebase catches it. Pushes now return false instead of throwing or silently corrupting the ID, and reads degrade to a null node rather than undefined behavior. `[[nodiscard]]` makes an unchecked push a compile error. Each new guard is marked `UNREACHABLE` rather than left implicitly untested, since no test fixture in this suite can reach these paths without building a deliberately corrupt map. `pushRoot` gets the same conversion as every sibling method; it was the one push still asserting instead of returning false. `walkTowardsKey`'s two modes (with and without a caller-supplied stack) must fail at the same node and leave the stack in a state every caller already knows how to handle; on failure the stack is now cleared via a restored `clear()`, and a restored `pushCurrent` lambda keeps the loop-entry and post-loop push-and-clear logic from being duplicated. It also stops deriving each node ID twice: a caller-supplied stack now reads the ID `pushNode` just computed off `stack->top().second`, instead of a redundant local copy that additionally went stale once the loop exited. `belowHelper` and `peekNextItem` finally get the fallback `top()`'s own docstring promises: both read `stack.top()` right after an assert-only emptiness check, with no fallback for release builds, so both now return early on an empty stack instead of dereferencing a null `SHAMapTreeNodePtr`. `pushChild`'s hard guard also only checked the parent's depth against `kLeafDepth`, one level too permissive for an inner child: a parent at 63 passed the check, then pushed an inner child at 64 with only a debug-only assert catching it, the exact gap this commit exists to close. Tightened to require depth + 1 below `kLeafDepth` for an inner child, with `walkTowardsKey`'s no-stack path given the identical tightening so a malformed map fails at the same node in both modes.
The XRP Ledger
The XRP Ledger is a decentralized cryptographic ledger powered by a network of peer-to-peer nodes. The XRP Ledger uses a novel Byzantine Fault Tolerant consensus algorithm to settle and record transactions in a secure distributed database without a central operator.
XRP
XRP is a public, counterparty-free crypto-asset native to the XRP Ledger, and is designed as a gas token for network services and to bridge different currencies. XRP is traded on the open-market and is available for anyone to access. The XRP Ledger was created in 2012 with a finite supply of 100 billion units of XRP.
xrpld
The server software that powers the XRP Ledger is called xrpld and is available in this repository under the permissive ISC open-source license. The xrpld server software is written primarily in C++ and runs on a variety of platforms. The xrpld server software can run in several modes depending on its configuration.
If you are interested in running an API Server (including a Full History Server), take a look at Clio. (xrpld Reporting Mode has been replaced by Clio.)
Build from Source
- Read the build instructions in
BUILD.md - If you encounter any issues, please open an issue
Key Features of the XRP Ledger
- Censorship-Resistant Transaction Processing: No single party decides which transactions succeed or fail, and no one can "roll back" a transaction after it completes. As long as those who choose to participate in the network keep it healthy, they can settle transactions in seconds.
- Fast, Efficient Consensus Algorithm: The XRP Ledger's consensus algorithm settles transactions in 4 to 5 seconds, processing at a throughput of up to 1500 transactions per second. These properties put XRP at least an order of magnitude ahead of other top digital assets.
- Finite XRP Supply: When the XRP Ledger began, 100 billion XRP were created, and no more XRP will ever be created. The available supply of XRP decreases slowly over time as small amounts are destroyed to pay transaction fees.
- Responsible Software Governance: A team of full-time developers at Ripple & other organizations maintain and continually improve the XRP Ledger's underlying software with contributions from the open-source community. Ripple acts as a steward for the technology and an advocate for its interests.
- Secure, Adaptable Cryptography: The XRP Ledger relies on industry standard digital signature systems like ECDSA (the same scheme used by Bitcoin) but also supports modern, efficient algorithms like Ed25519. The extensible nature of the XRP Ledger's software makes it possible to add and disable algorithms as the state of the art in cryptography advances.
- Modern Features: Features like Escrow, Checks, and Payment Channels support financial applications atop of the XRP Ledger. This toolbox of advanced features comes with safety features like a process for amending the network and separate checks against invariant constraints.
- On-Ledger Decentralized Exchange: In addition to all the features that make XRP useful on its own, the XRP Ledger also has a fully-functional accounting system for tracking and trading obligations denominated in any way users want, and an exchange built into the protocol. The XRP Ledger can settle long, cross-currency payment paths and exchanges of multiple currencies in atomic transactions, bridging gaps of trust with XRP.
Source Code
Here are some good places to start learning the source code:
- Read the markdown files in the source tree:
src/xrpld/**/*.md. - Read the levelization document to get an idea of the internal dependency graph.
- In the big picture, the
mainfunction constructs anApplicationImpobject, which implements theApplicationvirtual interface. Almost every component in the application takes anApplication¶meter in its constructor, typically namedappand stored as a member variableapp_. This allows most components to depend on any other component.
Repository Contents
| Folder | Contents |
|---|---|
./bin |
Scripts and data files for XRPL developers. |
./Builds |
Platform-specific guides for building xrpld. |
./docs |
Source documentation files and doxygen config. |
./cfg |
Example configuration files. |
./src |
Source code. |
Some of the directories under src are external repositories included using
git-subtree. See those directories' README files for more details.