Merge branch 'ximinez/lending-XLS-66-ongoing' into tapanito/lending-check-error

treat unimpaired loan
MPTTester::operator() parameter should be std::int64_t
2025-12-05 08:48:03 +00:00 · 2025-12-03 19:38:15 +01:00 · 2025-12-03 15:19:23 +01:00 · 2025-12-02 22:56:19 -05:00 · 2025-12-02 12:26:11 -05:00 · 2025-12-02 10:50:57 -05:00
1 changed files with 7 additions and 1 deletions
--- a/src/xrpld/app/tx/detail/LoanPay.cpp
+++ b/src/xrpld/app/tx/detail/LoanPay.cpp
@@ -305,7 +305,13 @@ LoanPay::doApply()
    // change will be discarded.
    if (loanSle->isFlag(lsfLoanImpaired))
    {
-        LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);
+        if (auto const ret =
+                LoanManage::unimpairLoan(view, loanSle, vaultSle, j_);
+            ret != tesSUCCESS)
+        {
+            JLOG(j_.fatal()) << "Failed to unimpair loan before payment.";
+            return ret;  // LCOV_EXCL_LINE
+        }
    }

    LoanPaymentType const paymentType = [&tx]() {
Author	SHA1	Message	Date
Vito Tumas	4526d6b77b	Merge branch 'ximinez/lending-XLS-66-ongoing' into tapanito/lending-check-error	2025-12-03 19:38:15 +01:00
Vito	7f7fda5fd2	treat unimpaired loan	2025-12-03 15:19:23 +01:00
Ed Hennis	335b9becd7	MPTTester::operator() parameter should be std::int64_t - Originally defined as uint64_t, but the testIssuerLoan() test called it with a negative number, causing an overflow to a very large number that in some circumstances could be silently cast back to an int64_t, but might not be. I believe this is UB, and we don't want to rely on that.	2025-12-02 22:56:19 -05:00
Ed Hennis	8e4be94f4a	Merge remote-tracking branch 'XRPLF/ximinez/develop-nolending' into ximinez/lending-XLS-66-2 * XRPLF/ximinez/develop-nolending: Revert "Implement Lending Protocol (unsupported) (5270)" Implement Lending Protocol (unsupported) (5270)	2025-12-02 12:26:11 -05:00
Ed Hennis	1f3ded7116	Test updates - show balances in runLoan()	2025-12-02 10:50:57 -05:00
Ed Hennis	aa1234199a	Review feedback from @dangell7: early return & coverage - Exclude LogicError lines in ApplyView.cpp (specifically directory operations) from code coverage. - Replace the ability to set the next page on a new directory page with an assert, because nothing uses it right now. - Early return with success for batch inner transactions in preflight2.	2025-12-02 10:48:22 -05:00
Ed Hennis	da9a483b79	Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2	2025-12-01 16:49:54 -05:00
Vito Tumas	f447827474	Fix overpayment asserts (#6084 )	2025-12-01 14:59:12 -05:00
Ed Hennis	07497322de	Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2	2025-12-01 14:40:27 -05:00