Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-XLS-66-test-wip

- Not quite working

include/xrpl/protocol/detail/features.macro

@@ -16,7 +16,7 @@
 // Add new amendments to the top of this list.
 // Keep it sorted in reverse chronological order.
 
-XRPL_FEATURE(LendingProtocol,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(LendingProtocol,            Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FEATURE(PermissionDelegationV1_1,   Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FIX    (DirectoryLimit,             Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FIX    (IncludeKeyletFields,        Supported::yes, VoteBehavior::DefaultNo)
@@ -30,7 +30,7 @@ XRPL_FIX    (EnforceNFTokenTrustlineV2,  Supported::yes, VoteBehavior::DefaultNo
 XRPL_FIX    (AMMv1_3,                    Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(PermissionedDEX,            Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(Batch,                      Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(SingleAssetVault,           Supported::yes,  VoteBehavior::DefaultNo)
+XRPL_FEATURE(SingleAssetVault,           Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FIX    (PayChanCancelAfter,         Supported::yes, VoteBehavior::DefaultNo)
 // Check flags in Credential transactions
 XRPL_FIX    (InvalidTxFlags,             Supported::yes, VoteBehavior::DefaultNo)

src/test/app/Loan_test.cpp

@@ -521,6 +521,35 @@ protected:
                 .paymentInterval = loan->at(sfPaymentInterval),
                 .interestRate = TenthBips32{loan->at(sfInterestRate)},
             };
+            BEAST_EXPECT(state.previousPaymentDate == 0);
+            BEAST_EXPECT(
+                tp{d{state.nextPaymentDate}} == state.startDate + 600s);
+            BEAST_EXPECT(state.paymentRemaining == 12);
+            BEAST_EXPECT(
+                state.principalOutstanding == broker.asset(loanAmount).value());
+            BEAST_EXPECT(
+                state.loanScale ==
+                (broker.asset.integral()
+                     ? 0
+                     : state.principalOutstanding.exponent()));
+            BEAST_EXPECT(state.paymentInterval == 600);
+            BEAST_EXPECT(
+                state.totalValue ==
+                roundToAsset(
+                    broker.asset,
+                    state.periodicPayment * state.paymentRemaining,
+                    state.loanScale));
+            BEAST_EXPECT(
+                state.managementFeeOutstanding ==
+                computeFee(
+                    broker.asset,
+                    state.totalValue - state.principalOutstanding,
+                    managementFeeRateParameter,
+                    state.loanScale));
+
+            verifyLoanStatus(state);
+
+            return state;
         }
         return LoanState{};
     }
@@ -532,6 +561,7 @@ protected:
         jtx::Env const& env,
         BrokerInfo const& broker,
         Keylet const& loanKeylet,
+        Number const& loanAmount,
         VerifyLoanStatus const& verifyLoanStatus)
     {
         using namespace std::chrono_literals;
@@ -1364,10 +1394,10 @@ protected:
             .counterpartyExplicit = false,
             .principalRequest = loanAmount,
             .setFee = loanSetFee,
-            .originationFee = 1,
-            .serviceFee = 2,
-            .lateFee = 3,
-            .closeFee = 4,
+            .originationFee = loanAmount * Number(1, -3),
+            .serviceFee = loanAmount * Number(2, -3),
+            .lateFee = loanAmount * Number(3, -3),
+            .closeFee = loanAmount * Number(4, -3),
             .overFee = applyExponent(percentageToTenthBips(5) / 10),
             .interest = applyExponent(percentageToTenthBips(12)),
             // 2.4%
@@ -1468,7 +1498,8 @@ protected:
                 loan->at(sfPrincipalOutstanding) == principalRequestAmount);
         }
 
-        auto state = getCurrentState(env, broker, keylet, verifyLoanStatus);
+        auto state =
+            getCurrentState(env, broker, keylet, loanAmount, verifyLoanStatus);
 
         auto const loanProperties = computeLoanProperties(
             broker.asset.raw(),
@@ -1642,8 +1673,8 @@ protected:
         auto const currencyLabel = getCurrencyLabel(asset);
         auto const caseLabel = [&]() {
             std::stringstream ss;
-            ss << "Lifecycle: " << loanAmount << " " << currencyLabel
-               << " Scale interest to: " << interestExponent << " ";
+            ss << "Lifecycle: " << " " << currencyLabel << " Interest scale: "
+               << Number(1, interestExponent) " Amount: " << loanAmount;
             return ss.str();
         }();
         testcase << caseLabel;
@@ -2144,8 +2175,8 @@ protected:
                 // Default the loan
 
                 // Initialize values with the current state
-                auto state =
-                    getCurrentState(env, broker, loanKeylet, verifyLoanStatus);
+                auto state = getCurrentState(
+                    env, broker, loanKeylet, loanAmount, verifyLoanStatus);
                 BEAST_EXPECT(state.flags == baseFlag);
 
                 auto const& broker = verifyLoanStatus.broker;
@@ -2373,8 +2404,9 @@ protected:
                        VerifyLoanStatus const& verifyLoanStatus) {
                 // toEndOfLife
                 //
-                auto state =
-                    getCurrentState(env, broker, loanKeylet, verifyLoanStatus);
+                auto state = getCurrentState(
+                    env, broker, loanKeylet, loanAmount, verifyLoanStatus);
+                BEAST_EXPECT(state.flags == baseFlag);
                 env.close(state.startDate + 20s);
                 auto const loanAge = (env.now() - state.startDate).count();
                 BEAST_EXPECT(loanAge == 30);
@@ -2401,22 +2433,38 @@ protected:
                         interval};
                 BEAST_EXPECT(
                     accruedInterest ==
-                    broker.asset(Number(1141552511415525, -19)));
+                    broker.asset(loanAmount * Number(1141552511415525, -22)));
                 STAmount const prepaymentPenalty{
-                    broker.asset, state.principalOutstanding * Number(36, -3)};
-                BEAST_EXPECT(prepaymentPenalty == broker.asset(36));
-                STAmount const closePaymentFee = broker.asset(4);
+                    broker.asset,
+                    state.principalOutstanding *
+                        Number(36, interestExponent - 3)};
+                BEAST_EXPECT(
+                    prepaymentPenalty ==
+                    broker.asset(
+                        loanAmount * Number(36, interestExponent - 3)));
+                STAmount const closePaymentFee =
+                    broker.asset(loanAmount * Number(4, -3));
                 auto const payoffAmount = roundToScale(
                     principalOutstanding + accruedInterest + prepaymentPenalty +
                         closePaymentFee,
                     state.loanScale);
+                // TODO: Figure out what's wrong with this calculation
+                // STAmount{broker.asset, state.principalOutstanding} +
+                // accruedInterest + prepaymentPenalty + closePaymentFee;
                 BEAST_EXPECT(
                     payoffAmount ==
                     roundToAsset(
                         broker.asset,
-                        broker.asset(Number(1040000114155251, -12)).number(),
+                        broker.asset(loanAmount * Number(1040000114155251, -15))
+                            .number(),
                         state.loanScale));
 
+                // Try to pay a little extra to show that it's _not_
+                // taken
+                auto const transactionAmount =
+                    payoffAmount + broker.asset(loanAmount * Number(1, -2));
+                env(pay(borrower, loanKeylet.key, transactionAmount));
+
                 // The terms of this loan actually make the early payoff
                 // more expensive than just making payments
                 BEAST_EXPECT(
@@ -2600,8 +2648,8 @@ protected:
                 // toEndOfLife
                 //
                 // Draw and make multiple payments
-                auto state =
-                    getCurrentState(env, broker, loanKeylet, verifyLoanStatus);
+                auto state = getCurrentState(
+                    env, broker, loanKeylet, loanAmount, verifyLoanStatus);
                 BEAST_EXPECT(state.flags == 0);
                 env.close();
 
@@ -2713,6 +2761,21 @@ protected:
 
                 while (state.paymentRemaining > 0)
                 {
+                    // Try to pay a little extra to show that it's _not_
+                    // taken
+                    STAmount const transactionAmount =
+                        STAmount{broker.asset, totalDue} +
+                        broker.asset(loanAmount * Number(1, -2));
+                    // Only check the first payment since the rounding may
+                    // drift as payments are made
+                    BEAST_EXPECT(
+                        transactionAmount ==
+                        roundToScale(
+                            broker.asset(
+                                Number(9533457001162141, -14), Number::upward),
+                            state.loanScale,
+                            Number::upward));
+
                     // Compute the expected principal amount
                     auto const paymentComponents =
                         detail::computePaymentComponents(
@@ -2794,7 +2857,7 @@ protected:
                             Number::upward) ==
                             roundToScale(
                                 broker.asset(
-                                    Number(8333228695260180, -14),
+                                    loanAmount * Number(8333228695260180, -17),
                                     Number::upward),
                                 state.loanScale,
                                 Number::upward));
@@ -2906,6 +2969,10 @@ protected:
                     ter(tecNO_PERMISSION));
                 env(manage(lender, loanKeylet.key, tfLoanDefault),
                     ter(tecNO_PERMISSION));
+
+                // Can't make a payment on it either
+                env(pay(borrower, loanKeylet.key, broker.asset(loanAmount)),
+                    ter(tecKILLED));
             });
 
 #if LOANTODO
@@ -3648,19 +3715,23 @@ protected:
         // Create and update Loans
         for (auto const& broker : brokers)
         {
-            for (int amountExponent = 3; amountExponent >= 3; --amountExponent)
+            for (int amountMantissa : {1, 3, 7})
             {
-                Number const loanAmount{1, amountExponent};
-                for (int interestExponent = 0; interestExponent >= 0;
-                     --interestExponent)
+                for (int amountExponent = 3; amountExponent >= -5;
+                     amountExponent -= 4)
                 {
-                    testCaseWrapper(
-                        env,
-                        mptt,
-                        assets,
-                        broker,
-                        loanAmount,
-                        interestExponent);
+                    Number const loanAmount{amountMantissa, amountExponent};
+                    for (int interestExponent = 1 - 1; interestExponent >= -2;
+                         --interestExponent)
+                    {
+                        testCaseWrapper(
+                            env,
+                            mptt,
+                            assets,
+                            broker,
+                            loanAmount,
+                            interestExponent);
+                    }
                 }
             }