Apply suggestion from @xrplf-ai-reviewer[bot]

Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Merge branch 'develop' into ximinez/fix-getkeys
2026-06-18 08:06:51 +00:00 · 2026-06-17 15:20:48 -04:00 · 2026-06-17 15:19:55 -04:00 · 2026-06-17 13:06:40 -04:00
1 changed files with 10 additions and 2 deletions
--- a/include/xrpl/basics/TaggedCache.ipp
+++ b/include/xrpl/basics/TaggedCache.ipp
@@ -2,6 +2,7 @@

 #include <xrpl/basics/IntrusivePointer.ipp>
 #include <xrpl/basics/TaggedCache.h>
+#include <xrpl/basics/scope.h>

 namespace xrpl {

@@ -536,8 +537,15 @@ TaggedCache<Key, T, IsKeyCache, SharedWeakUnionPointer, SharedPointerType, Hash,
    std::vector<key_type> v;

    {
-        std::scoped_lock const lock(mutex_);
-        v.reserve(cache_.size());
+        std::unique_lock lock(mutex_);
+        for (auto size = cache_.size(); v.capacity() < size; size = cache_.size())
+        {
+            ScopeUnlock const unlock(lock);
+            v.reserve(size);
+        }
+        XRPL_ASSERT(lock.owns_lock(), "xrpl::TaggedCache::getKeys(): owns lock");
+        XRPL_ASSERT(
+            v.capacity() >= cache_.size(), "xrpl::TaggedCache::getKeys(): sufficient capacity");
        for (auto const& _ : cache_)
            v.push_back(_.first);
    }
Author	SHA1	Message	Date
Ed Hennis	054284701e	Apply suggestion from @xrplf-ai-reviewer[bot] Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>	2026-06-17 15:20:48 -04:00
Ed Hennis	eb4681da51	Merge branch 'develop' into ximinez/fix-getkeys	2026-06-17 15:19:55 -04:00
Ed Hennis	9b3dd7002d	fix: Allocate TaggedCache::getKeys() memory outside of lock - Uses a loop in case the size grows while the lock is free. Guarantees the result vector will not need to allocate under lock.	2026-06-17 13:06:40 -04:00