Simplify idSigner assignment logic

Refactor idSigner assignment to always calculate from pkSigner.
Remove unused variable in SignerEntries::deserialize
2026-03-21 12:12:34 +00:00 · 2026-03-20 20:09:15 -04:00 · 2026-03-20 15:33:14 -04:00
2 changed files with 1 additions and 4 deletions
--- a/src/libxrpl/tx/SignerEntries.cpp
+++ b/src/libxrpl/tx/SignerEntries.cpp
@@ -12,8 +12,6 @@ namespace xrpl {
 Expected<std::vector<SignerEntries::SignerEntry>, NotTEC>
 SignerEntries::deserialize(STObject const& obj, beast::Journal journal, std::string_view annotation)
 {
-    std::pair<std::vector<SignerEntry>, NotTEC> s;
-
    if (!obj.isFieldPresent(sfSignerEntries))
    {
        JLOG(journal.trace()) << "Malformed " << annotation << ": Need signer entry array.";
--- a/src/libxrpl/tx/Transactor.cpp
+++ b/src/libxrpl/tx/Transactor.cpp
@@ -674,8 +674,7 @@ Transactor::checkSign(
    }

    // Look up the account.
-    auto const idSigner =
-        pkSigner.empty() ? idAccount : calcAccountID(PublicKey(makeSlice(pkSigner)));
+    auto const idSigner = calcAccountID(PublicKey(makeSlice(pkSigner)));
    auto const sleAccount = view.read(keylet::account(idAccount));
    if (!sleAccount)
        return terNO_ACCOUNT;
Author	SHA1	Message	Date
Mayukha Vadari	7b1bb2a920	Simplify idSigner assignment logic Refactor idSigner assignment to always calculate from pkSigner.	2026-03-20 20:09:15 -04:00
Mayukha Vadari	9a44650a5a	Remove unused variable in SignerEntries::deserialize Removed unused variable 's' in deserialize function.	2026-03-20 15:33:14 -04:00