Pratik Mankawde
f86d5e408b
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-21 15:18:00 +01:00
Pratik Mankawde
a54fb9bf94
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-21 15:18:00 +01:00
Pratik Mankawde
82aeac5c0e
fix(core): include <string> for PerfLog's job hooks
...
jobQueue, jobStart and jobFinish take their name as std::string const&, so this
header has to provide <string> itself. The rpc hooks moved to string_view and
the include went with them, which include-cleaner reports as an error.
2026-09-21 15:17:51 +01:00
Pratik Mankawde
143538581c
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-21 12:52:31 +01:00
Pratik Mankawde
34b71571a0
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-21 12:52:23 +01:00
Pratik Mankawde
1bffe264f0
fix(test): follow PerfLog's rpc hooks to string_view
...
PerfLog takes the method name as a std::string_view, so SilentPerfLog's three
rpc overrides stopped overriding anything and left the class abstract.
2026-09-21 12:52:13 +01:00
Pratik Mankawde
5e398cd6b7
merge: bring develop forward into phase-9 metric gap fill
...
Resolved five files.
PerfLogImp.cpp: PerfLog now takes its method names as string_view, so the
methods map stores the map key rather than a char const*. Kept this branch's
scoped lock so the OTel recording still runs after methodsMutex is released,
and kept both the NetworkOPs and metric-macro includes.
PeerImp.h: took develop's earlier `protected:`, which also covers
processLedgerRequest, and kept recordGetObjectMetrics inside it. Dropped the
comment naming one test, since four test files now rely on that access.
TMGetObjectByHash_test.cpp: kept this branch's suite. It already runs develop's
three bound cases (limit+1, limit, limit-1) as testReplyLimit, plus the charge
and hit/miss cases. develop's extracted PeerTest.h stays, used by its four new
overlay tests.
ordering.txt: regenerated. Both perflog edges are real, to xrpl.server and to
xrpl.telemetry.
.cspell.config.yaml: kept both added words.
2026-09-21 12:51:31 +01:00
Pratik Mankawde
6174d03ce0
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-09-21 12:46:00 +01:00
Pratik Mankawde
05ce773671
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-09-21 12:45:59 +01:00
Pratik Mankawde
243913250b
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-09-21 12:45:59 +01:00
Pratik Mankawde
c8a8da6fd6
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-09-21 12:45:55 +01:00
Pratik Mankawde
e5d28ccbc4
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-09-21 12:45:54 +01:00
Pratik Mankawde
870367d71e
merge: bring develop forward into phase-3 tx tracing
...
Resolved src/libxrpl/tx/applySteps.cpp. calculateBaseFee now returns
std::expected<XRPAmount, TER>, so invokePreclaim rejects the transaction when
the fee cannot be computed. Kept that inside this branch's preclaimTer wrapper,
so the returned error also reaches the span's ter_result attribute.
2026-09-21 12:45:45 +01:00
Pratik Mankawde
c030880a36
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-09-21 12:44:43 +01:00
Pratik Mankawde
806473a9e9
fix(rpc): pass the command name to the span as a string_view
...
callMethod now takes its name as a std::string_view, which has no c_str().
setAttribute already accepts a string_view, so hand it the name directly.
2026-09-21 12:44:34 +01:00
Pratik Mankawde
d16f2c4181
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-09-21 12:43:48 +01:00
Pratik Mankawde
f48a2b4871
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-09-21 12:43:44 +01:00
Pratik Mankawde
e25c1a5920
Merge remote-tracking branch 'origin/develop' into pratik/otel-phase1a-plan-docs
2026-09-21 12:43:23 +01:00
Bart
f6b51f0b8b
ci: Say when a package publish is a dry run ( #8247 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-09-18 18:31:07 +00:00
Pratik Mankawde
a55f050df8
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-18 10:09:50 +01:00
Pratik Mankawde
ebf89186f3
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-18 10:09:50 +01:00
Pratik Mankawde
9d462dfcaf
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-09-18 10:09:50 +01:00
Pratik Mankawde
8fef4b3cc6
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-09-18 10:09:50 +01:00
Pratik Mankawde
8a5e831448
docs(telemetry): drop the suppressed row from the second attribute table
...
The same attribute was listed in two tables in this file. tx.receive does not
set it, because the span starts after the duplicate check.
2026-09-18 10:09:26 +01:00
Pratik Mankawde
80b737a41a
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-09-18 10:07:53 +01:00
Pratik Mankawde
3dc08bf4ce
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-09-18 10:07:53 +01:00
Pratik Mankawde
44447e341b
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-09-18 10:07:53 +01:00
Pratik Mankawde
e1cef947f6
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-18 10:07:53 +01:00
Pratik Mankawde
1ec6272192
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-18 10:07:53 +01:00
Pratik Mankawde
017e4bad42
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-09-18 10:07:53 +01:00
Pratik Mankawde
f1e62ba9f3
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-09-18 10:07:53 +01:00
Pratik Mankawde
7d1de4da1a
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-09-18 10:07:53 +01:00
Pratik Mankawde
49ce63c843
merge: bring the task-list span-placement wording forward from phase-2
...
Conflicted only on the two adjacent lines this branch had renamed from dotted
to bare attribute keys. Kept the bare keys, which are the convention the naming
check enforces.
2026-09-18 10:07:32 +01:00
Pratik Mankawde
2f61ce6851
docs(telemetry): match the task list to where the receive span now starts
...
The steps described setting a suppressed attribute on a dropped duplicate, in
the pre-rename dotted spelling. The span is now created after the duplicate
check, so there is no span on that path in either spelling.
2026-09-18 10:06:36 +01:00
Pratik Mankawde
cacaff70e0
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-18 10:05:22 +01:00
Pratik Mankawde
a397769ca0
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-18 10:05:21 +01:00
Pratik Mankawde
fca1ec15b8
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-09-18 10:05:21 +01:00
Pratik Mankawde
3d358f3605
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-09-18 10:05:21 +01:00
Pratik Mankawde
e8d6e82b39
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-09-18 10:05:05 +01:00
Pratik Mankawde
d0e4d13136
Merge branch 'pratik/otel-phase10-workload-validation' into pratik/otel-sync-diagnostics
2026-09-18 10:03:14 +01:00
Pratik Mankawde
f07beac0bb
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-18 10:03:14 +01:00
Pratik Mankawde
5945dd5f28
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-09-18 10:03:14 +01:00
Pratik Mankawde
95cc50d43f
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-09-18 10:03:14 +01:00
Pratik Mankawde
4e2b8ce536
merge: bring the plan-doc suppressed cleanup forward from phase-6
...
The attribute table conflicted because this branch had added the fee and
sequence rows and widened tx_type's set-on list. Kept those, and dropped the
suppressed row the incoming side removed.
2026-09-18 10:02:54 +01:00
Pratik Mankawde
91f783ea32
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-09-18 10:01:48 +01:00
Pratik Mankawde
633f6c98ab
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-09-18 10:01:48 +01:00
Pratik Mankawde
f05c09514b
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-09-18 10:01:48 +01:00
Pratik Mankawde
660535c4d8
merge: bring the plan-doc suppressed cleanup forward from phase-2
...
The acceptance table conflicted because this branch had added four criteria to
it. Kept them, and took the incoming HashRouter row.
2026-09-18 10:01:30 +01:00
Pratik Mankawde
2844277759
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-09-18 10:00:52 +01:00
Pratik Mankawde
bab53ef8d0
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-09-18 10:00:51 +01:00