Ed Hennis
f41b2c11d4
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-21 14:35:06 -05:00
Ed Hennis
66da6a8608
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-21 12:47:43 -05:00
Jingchen
fb74dc28e1
chore: Clean up comment in NetworkOps_test.cpp ( #6066 )
...
This change removes a copyright notice that was accidentally copied over from another file.
2025-11-21 17:11:00 +00:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Ayaz Salikhov
adbeb94c2b
ci: Only upload artifacts in XRPLF repo owner ( #6060 )
...
This change prevents uploading too many artifacts in non-public repositories.
2025-11-20 18:09:03 +00:00
Mayukha Vadari
a3d4be4eaf
fix: Set correct index for limit in book_offers CLI ( #6043 )
...
This change fixes an indexing typo in the `book_offers` CLI processing, and does not affect the HTTPS/WS RPC processing.
2025-11-20 06:37:28 -05:00
Ed Hennis
8a1f244682
Updated overpayment processing
...
- Added a test for RIPD-4125
2025-11-20 00:17:33 -05:00
Olek
6ff495fd9b
Fix: Perform array size check ( #6030 )
...
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
2025-11-19 16:58:18 +00:00
Ed Hennis
ae00ec7ac5
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-18 22:51:36 -05:00
Ed Hennis
bd0b651891
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-18 22:39:17 -05:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Ed Hennis
fd115cfc13
Address my review feedback on ( #6017 )
...
- Shortcut on issuer match in canTransfer.
- An asset can transfer if either trustline enabled rippling, so both
must have it disabled for the transfer to fail with terNO_RIPPLE.
- Remove unnecessary asfDefaultRipple sets in unit tests.
- Add a new unit test helper class: testline, and a macro: THISLINE.
When included as a parameter to Env::operator(), will include the line
number of the transaction that didn't get the expected result. Works
similarly to BEAST_EXPECT. I didn't do the same for the file name,
because that can be deduced from the testcase name.
2025-11-18 18:31:10 -05:00
Bronek Kozicki
d8b944c218
Enforce assets are transferable ( #6017 )
...
- Includes unit tests for terNO_RIPPLE.
- Switch auth mode to weak when submitter is destination.
- Require rippling enabled for vault deposits or withdrawals.
2025-11-18 18:28:59 -05:00
Mayukha Vadari
d9c27da529
refactor: split up RPCHelpers.h into two ( #6047 )
...
This PR splits `RPCHelpers.h` into two files, by moving out all the ledger-fetching-related functions into a separate file, `RPCLedgerHelpers.h`. It also moves `getAccountObjects` to `AccountObjects.h`, since it is only used in that one place.
2025-11-18 15:44:39 -05:00
Bart
3fb6acd29e
ci: Fix filtering out of Clang 20+ on ARM ( #6046 )
...
This change fixes the strategy matrix check to filter out the Clang 20+ on ARM, which still fail due to problems with Boost.
2025-11-17 21:54:13 +00:00
Bart
77b7cef5a7
ci: Use new Debian Trixie images ( #6034 )
...
This change uses the new Debian Trixie CI images added by XRPLF/ci#83 .
2025-11-17 19:31:19 +00:00
Jingchen
2c187461cc
refactor: Retire NegativeUNL amendment ( #6033 )
...
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
2025-11-17 14:02:10 +00:00
Vito Tumas
31d6ad727e
Refactors method and struct names ( #6039 )
...
- remove unused method
- rename computeFee to computeManagementFee
- rename calculateRounded to constructRounded
- remove redundancies in LoanDeltas struct
- rename PaymentComponentsPlus to ExtendedPaymentComponents
- additional logging
2025-11-15 08:48:38 +00:00
Ed Hennis
baa875db19
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-15 03:09:11 -05:00
Ed Hennis
cfdcaf3f8d
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-15 03:08:29 -05:00
Ayaz Salikhov
13a12c6402
chore: Update nudb recipe to remove linker warnings ( #6038 )
2025-11-14 20:27:28 +00:00
Ed Hennis
b9fdf9e564
Add the testPoC_UnsignedUnderflowOnFullPayAfterEarlyPeriodic
...
- Updated to reflect that the issue in RIPD-3971 has been resolved by
commit 4396b77c4b
2025-11-14 12:52:27 -05:00
Bronek Kozicki
362ecbd1cb
fix: Apply object reserve for Vault pseudo-account ( #5954 )
2025-11-14 17:30:56 +00:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
fc7350c487
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-13 14:45:53 -05:00
Ed Hennis
c65a311ad1
Remove a bunch of obsolete code, marked by "#if LOANCOMPLETE"
2025-11-13 14:26:47 -05:00
Ed Hennis
a868b1938d
Fix Vault test failure due to default field not being in RPC Json
2025-11-13 14:21:41 -05:00
Ed Hennis
ae497c14a0
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-13 12:20:53 -05:00
Ed Hennis
2f94838bbf
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-13 12:18:42 -05:00
Ed Hennis
1c1cd1a391
Change Vault asset fields back to default
...
- Was unintentionally rolled back with `Number` changes.
2025-11-13 12:15:39 -05:00
Vlad
f81d0d8c98
chore: Clean up incorrect comments ( #6031 )
...
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
2025-11-13 13:37:38 +00:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
bf0d8fc399
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-13 01:53:36 -05:00
Ed Hennis
ad124ce7b2
Fix balance checking assertion in LoanPay when issuer is borrower
...
- Resolves RIPD-4096
2025-11-13 01:51:07 -05:00
Ed Hennis
7ebee40951
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-12 20:12:30 -05:00
Ed Hennis
a4aa72eada
Fix revert issues
2025-11-12 19:19:06 -05:00
Ed Hennis
398170ef3d
Revert "Add optional enforcement of valid integer range to Number"
...
This reverts commit 3cb447a4fe .
2025-11-12 19:15:14 -05:00
Ed Hennis
9b0b7b5a91
Revert "Make all STNumber fields "soeDEFAULT""
...
This reverts commit 24f37d73f6 .
2025-11-12 19:15:07 -05:00
Ed Hennis
1b4e18a1a7
Revert "Add integer enforcement when converting to XRP/MPTAmount to Number"
...
This reverts commit b605a2cdcc .
2025-11-12 19:15:06 -05:00
Ed Hennis
814577758f
Revert "Fix build error - avoid copy"
...
This reverts commit cb6df196dc .
2025-11-12 19:15:03 -05:00
Ed Hennis
694abd1c79
Revert "Catch up the consequences of Number changes"
...
This reverts commit 0175dd70db .
2025-11-12 19:15:00 -05:00
Ed Hennis
2e34506835
Revert "Add a distinction between a "valid" and a "representable" Number"
...
This reverts commit 8e56af20ee .
2025-11-12 19:14:54 -05:00
Ed Hennis
b7ed35cb04
Fix merge issue: references to retired features
2025-11-12 16:34:41 -05:00
Ed Hennis
cee1e6a6ed
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-12 14:17:18 -05:00
Ed Hennis
8f772b9073
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66
...
* XRPLF/develop:
chore: Set version 3.1.0-b0 (5986)
ci: Clean workspace on Windows self-hosted runners (6024)
docs: fix spelling in comments (6002)
fix: floating point representation errors in vault (5997)
ci: Specify bash as the default shell in workflows (6021)
refactor: Add `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros (6014)
refactor: Retire DepositPreAuth and DepositAuth amendments (5978)
chore: Move running of unit tests out of coverage target (6018)
refactor: Retire PayChanRecipientOwnerDir amendment (5946)
2025-11-12 14:12:01 -05:00
Bronek Kozicki
8580a5795a
chore: Set version 3.1.0-b0 ( #5986 )
...
Technically b0 is not a release, so no "release" prefix here. It marks the point at which we moved the preceding release (3.0.0 in this case) from Beta to Release Candidate.
3.1.0-b0
2025-11-12 18:55:49 +00:00
Ed Hennis
ef66a1cc0e
Disable inner Batch transactions for Vault and Loan types
2025-11-12 13:51:57 -05:00
Bart
9b53bd9871
ci: Clean workspace on Windows self-hosted runners ( #6024 )
...
This change updates the `cleanup-workspace` action to its latest version, which added support for Windows.
2025-11-12 09:30:45 -05:00
hustrust
5fc07e3979
docs: fix spelling in comments ( #6002 )
2025-11-12 08:23:45 -05:00