Ed Hennis
eaaea43f80
Refactor Number internals away from int128 to uint64 & a sign flag
2025-11-27 01:47:31 -05:00
Ed Hennis
a87460b89f
Restore the original Number interface
...
- ctors and accessors return `rep`. Very few things expose
`internalrep`.
- An exception is "unchecked" and the new "normalized", which explicitly
take an internalrep. But with those special control flags, it's easier
to distinguish and control when they are used.
- The goal is to get as much of the non-number code back to the previous
state as possible.
2025-11-26 18:32:26 -05:00
Ed Hennis
59e6a8107a
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-24 21:49:58 -05:00
Bart
b550dc00ed
ci: Remove missing commits check ( #6077 )
...
This change removes the CI check for missing commits, as well as a stray path to the publish-docs workflow that isn't used in the on-trigger workflow.
2025-11-24 21:43:39 -05:00
Jingchen
21c02232a5
refactor: Retire RequireFullyCanonicalSig amendment ( #6035 )
...
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1
refactor: Retire DeletableAccounts amendment ( #6056 )
...
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
2025-11-24 11:52:08 +00:00
Jingchen
800a315383
refactor: Retire CryptoConditionsSuite amendment ( #6036 )
...
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
2025-11-24 06:23:16 -05:00
Olek
8449c6c365
Fix: nullptr resolving without db config ( #6029 )
...
If the config disables SQL db usage, such as a validator:
```
[ledger_tx_tables]
use_tx_tables = 0
```
then the pointer to DB engine is null, but it was still resolved during startup. Although it didn't crash in Release mode, possibly due to the compiler optimizing it away, it did crash in Debug mode. This change explicitly checks for the validity of the pointer and generates a runtime error if not set.
2025-11-21 22:20:45 +00:00
Vito Tumas
58e03190ac
docs: Improve VaultWithdraw documentation ( #6068 )
2025-11-21 16:59:12 -05:00
Ed Hennis
92388c4491
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-21 14:38:58 -05:00
Jingchen
fb74dc28e1
chore: Clean up comment in NetworkOps_test.cpp ( #6066 )
...
This change removes a copyright notice that was accidentally copied over from another file.
2025-11-21 17:11:00 +00:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Ayaz Salikhov
adbeb94c2b
ci: Only upload artifacts in XRPLF repo owner ( #6060 )
...
This change prevents uploading too many artifacts in non-public repositories.
2025-11-20 18:09:03 +00:00
Mayukha Vadari
a3d4be4eaf
fix: Set correct index for limit in book_offers CLI ( #6043 )
...
This change fixes an indexing typo in the `book_offers` CLI processing, and does not affect the HTTPS/WS RPC processing.
2025-11-20 06:37:28 -05:00
Olek
6ff495fd9b
Fix: Perform array size check ( #6030 )
...
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
2025-11-19 16:58:18 +00:00
Ed Hennis
e45d847558
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-18 22:51:51 -05:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Mayukha Vadari
d9c27da529
refactor: split up RPCHelpers.h into two ( #6047 )
...
This PR splits `RPCHelpers.h` into two files, by moving out all the ledger-fetching-related functions into a separate file, `RPCLedgerHelpers.h`. It also moves `getAccountObjects` to `AccountObjects.h`, since it is only used in that one place.
2025-11-18 15:44:39 -05:00
Bart
3fb6acd29e
ci: Fix filtering out of Clang 20+ on ARM ( #6046 )
...
This change fixes the strategy matrix check to filter out the Clang 20+ on ARM, which still fail due to problems with Boost.
2025-11-17 21:54:13 +00:00
Bart
77b7cef5a7
ci: Use new Debian Trixie images ( #6034 )
...
This change uses the new Debian Trixie CI images added by XRPLF/ci#83 .
2025-11-17 19:31:19 +00:00
Jingchen
2c187461cc
refactor: Retire NegativeUNL amendment ( #6033 )
...
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
2025-11-17 14:02:10 +00:00
Ed Hennis
546bfa89d8
For now, skip the larger mantissas in AMM transactions and tests
2025-11-16 20:59:17 -05:00
Ed Hennis
470c9c3936
Fix root2, and add tests for it
2025-11-16 00:18:51 -05:00
Ed Hennis
9f50cc033e
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-15 03:13:10 -05:00
Ed Hennis
a5f43fb59b
Fix some build errors - unused variables, large constants
2025-11-15 02:59:56 -05:00
Ed Hennis
3451d15e12
Step 3: Automatically switch precision in the transaction engine
...
- Default Number outside of transaction processing to be "large" so RPC
will work.
2025-11-15 02:55:48 -05:00
Ed Hennis
595a5ee220
Step 2.5cont: Make some updates to STNumber
...
- Added test cases min int64.
- Updated numberFromJson range checking to use the larger range
available from Number.
2025-11-15 00:50:59 -05:00
Ed Hennis
c9ad49faf3
Step 2.5: Run the STNumber tests using both mantissa sizes
...
- Nothing really needed to be changed in the tests, but I added a couple
of test cases for the min and max int64.
2025-11-14 19:41:26 -05:00
Ed Hennis
857eaffa55
refactor: Move the mantissa_scale enum into the MantissaRange struct
2025-11-14 19:06:44 -05:00
Ed Hennis
93109918ed
Fix Number::power(), and a bunch of Number unit tests
2025-11-14 18:51:01 -05:00
Ayaz Salikhov
13a12c6402
chore: Update nudb recipe to remove linker warnings ( #6038 )
2025-11-14 20:27:28 +00:00
Ed Hennis
fbcd4f33eb
Add more edge case Number tests
2025-11-14 15:10:10 -05:00
Ed Hennis
6f1fe5047b
Step 2 cont. Refactor the to_string(Number) test
2025-11-14 12:40:54 -05:00
Bronek Kozicki
362ecbd1cb
fix: Apply object reserve for Vault pseudo-account ( #5954 )
2025-11-14 17:30:56 +00:00
Ed Hennis
4cf22b50de
fixup! Step 2: Add the ability to change the mantissa range
...
- Fix cross-compiler build issues
2025-11-14 11:33:09 -05:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
606e3ec0b7
Step 2: Add the ability to change the mantissa range
...
- Update tests. Unfinished.
- TODO: Finish Number tests. Use both modes for STNumber tests. Move
mantissa_scale into MantissaRange.
2025-11-14 02:34:56 -05:00
Ed Hennis
2eca3dca89
Merge remote-tracking branch 'upstream/develop' into ximinez/lending-number-simple
...
* upstream/develop:
chore: Clean up incorrect comments (6031)
refactor: Retire MultiSignReserve and ExpandedSignerList amendments (5981)
2025-11-13 11:01:22 -05:00
Vlad
f81d0d8c98
chore: Clean up incorrect comments ( #6031 )
...
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
2025-11-13 13:37:38 +00:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
2881aade2c
Fix Vault unit tests for default fields with value 0.
...
- Field will be absent in RPC results instead of returning 0.
2025-11-13 01:53:36 -05:00
Ed Hennis
4abb6d9dfe
Turns out there's no to_string(__int128_t)
2025-11-13 00:51:37 -05:00
Ed Hennis
7cd48a7713
fixup! Continue with Step 1
2025-11-12 22:58:06 -05:00
Ed Hennis
d2d403da90
Continue with Step 1
...
- Track down and fix edge cases.
- Some refactoring and renaming for clarity and simplicity
2025-11-12 20:32:47 -05:00
Ed Hennis
343824332c
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-12 14:17:35 -05:00
Bronek Kozicki
8580a5795a
chore: Set version 3.1.0-b0 ( #5986 )
...
Technically b0 is not a release, so no "release" prefix here. It marks the point at which we moved the preceding release (3.0.0 in this case) from Beta to Release Candidate.
3.1.0-b0
2025-11-12 18:55:49 +00:00
Ed Hennis
a32b5723e5
fixup! fixup! Step 1: Convert Number to use 128-bit numbers internally
2025-11-12 12:16:18 -05:00
Ed Hennis
3048f55270
fixup! Step 1: Convert Number to use 128-bit numbers internally
2025-11-12 10:14:05 -05:00
Bart
9b53bd9871
ci: Clean workspace on Windows self-hosted runners ( #6024 )
...
This change updates the `cleanup-workspace` action to its latest version, which added support for Windows.
2025-11-12 09:30:45 -05:00