Vito Tumas
e9d9f1f8e9
Merge branch 'develop' into FN-36-credential_pins_pseudo_account
2026-08-13 22:05:45 +02:00
Pratik Mankawde
df85d43d8a
test: Make Drop50 message drop deterministic in LedgerReplayer test ( #7964 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-08-13 16:54:58 +00:00
Vito Tumas
0ab294ed96
Merge branch 'develop' into FN-36-credential_pins_pseudo_account
2026-08-13 10:25:12 +02:00
Jingchen
8e9b1791c5
feat: Add a new closed ended vault to extend SAV ( #7921 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-12 17:07:43 +00:00
Vito Tumas
91360c5126
test: Fix LoanBatch broker cover rates and schedule overflow ( #7967 )
2026-08-12 12:11:28 -04:00
Timur Yalymov
af36890c11
test: Verify private-vault DEX permissions survive domain loss ( #7937 )
2026-08-12 12:11:28 -04:00
Timur Yalymov
1281c7a222
refactor: Drop unnecessary associateAsset calls from loan delete paths ( #7986 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-12 12:10:17 -04:00
Copilot
153b7839a7
refactor: Replace boost::filesystem with std::filesystem across the codebase ( #7012 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: mathbunnyru <12270691+mathbunnyru@users.noreply.github.com >
2026-08-12 13:40:39 +00:00
Gregory Tsipenyuk
26cc683ec1
fix: Assorted MPT/DEX fixes ( #7299 )
...
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
2026-08-11 18:15:51 +00:00
Mayukha Vadari
6ca2fb84d4
refactor: Replace Boost trim and to_lower with libxrpl helpers ( #7995 )
2026-08-11 18:15:35 +00:00
klemenfn
a3147740f2
build: Fix GCC 14 compilation ( #7981 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-11 13:24:56 +00:00
luisfernandomendozav
d43e5acaa7
fix: Validate account/ident type in gateway_balances ( #7655 )
2026-08-11 13:23:07 +00:00
Alex Kremer
0a572833ea
chore: Gtest migration followups second pass ( #7888 )
2026-08-11 12:38:40 +00:00
Chenna Keshava B S
639943123c
fix: Validate buy/sell flag in nft RPC input ( #7725 )
2026-08-11 00:49:02 +00:00
Bryan
909cc5bba9
fix: Prevent silent zero AMM clawbacks due to integer MPT rounding ( #7704 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-08-10 21:37:53 +00:00
Peter Chen
6f5de9067a
chore: Mark unreachable branches in Confidential Transfer with UNREACHABLE ( #7903 )
2026-08-10 21:37:38 +00:00
Kassaking7
60291c3ed6
fix: Allow OverrideFreeze to bypass individual/deep freeze on AMM trust lines ( #6959 )
2026-08-10 21:34:28 +00:00
Braedon Klock
4173f7e499
fix: Validate account_lines peer field type ( #7728 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-10 21:30:06 +00:00
yinyiqian1
b19c3c64f2
fix: Add zero keylet check in credential ( #7971 )
2026-08-10 17:47:16 +00:00
Mayukha Vadari
a0e1e578a0
refactor: Remove operator!= overloads that C++20 synthesizes ( #7994 )
2026-08-10 17:23:02 +00:00
Mayukha Vadari
07aa97fda4
test: Use std::string::starts_with/ends_with instead of Boost ( #7992 )
2026-08-10 17:22:40 +00:00
Mayukha Vadari
4f8819565a
fix: Assorted cleanup fixes ( #7988 )
2026-08-10 17:18:22 +00:00
Mayukha Vadari
6580b200db
refactor: Replace boost::lexical_cast with existing alternatives ( #7991 )
2026-08-10 17:10:18 +00:00
Mayukha Vadari
71e972cbed
refactor: Act on TODOs that are unblocked by C++23 ( #7990 )
2026-08-10 17:05:18 +00:00
Timur Ialymov
c7c42559cc
fix: Include <string> directly in LoanBroker_test.cpp
...
The new overflow test calls std::to_string but only relied on a transitive
include for it, which clang-tidy's include-cleaner check flagged in CI.
2026-08-10 14:29:18 +01:00
Timur Ialymov
b604857da6
fix: Remove duplicate pseudo-account rejection from CredentialCreate
...
CredentialCreate::preclaim already rejects a pseudo-account Subject via a
separate amendment merged into develop while this branch was in review.
Drop the duplicate check added here and keep only the credential cleanup
this branch is actually for.
Adjust the Vault, LoanBroker, and AMM tests to build the pre-existing pin
with that other amendment disabled instead of this one, and drop the
now-redundant assertions that a new pin gets rejected -- that is covered
elsewhere now.
Add an overflow test for LoanBroker mirroring the existing Vault one,
exercising the tecINCOMPLETE branch a reviewer flagged as uncovered.
Fix an unrelated SeqProxy/namespace-rename mismatch in LoanBroker_test.cpp
introduced by the same develop merge, and rewrite comments across the
changed files to describe the rule rather than name the amendment or
ticket.
2026-08-10 13:22:33 +01:00
Timur Ialymov
9925144643
Merge remote-tracking branch 'origin/develop' into FN-36-credential_pins_pseudo_account
2026-08-10 12:45:15 +01:00
Gregory Tsipenyuk
94bccb3a5a
fix: Fix MPT/DEX Audit/Attackathon reports (Phase 2) ( #7537 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Andrzej Budzanowski <andrzej.budzanowski@neti-soft.com >
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-08-07 21:53:54 +00:00
Mayukha Vadari
0fb92c3194
refactor: Use SeqProxy instead of uint32 for all sequence-based keylets ( #7890 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-08-07 21:29:11 +00:00
Matt Van Horn
798e889ec4
fix: Deduplicate oracle entries in get_aggregate_price RPC ( #6586 )
...
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-08-07 20:24:45 +00:00
Timur Yalymov
abf5511d07
fix: Correct sign-check wording in lending protocol messages ( #7913 )
2026-08-07 19:41:23 +00:00
Ayaz Salikhov
a0e78b286f
chore: Bump version to 3.4.0-b0 ( #7976 )
2026-08-07 16:56:46 +00:00
Ayaz Salikhov
9859e5ceda
Merge remote-tracking branch 'upstream/release/3.3.x' into mathbunnyru/merge-3.3.0-to-develop
...
* upstream/release/3.3.x: (41 commits)
chore: Bump version to 3.3.0
chore: Bump version to 3.3.0-rc7
fix: Increase manifest protocol message size cap and fix manifests relay
fix: Cap untrusted manifests per message and drop oversized ones
chore: Bump version to 3.2.1
chore: Bump version to 3.2.1-rc1
fix: Cap untrusted manifests per message and drop oversized ones
fix: Reject oversized validator manifest before decoding
fix: Reduce untrusted manifest cache cap to 100
fix: Bound untrusted manifest cache
chore: Bump version to 3.3.0-rc6
feat: Package validator-keys inside rippled
chore: Bump version to 3.3.0-rc5
fix: Switch SponsorshipSet to use a delta for sfFeeAmount
fix: Re-revert "fix: Set request size limits and differential pricing for get-object-by-hash calls"
chore: Bump version to 3.3.0-rc4
fix: Revert "fix: Set request size limits and differential pricing for get-object-by-hash calls"
chore: Bump version to 3.3.0-rc3
fix: Reduce untrusted manifest cache cap to 100
fix: Revert "fix: Reject oversized SHAMap nodes in gotStaleData and fetch-pack path"
...
2026-08-07 16:00:25 +01:00
Ayaz Salikhov
00a178fb92
chore: Bump version to 3.3.0
2026-08-06 17:34:39 +01:00
Gregory Tsipenyuk
8d7524f03b
fix: Use consistent endianness serializing MPT STIssue sequence ( #7429 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: David Fuelling <sappenin@gmail.com >
2026-08-05 17:54:44 +00:00
Ayaz Salikhov
41d6bb5f73
build: Fix build on macOS 15 and Nix environment ( #7953 )
2026-08-04 23:27:23 +00:00
Bart
39c8c293b3
chore: Bump version to 3.3.0-rc7
2026-08-04 17:11:00 -04:00
Pratik Mankawde
54cfdda00b
fix: Increase manifest protocol message size cap and fix manifests relay
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-08-04 17:08:43 -04:00
Vito Tumas
c3ee602002
test: Split Loan_test.cpp into topical suites ( #7864 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-04 15:43:59 +00:00
Alex Kremer
06488c1318
chore: Rename CamelCase namespaces to snake_case ( #7933 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-04 13:46:55 +00:00
Timur Yalymov
765babb20d
fix: Add VaultInvariant check that lossUnrealized is non-negative ( #7863 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-03 21:11:33 +00:00
Braedon Klock
97f35add2e
fix: Add null check for account object reads ( #7717 )
...
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-08-03 21:08:42 +00:00
Pratik Mankawde
8461ded0d8
fix: Cap untrusted manifests per message and drop oversized ones
2026-08-03 12:00:11 -04:00
Timur Ialymov
fa6a96e6d8
fix: Reject credentials on pseudo-accounts and unpin Vault/LoanBroker (FN-36)
...
CredentialCreate accepted any existing Subject, including Vault, LoanBroker, and
AMM pseudo-accounts. A pseudo-account can't sign, so it can never accept or
delete a credential issued to it; the unaccepted credential stays pinned in the
pseudo-account's owner directory and blocks deletion of the owning object,
locking it and its owner reserve indefinitely.
Behind fixCleanup3_4_0:
- CredentialCreate::preclaim rejects a pseudo-account Subject with
tecPSEUDO_ACCOUNT.
- VaultDelete and LoanBrokerDelete remove any credentials pinned to the
pseudo-account before deleting it.
- isOnlyLiquidityProvider ignores credential entries and deleteAMMAccount removes
them, so an AMM pinned before the amendment can still be withdrawn and deleted.
This clears objects pinned before the amendment and prevents new pins after it.
2026-08-03 10:38:35 +01:00
Alex Kremer
ecdd457f35
chore: Gtest migration followups first pass ( #7884 )
2026-07-30 23:04:38 +00:00
Bart
4eece4003d
chore: Bump version to 3.3.0-rc6
2026-07-30 16:34:46 +01:00
Bart
21cd615407
perf: Replace node ID by depth in TMLedgerNode ( #6353 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-07-30 15:02:05 +00:00
Olek
3c0659d26b
test: Add confidential mpt bulletproof tests ( #7816 )
2026-07-30 12:18:33 +00:00
Copilot
532506541f
fix: Apply asfDisallowIncomingTrustline blocker to OfferCreate ( #6307 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-30 12:17:32 +00:00
Vito Tumas
8a5eded4f1
feat: Implement LoanBroker cash-basis accounting ( #7817 )
2026-07-30 11:55:39 +00:00