ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-19 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Make Drop50 message drop deterministic in LedgerReplayer test (#7964)

Browse Source 
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
This commit is contained in:
Pratik Mankawde
2026-08-13 16:54:58 +00:00
committed by GitHub
parent 8e9b1791c5
commit df85d43d8a
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/test/app/LedgerReplay_test.cpp
View File

@@ -28,7 +28,6 @@
#include <xrpl/basics/Slice.h>
#include <xrpl/basics/base_uint.h>
#include <xrpl/basics/random.h>
#include <xrpl/beast/net/IPAddress.h>
#include <xrpl/beast/net/IPEndpoint.h>
#include <xrpl/beast/unit_test/suite.h>
@@ -53,6 +52,7 @@
#include <xrpl.pb.h>
#include <algorithm>
#include <atomic>
#include <cassert>
#include <chrono>
#include <cstddef>
@@ -402,7 +402,7 @@ public:
enum class PeerSetBehavior {
Good,
Drop50,
DropAlternate,
DropAll,
DropSkipListReply,
DropLedgerDeltaReply,
@@ -445,17 +445,13 @@ struct TestPeerSet : public PeerSet
protocol::MessageType type,
std::shared_ptr<Peer> const& peer) override
{
int dropRate = 0;
if (behavior == PeerSetBehavior::Drop50)
{
dropRate = 50;
}
else if (behavior == PeerSetBehavior::DropAll)
{
dropRate = 100;
}
if (behavior == PeerSetBehavior::DropAll)
return;
if (randInt(1, 100) <= dropRate)
// Drop every other message deterministically. Alternating drops
// still exercise the timeout/retry path while guaranteeing every
// subtask eventually gets a reply.
if (behavior == PeerSetBehavior::DropAlternate && sendCount++ % 2 == 0)
return;
switch (type)
@@ -500,6 +496,7 @@ struct TestPeerSet : public PeerSet
LedgerReplayMsgHandler& remote;
std::shared_ptr<TestPeer> dummyPeer;
PeerSetBehavior behavior;
std::atomic<int> sendCount{0};
};
/**
@@ -1397,7 +1394,7 @@ struct LedgerReplayer_test : public beast::unit_test::Suite
case PeerSetBehavior::Good:
testcase("good network");
break;
case PeerSetBehavior::Drop50:
case PeerSetBehavior::DropAlternate:
testcase("network drops 50% messages");
break;
case PeerSetBehavior::Repeat:
@@ -1613,7 +1610,7 @@ struct LedgerReplayer_test : public beast::unit_test::Suite
testAllInboundLedgers(4);
testPeerSetBehavior(PeerSetBehavior::Good, 1);
testPeerSetBehavior(PeerSetBehavior::Good);
testPeerSetBehavior(PeerSetBehavior::Drop50);
testPeerSetBehavior(PeerSetBehavior::DropAlternate);
testPeerSetBehavior(PeerSetBehavior::Repeat);
testStop();
testSkipListBadReply();