Ed Hennis
4b48f9612b
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-04 20:25:05 -04:00
Ed Hennis
7bba34832b
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 20:25:02 -04:00
Ed Hennis
76ae61feb5
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 20:24:58 -04:00
Ed Hennis
adb260fe17
Review feedback from @dangell7 and @gregtatcam
...
- Mostly adding comments.
- Fixed some function parameter names that weren't updated after
a copy/paste.
- LoanBrokerCoverWithdraw does not need to check for freeze when sending
to the issuer.
- Reorder the fund transfer cases in LoanBrokerCoverWithdraw to make it
clearer that some transfers are direct, and some use the payment
engine.
- Only look up the vault ID once in LoanBrokerSet
2025-09-04 20:21:30 -04:00
Mayukha Vadari
6bf8338038
chore: Add conan.lock to workflow file checks ( #5769 )
...
* Add conan.lock to workflow file checks
* Add conan.lock to on-trigger.yml
2025-09-04 22:32:23 +00:00
Ed Hennis
8444a944af
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 16:44:10 -04:00
Ed Hennis
6d20e59212
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-04 16:44:03 -04:00
Ed Hennis
c49cf6cec6
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-04 16:43:59 -04:00
Ed Hennis
e24f034b17
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 16:43:56 -04:00
Ed Hennis
72733b57e4
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 16:43:52 -04:00
Ayaz Salikhov
b0f4174e47
chore: Use tooling provided by pre-commit ( #5753 )
2025-09-04 20:30:54 +00:00
Ed Hennis
7a78449f6d
Fix minor review feedback from @Bronek
...
- Clean up assert, log, and comments
2025-09-04 15:53:04 -04:00
Ayaz Salikhov
3865dde0b8
fix: Add missing info to notify-clio workflow ( #5761 )
...
* Add missing info to notify-clio workflow, as conan_ref
2025-09-04 19:26:57 +00:00
Ed Hennis
0d500343ed
New invariant privilege "mayDeleteMPT", used by VauleDeposit & Clawback
2025-09-04 14:08:54 -04:00
Ed Hennis
f15e88c009
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 13:15:41 -04:00
Ed Hennis
0069c0c5fa
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-04 13:15:35 -04:00
Ed Hennis
450d38293d
Remove unused variable
2025-09-04 13:14:19 -04:00
Ed Hennis
6d9001edac
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 12:37:00 -04:00
Ed Hennis
3dc14e7430
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
...
* XRPLF/ximinez/lending-refactoring-3:
ci: Use cleanup-workspace action (5763)
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:35:39 -04:00
Ed Hennis
9a8c2523ae
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
...
* XRPLF/ximinez/lending-refactoring-2:
ci: Use cleanup-workspace action (5763)
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:29:41 -04:00
Ed Hennis
115161f7d2
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 12:27:02 -04:00
Ed Hennis
77fcb9b9b3
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 12:26:58 -04:00
Ed Hennis
d2e8144c53
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-refactoring-1
...
* XRPLF/develop:
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:25:49 -04:00
Ayaz Salikhov
811c980821
ci: Use cleanup-workspace action ( #5763 )
...
* ci: Use cleanup-workspace action
* Use latest version
2025-09-04 16:27:30 +01:00
Bronek Kozicki
cf5f65b68e
Add Scale to SingleAssetVault ( #5652 )
...
* Add and Scale to VaultCreate
* Add round-trip calculation to VaultDeposit VaultWithdraw and VaultClawback
* Implement Number::truncate() for VaultClawback
* Add rounding to DepositWithdraw
* Disallow zero shares withdraw or deposit with tecPRECISION_LOSS
* Return tecPATH_DRY on overflow when converting shares/assets
* Remove empty shares MPToken in clawback or withdraw (except for vault owner)
* Implicitly create shares MPToken for vault owner in VaultCreate
* Review feedback: defensive checks in shares/assets calculations
---------
Co-authored-by: Ed Hennis <ed@ripple.com >
2025-09-04 08:54:24 +00:00
Ed Hennis
9d45fd1873
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-03 21:01:09 -04:00
Ed Hennis
4c43a0bca4
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-03 21:01:01 -04:00
Ed Hennis
bb491431bd
Review feedback from @dangell7 and @mvadari
...
- Rewrite isTesSuccess to use TERSubset::operator bool
- Add Transactor::preflightSigValidated for expensive operations that
should be done after signature validation. These things would have
been done after preflight2 before this refactor.
- Split Batch and EscrowFinish preflight to use preflightSigValidated, too.
2025-09-03 20:51:40 -04:00
Ed Hennis
f090434c2d
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-03 19:21:10 -04:00
Ed Hennis
5f7b4a5e13
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-03 19:21:00 -04:00
Ed Hennis
11b8f9978e
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-03 19:20:57 -04:00
Ed Hennis
58551da698
Review feedback from @dangell7 and @Bronek
...
- Added more `STParsedJSON` test cases.
- Add a `safe_cast` conversion in `parseUint32`.
2025-09-03 19:18:24 -04:00
Ed Hennis
5ade8756f6
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
...
* XRPLF/ximinez/lending-refactoring-4:
Review feedback from @Bronek
Rewrite Units.h and same safe_cast.h restrictions to use concepts
* Also add required support for LoanBroker and Loan ledger entries
2025-09-03 18:41:24 -04:00
Ed Hennis
ac4c4905df
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-03 18:10:26 -04:00
Ed Hennis
a5f1879afb
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-03 18:10:23 -04:00
Ed Hennis
8a77ac71ed
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-03 18:10:19 -04:00
Ed Hennis
a72c237373
Review feedback from @Bronek
...
- Remove unnecessary #include
- Explanatory comments
- Make the MPT InvariantCheck related to EscrowFinish amendment safe
- Convert SField maps to unordered_maps
- Make jtx::fee::operator() clearer
- Rename checkMyPrivilege to hasPrivilege
2025-09-03 18:04:05 -04:00
Ed Hennis
faae2514b9
Rewrite Units.h and same safe_cast.h restrictions to use concepts
2025-09-03 16:14:28 -04:00
Ed Hennis
bcbbf71f29
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-03 14:04:25 -04:00
Ed Hennis
12994d4251
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-03 14:04:15 -04:00
Ed Hennis
22679673f6
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-03 14:04:12 -04:00
Ed Hennis
a14cbf117c
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-03 14:04:08 -04:00
Ed Hennis
5ce07e769f
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-03 14:04:05 -04:00
Jingchen
c38f2a3f2e
Fix coverage parameter ( #5760 )
2025-09-03 16:08:02 +00:00
Ayaz Salikhov
724e9b1313
chore: Use conan lockfile ( #5751 )
...
* chore: Use conan lockfile
* Add windows-specific dependencies as well
* Add more info about lockfiles
* Update lockfile to latest version
* Update BUILD.md with conan install note
2025-09-03 10:24:07 +00:00
Bronek Kozicki
2e6f00aef2
Add required disable_ccache option ( #5756 )
2025-09-03 09:25:52 +01:00
Ed Hennis
08a5e8428a
Require all SFields to have a name
...
- From @bronek https://github.com/XRPLF/rippled/pull/5590#discussion_r2290589770
- Adds consistency, and ensures sfInvalid and sfGeneric are handled the
same as all other SFields
2025-08-29 20:11:28 -04:00
Ed Hennis
a8e35f8399
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-08-29 17:58:21 -04:00
Ed Hennis
1f85888ae8
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-08-29 15:53:07 -04:00
Ed Hennis
183450db46
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-08-29 15:53:04 -04:00
