- All current items are done
- Mostly comments
- Restructured PaymentParts (formerly PeriodicPaymentParts) to bring
along fees, and removed the computed / combined PeriodicPayment from
places that should be using PaymentParts instead.
* mywork/ximinez/lending-tx-fix:
fix: Transaction sig checking functions do not get a full context
ci: Upload artifacts during build and test in a separate job (5817)
- Fixes a bug introduced by PR #5594, commit 550f90a75e, which
introduced the concept of a "sigObject", in which the signature is
checked without necessarily being the transaction.
- Fortunately, no code uses the "sigObject" as anything other than the
transactor yet, so the bug is harmless for now.
- This fix removes the "PreclaimContext" from the parameter list, and
adds only the individual parts needed by the function, none of which
are the transaction.
* XRPLF/develop:
refactor: Add support for extra transaction signatures (5594)
refactor: Restructure Transactor::preflight to reduce boilerplate (5592)
* Restructures Transactor signature checking code to be able to handle a `sigObject`, which may be the full transaction, or may be an object field containing a separate signature. Either way, the `sigObject` can be a single- or multi-sign signature.
* Restructures `Transactor::preflight` to create several functions that will remove the need for error-prone boilerplate code in derived classes' implementations of `preflight`.
This change adds `STInt32` as a new `SType` under the `STInteger` umbrella, with `SType` value `12`. This is the first and only `STInteger` type that supports negative values.
This change adds more comprehensive tests for the `FeeVote` module, which previously only checked the basics, and not the more comprehensive flows in that class.
This change makes the regex in `HttpClient.cpp` that matches the content-length http header case insensitive to improve compatibility, as http headers are case insensitive.
This change raises logging severity from `INFO` to `WARN` when handling UNL manifest signed with an unexpected / invalid key. It also changes the internal error code for an invalid format of UNL manifest to `invalid` (from `untrusted`).
This is a follow up to problems experienced by an UNL node due to old manifest key configured in `validators.txt`, which would be easier to diagnose with improved logging.
It also replaces a log line with `UNREACHABLE` for an impossible situation when we match UNL manifest key against a configured key which has an invalid type (we cannot configure such a key because of checks when loading configured keys).
