Vito
d4f67f9647
Merge remote-tracking branch 'origin/develop' into tapanito/vault-zero-delta
2026-09-01 21:02:48 +02:00
Vito Tumas
7863ac8cf6
fix: Add 60s buffer before closed-ended vault redemption ( #8151 )
2026-09-01 18:27:05 +00:00
Vito
c68bacc8da
test: Describe XRP zero-withdraw SUCCESS as collapse-to-absence
...
The sponsored leftover-share case is the missing-recipient-delta arm after
economically-zero XRP is collapsed, not the present-delta ternary.
2026-09-01 18:30:15 +02:00
Vito
e7be3cde8e
test: Cover sponsored XRP zero-payout vault withdraw
...
MPT cases never record a destination delta. An XRP vault with a sponsored fee
touches the sender AccountRoot with no economic change, which is the path
ValidVault's zeroDeltaIsLegitimate disjunct is for.
2026-09-01 17:36:29 +02:00
Vito
ea08af56d4
Merge remote-tracking branch 'origin/develop' into tapanito/vault-zero-delta
...
# Conflicts:
# src/test/app/vault/VaultBugs_test.cpp
2026-09-01 17:18:59 +02:00
Vito
389eac40c7
test: Name boolean arguments at MPT zero-withdraw scenario calls
2026-09-01 17:02:58 +02:00
Vito
5e97b0ecfe
Merge remote-tracking branch 'origin/develop' into tapanito/vault-zero-delta
2026-09-01 16:48:17 +02:00
Vito Tumas
b3b38e4416
fix: Correct fee-payer XRP delta in ValidVault for sponsored VaultWithdraw ( #8141 )
2026-09-01 14:43:11 +00:00
Vito Tumas
ccd5dc5e06
fix: Keep LoanBrokerDelete valid for auth-required MPT cover ( #8144 )
2026-09-01 14:40:53 +00:00
Vito
07f51ca935
fix: Clarify zeroDeltaIsLegitimate comment for post-amendment withdraw
...
The old wording tied the backstop to pre-amendment empty holding insert, which doWithdraw no longer does once fixCleanup3_4_0 is on.
2026-09-01 16:14:34 +02:00
Vito Tumas
b2453b626e
fix: Unblock VaultSet and cash-basis LoanSet at AssetsMaximum ( #8143 )
2026-09-01 14:06:17 +00:00
Vito
cc698452e3
fix: Allow zero-value MPT vault withdraw when the asset holding is missing
...
A fully impaired pool can legitimately pay nothing for a share burn.
doWithdraw used to insert an empty self-destination MPToken for that
zero payout, which tripped ValidVault and ValidMPTIssuance.
2026-09-01 15:51:59 +02:00
Vito Tumas
de6e5d3a94
fix: Keep VaultDeposit share count after the assetsTotal clamp ( #8140 )
2026-09-01 13:51:39 +00:00
Copilot
fac20a06f3
refactor: Add common helper function for injected metadata fields in RPCs ( #5706 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-31 17:21:25 +00:00
Ayaz Salikhov
9a7c5ea593
chore: Bump version to 3.4.0-b3 ( #8132 )
2026-08-27 17:26:55 +00:00
Jingchen
7281e0606a
feat: Add vault invariants ( #7732 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-27 17:15:17 +00:00
Jingchen
71f5555873
feat: Remove pseudo account field filter ( #8042 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-27 13:52:23 +00:00
Vito Tumas
e0151229b6
fix: Waive unrealized-loss discount on sole-holder VaultClawback ( #8119 )
2026-08-27 08:15:38 +00:00
Gregory Tsipenyuk
dc3bd9cf00
fix: Fix MPT/DEX Audit/Attackathon reports (Phase 1) ( #7334 )
2026-08-26 18:09:46 +00:00
Vito Tumas
3c47af779c
fix: Clamp Vault Deposit, Withdraw, and Clawback to assetsTotal grid ( #8057 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-26 17:02:05 +00:00
Ayaz Salikhov
d83a84510e
chore: Bump version to 3.4.0-b2 ( #8120 )
2026-08-26 14:03:01 +00:00
Timur Yalymov
f8fba079fe
fix: Refuse a pseudo-account as the vault clawback holder ( #8111 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-26 13:55:04 +00:00
Vito Tumas
36c165f74d
fix: Prevent early loan impairment and due-date manipulation ( #6557 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
2026-08-26 13:38:24 +00:00
Peter Chen
f7ea645bf4
fix: AMMClawback exact LP token boundary ( #7373 )
2026-08-26 13:14:53 +00:00
Vito Tumas
421af6db79
fix: Reject open-ended vaults at LoanBrokerSet ( #8076 )
...
Co-authored-by: Kenny Lei <3003853+kennyzlei@users.noreply.github.com >
2026-08-26 00:08:25 +00:00
Vito Tumas
5e3d20b3ed
fix: Prevent vault clawback and withdraw overrun ( #8075 )
2026-08-25 17:59:37 +00:00
Vito Tumas
ec042fefee
fix: Absorb Vault invariant rounding noise ( #8055 )
2026-08-25 17:07:58 +00:00
Bart
0fdaf69e2c
chore: Bump version to 3.4.0-b1 ( #8102 )
2026-08-24 20:41:58 +00:00
Timur Yalymov
9d41b1bd1c
fix: Exempt vault and loan broker accounts from IOU authorization ( #8013 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-24 16:23:43 +00:00
Jingchen
f137d71510
test: Split Invariants_test.cpp into per-topic files ( #8077 )
2026-08-24 16:17:33 +00:00
Bart
8bc6e81c5f
fix: Reject an inner node claimed at leaf depth in verifyProofPath ( #7940 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com >
2026-08-24 16:17:12 +00:00
Ed Hennis
764cbe7c29
perf: Pause online delete if there any gaps in recent ledger history ( #5531 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-24 14:16:03 +00:00
Timur Yalymov
520650081b
fix: Remove credentials pinned to Vault, LoanBroker, and AMM pseudo-accounts ( #7877 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-24 13:06:44 +00:00
Timur Yalymov
a097ccebae
fix: Tighten destination checks on vault withdrawal ( #7977 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-24 12:50:57 +00:00
Mayukha Vadari
fe4ccdf750
fix: Add assert for account_info flags ( #7987 )
2026-08-21 15:20:44 +00:00
Timur Yalymov
046d4dd4af
fix: Reject vault deposits that move nothing from the depositor ( #8014 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-21 12:30:17 +00:00
Ed Hennis
d27beef500
perf: Speed up addition time for drastically different exponents ( #7825 )
2026-08-20 19:40:42 +00:00
Mayukha Vadari
85512541ad
refactor: Collapse transactions.macro settings into a TxSettings struct ( #8001 )
...
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-20 19:25:27 +00:00
Gregory Tsipenyuk
3ab5288ef2
fix: Enforce MPT balance invariants under the latest cleanup amendment ( #7889 )
2026-08-20 19:05:28 +00:00
Kassaking7
d0dbf9163c
fix: Prevent AMM auction slots from being acquired at zero cost when trading fee is zero ( #7430 )
2026-08-20 19:04:04 +00:00
Timur Yalymov
cc76708563
fix: Return specific and consistent errors from vault_info ( #8015 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-20 16:05:18 +00:00
Shawn Xie
e3ba569187
fix: Check credential for LoanBrokerCoverWithdraw and VaultWithdraw ( #7107 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-20 15:33:46 +00:00
Sergey Kuznetsov
f370289733
chore: Rust-C++ cmake and CI integration ( #7034 )
2026-08-19 14:30:06 +00:00
Vito Tumas
d1dc7a6ccf
refactor: Extract invariant invocation into free checkInvariants runner ( #7404 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-19 14:10:11 +00:00
Timur Yalymov
368ff1afce
fix: Exempt loan default from asset freeze ( #7932 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-19 13:43:40 +00:00
Vito Tumas
3adf2d40b5
fix: Reject VaultWithdraw fixed-share amounts that round to zero ( #7950 )
2026-08-19 13:09:38 +00:00
Olek
7442ff2dec
fix: Enable reserve checking on ending sponsorship ( #8044 )
2026-08-18 22:39:32 +00:00
Kassaking7
666e77b22c
fix: Add ValidPermissionedDEX invariant track for fully consumed offer ( #6736 )
2026-08-18 21:08:02 +00:00
Vito Tumas
8c12de6c56
test: Split Vault_test into topical suites under src/test/app/vault/ ( #8041 )
2026-08-18 17:57:12 +00:00
Shawn Xie
b21fd86f6e
fix: Fix assorted NFT and pDEX bugs ( #7749 )
2026-08-18 17:56:33 +00:00