Ed Hennis
cd726f96d4
Merge remote-tracking branch 'upstream/develop' into vault
...
* upstream/develop:
refactor(trivial): reorganize ledger entry tests and helper functions (5376)
2025-04-09 18:22:48 -04:00
Mayukha Vadari
e429455f4d
refactor(trivial): reorganize ledger entry tests and helper functions ( #5376 )
...
This PR splits out `ledger_entry` tests into its own file (`LedgerEntry_test.cpp`) and alphabetizes the helper functions in `LedgerEntry.cpp`. These commits were split out of #5237 to make that PR a little more manageable, since these basic trivial changes are most of the diff. There is no code change, just moving code around.
2025-04-09 17:02:03 +00:00
Ed Hennis
870f42e5f7
Merge branch 'develop' into vault
2025-04-09 12:33:23 -04:00
Ed Hennis
780d05ec97
Clang wants an explicit ctor to emplace in a vector
2025-04-09 12:32:18 -04:00
Vito Tumas
7692eeb9a0
Instrument proposal, validation and transaction messages ( #5348 )
...
Adds metric counters for the following P2P message types:
* Untrusted proposal and validation messages
* Duplicate proposal, validation and transaction messages
2025-04-09 15:33:17 +02:00
Bronek Kozicki
a099f5a804
Remove UNREACHABLE from NetworkOPsImp::processTrustedProposal ( #5387 )
...
It’s possible for this to happen legitimately if a set of peers, including a validator, are connected in a cycle, and the latency and message processing time between those peers is significantly less than the latency between the validator and the last peer. It’s unlikely in the real world, but obviously easy to simulate with Antithesis.
2025-04-08 14:43:34 +00:00
Bronek Kozicki
f839049de7
Enforce max recursion depth in VaultCreate, improve VaultDeposit checks
...
Also fix off-by-one error in recursive checks isFrozen and requireAuth
2025-04-07 21:19:06 +01:00
Bronek Kozicki
5f051c53f1
Merge branch 'develop' into vault
2025-04-07 15:39:24 +01:00
Bronek Kozicki
db19760ee8
Both isFrozen and requireAuth are now recursive for vault shares
2025-04-07 15:37:50 +01:00
Bronek Kozicki
9c967f83be
Disallow deleting locked MPToken
2025-04-07 13:01:02 +01:00
Bronek Kozicki
442795bfeb
Change vault_info to take vault_id or owner&seq
2025-04-07 11:29:55 +01:00
Michael Legleux
ca0bc767fe
fix: Use the build image from ghcr.io ( #5390 )
...
The ci pipelines are constantly hitting Docker Hub's public rate limiting since increasing the number of jobs we're running. This change switches over to images hosted in GitHub's registry.
2025-04-05 02:24:31 +00:00
Mayukha Vadari
4ba9288935
fix: disable channel_authorize when signing_support is disabled ( #5385 )
2025-04-05 01:08:34 +00:00
Valentin Balaschenko
e923ec6d36
Fix to correct memory ordering for compare_exchange_weak and wait in the intrusive reference counting logic ( #5381 )
...
This change addresses a memory ordering assertion failure observed on one of the Windows test machines during the IntrusiveShared_test suite.
2025-04-04 18:21:17 +00:00
Bronek Kozicki
e1e8859137
Add // LCOV_EXCL_LINE with UNREACHABLE
2025-04-04 18:14:52 +01:00
Vlad
851d99d99e
fix: uint128 ambiguousness breaking macos unity build ( #5386 )
2025-04-04 08:28:33 -04:00
Bronek Kozicki
1494ae38e1
Fix VaultDeposit::preclaim checks
2025-04-04 12:36:05 +01:00
Bronek Kozicki
8f9524b5af
Enforce lsfDefaultRipple flag in addEmptyHolding
2025-04-03 19:43:12 +01:00
Bronek Kozicki
676ed9ad04
Return ter code from dirLink
2025-04-03 19:33:38 +01:00
Bronek Kozicki
f6a9b4f5b1
Remove unnecessary include
2025-04-03 19:30:24 +01:00
Bronek Kozicki
2737249500
Merge branch 'develop' into vault
2025-04-03 14:30:42 +01:00
Bronek Kozicki
591437b914
Mark featureSingleAssetVault as Supported::no
2025-04-03 14:13:21 +01:00
Bronek Kozicki
af8ea3fb40
Rename 'share' to 'shares' in vault_info RPC
2025-04-03 11:45:47 +01:00
Bronek Kozicki
6f4e7e8e44
Move isPseudoAccount near createPseudoAccount
2025-04-03 11:35:46 +01:00
Bronek Kozicki
392e3846ed
Change error code to tecLOCKED
2025-04-03 11:33:17 +01:00
Bronek Kozicki
85e7d293ca
Factor out isPseudoAccount
2025-04-02 19:29:04 +01:00
Bronek Kozicki
dbbf6829b9
Gate VaultCreate on featureMPTokensV1
2025-04-02 17:11:49 +01:00
Bronek Kozicki
5f53e4d1f8
Change output structure of vault_info
2025-04-02 17:09:49 +01:00
Bronek Kozicki
fa0b021fb8
Add RPC vault_info, remove RPC::supplementJson<ltVAULT>
2025-04-02 16:40:37 +01:00
Bronek Kozicki
09833abd46
Improve checks in VaultWithdraw, more tests
2025-04-02 12:10:22 +01:00
Bronek Kozicki
dc249b8b6d
Add unit tests
2025-04-01 19:06:45 +01:00
Bart
f608e653ca
Fix undefined uint128_t type on Windows non-unity builds ( #5377 )
...
As part of import optimization, a transitive include had been removed that defined `BOOST_COMP_MSVC` on Windows. In unity builds, this definition was pulled in, but in non-unity builds it was not - causing a compilation error. An inspection of the Boost code revealed that we can just gate the statements by `_MS_VER` instead. A `#pragma message` is added to verify that the statement is only printed on Windows builds.
2025-04-01 11:21:59 -04:00
Bronek Kozicki
ad6e048ab2
Bring back addEmptyHolding and removeEmptyHolding to View
2025-04-01 13:51:47 +01:00
Bronek Kozicki
2b86a1a557
Enforce Destination checks on VaultWithdraw
2025-04-01 13:51:43 +01:00
Bronek Kozicki
93bd26547f
Move addEmptyHolding to VaultCreate and removeEmptyHolding to VaultDelete
2025-03-31 18:20:31 +01:00
Bronek Kozicki
b6c74303c1
Add nullptr checks
2025-03-31 16:53:58 +01:00
Bronek Kozicki
a1c21a06bc
Rename sfMPTokenIssuanceID in Vault to sfShareMPTID
2025-03-31 16:40:46 +01:00
Bronek Kozicki
b67d8e676b
Add more comments on usage of enforceMPTokenAuthorization
2025-03-31 16:26:30 +01:00
Bronek Kozicki
83582b6731
Add RPC unit test
2025-03-31 15:13:58 +01:00
Bronek Kozicki
124512eba9
Add terADDRESS_COLLISION to AMMCreate::preclaim
2025-03-28 21:56:56 +00:00
Bronek Kozicki
1807b441ee
Fix bug in pseudoAccountAddress and add unit test
2025-03-28 21:03:49 +00:00
Bronek Kozicki
d3c1d02c72
Return terADDRESS_COLLISION from preclaim if cannot allocate AccountID
2025-03-28 19:49:37 +00:00
Bronek Kozicki
f77ad36283
Merge branch 'develop' into vault
2025-03-28 17:06:06 +00:00
Bronek Kozicki
aff08b7543
Add invariant checks for pseudo-account
2025-03-28 17:04:38 +00:00
Bronek Kozicki
696cf2b563
Merge branch 'develop' into vault
2025-03-28 17:03:15 +00:00
Vlad
72e076b694
test: enable compile time param to change reference fee value ( #5159 )
...
Adds an extra CI pipeline to perform unit tests using different values for fees.
2025-03-27 23:40:36 +00:00
Bronek Kozicki
abaf213336
Fix clang, minor refactor of createPseudoAccount
2025-03-27 19:29:41 +00:00
Bart
6cf37c4abe
refactor: Move integration tests from 'examples/' into 'tests/' ( #5367 )
...
This change moves `examples/example` into `tests/conan` to make it clear it is an integration test, and adjusts the `conan` CI job accordingly
2025-03-27 14:49:09 +00:00
Bronek Kozicki
0f99955ae9
Merge branch 'develop' into vault
2025-03-27 13:07:02 +00:00
Bronek Kozicki
7686c3d88d
Rename ShareTotal to SharesTotal
2025-03-27 11:50:03 +00:00
