Ed Hennis
cc4c06cf86
Address AI review feedback: mantissa assertion, test resiliency
...
- Move code around and add comments in `bringIntoRange` to make it
clearer that mantissas should not be 0, but fall back gracefully in
non-debug builds if they are.
- Make a test that checks for Large330 future-proof if more scales are
added later.
2026-06-25 14:26:59 -04:00
Ed Hennis
6906f47349
Apply suggestions from AI code review: typos
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-25 14:25:32 -04:00
Ed Hennis
d2c5d95032
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-25 11:43:34 -04:00
Ed Hennis
6aa9031848
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-25 11:43:30 -04:00
Ayaz Salikhov
07c64f07f0
chore: Revert "build: Switch to a new conan XRPLF remote ( #7622 )" ( #7623 )
2026-06-25 14:47:55 +00:00
Ayaz Salikhov
3097c157b6
build: Switch to a new conan XRPLF remote ( #7622 )
2026-06-25 08:40:06 -04:00
Michael Legleux
556d62a0de
build: Align xrpld RPM packaging with DEB package ( #7529 )
2026-06-24 23:53:46 +00:00
Ayaz Salikhov
eef8f4a4ff
chore: Use clang-tidy v22 new features ( #7427 )
2026-06-24 17:23:29 +00:00
Ayaz Salikhov
4fec58251b
build: Patch nix binaries in CMake ( #7539 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-24 13:56:18 +00:00
Ayaz Salikhov
8bbbc2051e
chore: Check more tools to be available ( #7600 )
2026-06-24 12:25:03 +00:00
Mayukha Vadari
6736ab39df
test: Add test for Permissioned Domain sequence fix ( #7591 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-24 12:24:27 +00:00
Ayaz Salikhov
b68e1f7170
fix: Add pragma once checker ( #7580 )
2026-06-24 12:24:04 +00:00
Timothy Banks
bb7c4d1c9f
fix: Additional RPC validation checks on ammRpcInfo account and amm_account fields. ( #7324 )
2026-06-24 12:23:12 +00:00
Zhiyuan Wang
69d289a388
fix: AMM Quality Leak into Domain BookStep for Permissioned DEX ( #6853 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-24 12:15:45 +00:00
Jingchen
6341e75200
refactor: Refactor TaggedCache.ipp to remove const_cast in canonicalize_replace_cache ( #5638 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-24 12:15:11 +00:00
yinyiqian1
5a2c82f699
fix: Reject delegate permission to pseudo accounts ( #7597 )
2026-06-23 19:55:23 +00:00
Jingchen
0b22050b5e
ci: Update workflows and conan to use VS2026 and grpc 1.81.0 ( #7550 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-06-23 19:25:38 +00:00
Ed Hennis
817f541c69
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-23 11:10:04 -04:00
Ed Hennis
e090083dc7
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-23 11:09:59 -04:00
Bart
ff02269c0d
refactor: Use dispatch instead of post ( #7438 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-22 22:35:28 +00:00
Ed Hennis
f3849fc2d2
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-22 16:42:02 -04:00
Ed Hennis
2c074d03c7
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-22 16:41:58 -04:00
Mayukha Vadari
dd7401fde2
refactor: Clean up tec object deletion logic ( #6588 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-22 18:44:42 +00:00
Zhiyuan Wang
19a9ed7767
fix: Move AMMInvariant weakInvariantCheck logic into the transaction ( #7032 )
2026-06-22 18:42:57 +00:00
Zhiyuan Wang
93eab33dc2
fix: Improve ValidAMM invariant ( #7295 )
2026-06-22 17:45:42 +00:00
yinyiqian1
997267f845
feat: Remove clear mutable flags for DynamicMPT XLS-94 ( #7439 )
2026-06-22 17:36:06 +00:00
Ayaz Salikhov
e29b523620
ci: Build and push docker images in forks too ( #7588 )
2026-06-22 17:00:40 +00:00
Ed Hennis
08736639c5
Restore an incorrectly removed const
2026-06-22 11:33:41 -04:00
dependabot[bot]
b1f794f067
ci: [DEPENDABOT] bump actions/checkout from 6.0.3 to 7.0.0 ( #7585 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-22 13:39:38 +00:00
Ed Hennis
aadf3c66c9
Remove some overly verbose unit test log messages.
2026-06-18 21:05:03 -04:00
Ed Hennis
7cb224e50f
Update some comments, and const correctness
2026-06-18 20:59:20 -04:00
Ed Hennis
4124a1dd2d
Revert "Remove changes to Number.cpp"
...
This reverts commit 8250aa2375 .
2026-06-18 20:16:39 -04:00
Ed Hennis
8250aa2375
Remove changes to Number.cpp
...
- Show that old behavior is not affected, and that the new tests fail
without them.
2026-06-18 20:15:19 -04:00
Ed Hennis
da396070ce
Address review feedback from @TimothyBanks and @gregtatcam
...
- Remove unnecessary if constexpr check
- Update scaling static_assert
- Remove unnecessary rounding logic from Number::Guard::doRound()
- Handle fractional rounding between kMaxRep and kMaxRepUp
2026-06-18 17:57:21 -04:00
Michael Legleux
b6a1ad5bb3
fix: Ensure xrpld service directories exist at startup ( #7565 )
2026-06-18 19:21:12 +00:00
Ed Hennis
6179b054c9
Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
...
* XRPLF/ximinez/number-round-maxrep-down:
clang-tidy: Remove unused header
2026-06-18 13:18:07 -04:00
Ed Hennis
d373cb5db8
clang-tidy: Remove unused header
2026-06-18 13:16:16 -04:00
Ed Hennis
39d85076c4
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 21:50:55 -04:00
Ed Hennis
14a43cfc35
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 21:46:24 -04:00
Ed Hennis
6504042b8d
Review feedback from @TimothyBanks and @gregtatcam
...
- Get rid of MantissaRange::getRanges() function. Rewrite
getMantissaScale to use all constexpr values.
- In Number::Guard::round(), document the "intentional" shadowing of
"mode", and simplify one of the checks. Add an assert.
2026-06-17 21:45:56 -04:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
Ed Hennis
069fc99b6a
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 15:01:40 -04:00
Ed Hennis
cebd4ecf15
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 15:01:35 -04:00
solunolab
480676d0bf
docs: Fix some comments to improve readability ( #7405 )
...
Signed-off-by: solunolab <solunolab@outlook.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-06-17 13:55:00 +00:00
Michael Legleux
f07de6c454
ci: Disable assertions on Release builds ( #7443 )
2026-06-17 13:54:55 +00:00
Ayaz Salikhov
cb2642be05
build: Add graphviz to Nix images ( #7566 )
2026-06-17 13:54:46 +00:00
Pratik Mankawde
7e0ff536f5
refactor: Rerevert "Explicitly trim the heap after cache sweeps ( #6022 )"
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 13:31:43 +01:00
Pratik Mankawde
044ca7719d
release: Bump version to 3.3.0-b0
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:58:01 +01:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Ayaz Salikhov
5de434436e
ci: Make clang-tidy workflow adjustments to stay in sync with Clio ( #7563 )
2026-06-17 10:02:17 +00:00