Ed Hennis
b2b079b546
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-25 14:55:28 -05:00
Ed Hennis
f1490df960
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-25 14:54:38 -05:00
Jingchen
b124c9f7e3
refactor: Retire Flow and FlowSortStrands amendments ( #6054 )
...
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
2025-11-25 14:21:17 +00:00
Ed Hennis
5926b4bf57
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-24 21:49:30 -05:00
Ed Hennis
7bdf74de98
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-24 21:48:42 -05:00
Bart
b550dc00ed
ci: Remove missing commits check ( #6077 )
...
This change removes the CI check for missing commits, as well as a stray path to the publish-docs workflow that isn't used in the on-trigger workflow.
2025-11-24 21:43:39 -05:00
Ed Hennis
81300afd19
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-24 21:30:42 -05:00
Ed Hennis
1743d6fb98
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-24 21:29:52 -05:00
Jingchen
21c02232a5
refactor: Retire RequireFullyCanonicalSig amendment ( #6035 )
...
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1
refactor: Retire DeletableAccounts amendment ( #6056 )
...
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
2025-11-24 11:52:08 +00:00
Jingchen
800a315383
refactor: Retire CryptoConditionsSuite amendment ( #6036 )
...
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
2025-11-24 06:23:16 -05:00
Olek
8449c6c365
Fix: nullptr resolving without db config ( #6029 )
...
If the config disables SQL db usage, such as a validator:
```
[ledger_tx_tables]
use_tx_tables = 0
```
then the pointer to DB engine is null, but it was still resolved during startup. Although it didn't crash in Release mode, possibly due to the compiler optimizing it away, it did crash in Debug mode. This change explicitly checks for the validity of the pointer and generates a runtime error if not set.
2025-11-21 22:20:45 +00:00
Vito Tumas
58e03190ac
docs: Improve VaultWithdraw documentation ( #6068 )
2025-11-21 16:59:12 -05:00
Ed Hennis
879d054eed
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-21 14:34:53 -05:00
Ed Hennis
ca7a5bb926
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-21 12:47:28 -05:00
Jingchen
fb74dc28e1
chore: Clean up comment in NetworkOps_test.cpp ( #6066 )
...
This change removes a copyright notice that was accidentally copied over from another file.
2025-11-21 17:11:00 +00:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Ayaz Salikhov
adbeb94c2b
ci: Only upload artifacts in XRPLF repo owner ( #6060 )
...
This change prevents uploading too many artifacts in non-public repositories.
2025-11-20 18:09:03 +00:00
Mayukha Vadari
a3d4be4eaf
fix: Set correct index for limit in book_offers CLI ( #6043 )
...
This change fixes an indexing typo in the `book_offers` CLI processing, and does not affect the HTTPS/WS RPC processing.
2025-11-20 06:37:28 -05:00
Olek
6ff495fd9b
Fix: Perform array size check ( #6030 )
...
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
2025-11-19 16:58:18 +00:00
Ed Hennis
f2ee3b9f49
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-18 22:51:25 -05:00
Ed Hennis
ce8b1a3f1e
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-18 22:39:06 -05:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Mayukha Vadari
d9c27da529
refactor: split up RPCHelpers.h into two ( #6047 )
...
This PR splits `RPCHelpers.h` into two files, by moving out all the ledger-fetching-related functions into a separate file, `RPCLedgerHelpers.h`. It also moves `getAccountObjects` to `AccountObjects.h`, since it is only used in that one place.
2025-11-18 15:44:39 -05:00
Bart
3fb6acd29e
ci: Fix filtering out of Clang 20+ on ARM ( #6046 )
...
This change fixes the strategy matrix check to filter out the Clang 20+ on ARM, which still fail due to problems with Boost.
2025-11-17 21:54:13 +00:00
Bart
77b7cef5a7
ci: Use new Debian Trixie images ( #6034 )
...
This change uses the new Debian Trixie CI images added by XRPLF/ci#83 .
2025-11-17 19:31:19 +00:00
Jingchen
2c187461cc
refactor: Retire NegativeUNL amendment ( #6033 )
...
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
2025-11-17 14:02:10 +00:00
Ed Hennis
b72cf3d7d9
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-15 03:09:00 -05:00
Ed Hennis
486fa75a10
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-15 03:08:18 -05:00
Ayaz Salikhov
13a12c6402
chore: Update nudb recipe to remove linker warnings ( #6038 )
2025-11-14 20:27:28 +00:00
Bronek Kozicki
362ecbd1cb
fix: Apply object reserve for Vault pseudo-account ( #5954 )
2025-11-14 17:30:56 +00:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
2017304c71
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-13 12:20:18 -05:00
Ed Hennis
f8d68cd3d3
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-13 12:18:08 -05:00
Vlad
f81d0d8c98
chore: Clean up incorrect comments ( #6031 )
...
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
2025-11-13 13:37:38 +00:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
bb71c62fca
Merge branch 'ximinez/online-delete-gaps' into ximinez/online-delete-lastrotated
2025-11-12 14:17:06 -05:00
Ed Hennis
ef7a3f5606
Merge branch 'develop' into ximinez/online-delete-gaps
2025-11-12 13:59:45 -05:00
Bronek Kozicki
8580a5795a
chore: Set version 3.1.0-b0 ( #5986 )
...
Technically b0 is not a release, so no "release" prefix here. It marks the point at which we moved the preceding release (3.0.0 in this case) from Beta to Release Candidate.
3.1.0-b0
2025-11-12 18:55:49 +00:00
Bart
9b53bd9871
ci: Clean workspace on Windows self-hosted runners ( #6024 )
...
This change updates the `cleanup-workspace` action to its latest version, which added support for Windows.
2025-11-12 09:30:45 -05:00
hustrust
5fc07e3979
docs: fix spelling in comments ( #6002 )
2025-11-12 08:23:45 -05:00
Bronek Kozicki
2ebc2ca885
fix: floating point representation errors in vault ( #5997 )
...
This change fixes floating point errors in conversion of shares to assets and other way, used in `VaultDeposit`, `VaultWithdraw` and `VaultClawback`. In the floating point calculations the division introduces a larger error than multiplication. If we do division first, then the error introduced will be increased by the multiplication that follows, which is therefore the wrong order to perform these two operations. This change flips the order of arithmetic operations, which minimizes the error.
2025-11-11 19:39:09 +00:00
Ayaz Salikhov
c2a90b706f
ci: Specify bash as the default shell in workflows ( #6021 )
2025-11-11 18:17:03 +00:00
Jingchen
9ffb434315
refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE macros ( #6014 )
...
Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
2025-11-11 12:45:13 -05:00
Jingchen
ff18cfef96
refactor: Retire DepositPreAuth and DepositAuth amendments ( #5978 )
...
Amendments activated for more than 2 years can be retired. This change retires the fDepositPreAuth and DepositAuth amendments.
2025-11-11 15:21:07 +00:00
Bronek Kozicki
03704f712b
chore: Move running of unit tests out of coverage target ( #6018 )
...
This change makes the progress of unit tests visible and also gives more flexibility when running them.
2025-11-11 14:55:16 +00:00
Pratik Mankawde
9b332d88c1
refactor: Retire PayChanRecipientOwnerDir amendment ( #5946 )
...
Amendments activated for more than 2 years can be retired. This change retires the PayChanRecipientOwnerDir amendment.
2025-11-11 09:07:45 -05:00
Ed Hennis
ab740d94e6
fix: Update lastRotated to the current validated seq + 2
...
- First approximation. Good enough and consistent enough for unit tests.
Not sure about real world, but it'll be an improvement either way.
2025-11-10 19:53:53 -05:00
Ed Hennis
ae3e4aa56b
Create a unit test demonstrating "lost" ledgers
...
- It is possible for changed ledger objects to be written to the
ArchiveDB during the online delete rotation process before the
writable DB is created. When the rotation finishes, `lastRotated` is
updated to the ledger sequence from when the process started, on the
assumption that all ledgers after that will be written to the new
writable DB, but some of them are in the old DB. Next time rotation
runs, the data for those old ledgers is not brought over, and thus is
deleted from the Archive DB.
2025-11-10 19:53:53 -05:00